From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E0E78A0C3F; Mon, 28 Jun 2021 09:58:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6397D40692; Mon, 28 Jun 2021 09:58:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 527E54068A for ; Mon, 28 Jun 2021 09:58:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1624867099; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=8c9uBkK4/CDTTWQXWjew/+Flax/9L7U62wQH0OYh2YU=; b=GxQwUyIaIyol0WsnPVPcPTPkyeSp24mxg8xdmXn5AIDnM2OQh2g1hushwyKH9lvnfDLlz5 +rzsu2JSUnM+L6Tr2zAJtNAF39ynfHZkx3YMIYdd02pqc7k5clCQAOLBniGiJBVxt6RFz0 z6x4io32hlmvhECuV05IAFZa3JxdgJc= Received: from mail-vs1-f71.google.com (mail-vs1-f71.google.com [209.85.217.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158--9pXSb8iPHSxWTNg33E6TQ-1; Mon, 28 Jun 2021 03:58:18 -0400 X-MC-Unique: -9pXSb8iPHSxWTNg33E6TQ-1 Received: by mail-vs1-f71.google.com with SMTP id 2-20020a6715020000b0290265763e68acso3944117vsv.5 for ; Mon, 28 Jun 2021 00:58:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8c9uBkK4/CDTTWQXWjew/+Flax/9L7U62wQH0OYh2YU=; b=NRBPspAec/8Nk5NjY0uRMWDKkPv/2YebgIvgaPD2qjGceiJsFDL/SaKzQZJ6N5obaw xonztmZodaKGVSjKpOpB/4aTq16VUNcx3HVZfeSfYiw+Oh6/VBAWtBnq6NvtC5xGbpVL S7o2yGcKyL36YgCuxkkrqQpD9ILDqVdLzaq9hxigddIkl60xboCsbEs5GBhmOv+UiZFP NTyA2ZfoCWH5kwgYqAVb5F+v7r3ZmYHfy65oTorObP77R1Sq4ceiY4oaQwkl+QJr+j5g 8NGUoC6DBityTA9/SEiOF6GXd7Hm5/uLkbQ1kKDXP/MksbK7O+d624GHMwbDZv+GlIC3 7nTg== X-Gm-Message-State: AOAM533NbxH7RRlVIIIdOPe5rCYjj3yY7iVrPc/C4DfV5c+y5dn+jfcd vxmK29QtcJuUiWoD6uWxZOigHrYLxOWsCXJGY6po6PaCK+FmNyrWXcYN18Gs9lIHQZnsNvg5tRJ HSjedHzhI4E3Sqn4TpWE= X-Received: by 2002:ab0:211a:: with SMTP id d26mr19964500ual.41.1624867097748; Mon, 28 Jun 2021 00:58:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwzNRNQs2kGrpe6V0OuzvNcM5LzB4xQSS7fseDNa6Dsw/7uQacXlfzv9Lem3tXTDsKun2x5Wjty3ncEpGrAuNs= X-Received: by 2002:ab0:211a:: with SMTP id d26mr19964494ual.41.1624867097531; Mon, 28 Jun 2021 00:58:17 -0700 (PDT) MIME-Version: 1.0 References: <20210602095836.24901-1-david.marchand@redhat.com> <20210603165512.7357-1-david.marchand@redhat.com> <20210603165512.7357-2-david.marchand@redhat.com> In-Reply-To: <20210603165512.7357-2-david.marchand@redhat.com> From: David Marchand Date: Mon, 28 Jun 2021 09:58:06 +0200 Message-ID: To: Qiming Yang , Qi Zhang Cc: dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ice: factorize firmware loading X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 3, 2021 at 6:55 PM David Marchand wrote: > > Both "normal" and "dcf" inits have their copy of some firmware loading > code. > > The DSN query is moved in specific parts for the "normal" and "dcf" init. > > A common helper ice_load_pkg is then introduced and takes an adapter > pointer as its main input. > > This helper takes care of finding the right firmware file and loading > it. > The adapter active_pkg_type field is set by this helper. > > The ice_access macro is removed from the osdep.h header: osdep.h should > only hosts wrappers for base driver code. > > Signed-off-by: David Marchand Please, can you confirm nothing breaks for net/ice with this series? Thanks. -- David Marchand