From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ED2F0A034F; Tue, 28 Apr 2020 09:41:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B0D5E1D510; Tue, 28 Apr 2020 09:40:59 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.120]) by dpdk.org (Postfix) with ESMTP id 1A0331D50E for ; Tue, 28 Apr 2020 09:40:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1588059657; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=AWUoTiilQRD0Nwp8m409q+6fe/swA+zQj6IwqUr4Eh8=; b=SDPwEL+fJ4URFnf+715TX+AgyltEVSa5Ut9oIBjeSiNFIYPsCkhVPN4fN0BpbKqZdPwLM1 YUXi3pL44iW105h0DHrHMjVHGaOZmgP0DBKXdOZy3hbEDkR1d7+kbB2dBr8tRykFnr7KGY Tvaxm8Ahvf6L5OIAInl/KXdhO5UB4c4= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-385-XUdHY8htNMec1l2urH3aLg-1; Tue, 28 Apr 2020 03:40:55 -0400 X-MC-Unique: XUdHY8htNMec1l2urH3aLg-1 Received: by mail-vk1-f197.google.com with SMTP id f142so10524134vke.1 for ; Tue, 28 Apr 2020 00:40:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cv+NpWMeB5b4ypY++HH7p4fd3QTbsdLqDxv6AlZwIsM=; b=Eb455CAQaz1MPuG6CX1867sTV1EXtFafSTvpV2h59X90EC9dnZKnmq9fpilOgtUXHm 6NV+A6J+dXxEJOVa8VkPeIj9fR5gxJD3K8urLfPDDnQgclIxCjFNKkiDarDnBABX56DU 7kolNPDNyKaqbt0uIhD+5iR/FDkq8NaVKlkwC1TUr8OqcquWGZPEl12mpsg8/PPEGq2g TFigznIS0lMqnZR2BsqP7cu1Hc6xfwErWTObQQTN52VenKuyy3UTAZ4BBqaGZmKkkfJ6 MpJkqOqJeNclLdzYCtAFtrVJLfqOCA+/6HlTpitegzLRJOkYJM5iQp375kAq2BMku0ha o/1Q== X-Gm-Message-State: AGi0PuYWQx3wfAwojHpvvVryMvWD6JrhG4KoJgeV62AJNXq2Io2CI/QO MjjI6Do4EaLIx7lm29iUo87Fi/uUZ7qUjmuX1bWuVudvVJsGgkjaySPHxViG/+NYnWj7qxa6ICi ktpF78l/Hrgyq9J8BqHc= X-Received: by 2002:a1f:8cc3:: with SMTP id o186mr15727263vkd.18.1588059655184; Tue, 28 Apr 2020 00:40:55 -0700 (PDT) X-Google-Smtp-Source: APiQypLfFqw7v2Q7YBjKR6+ffnuuvdzbyNH176VgycPh6+Xny83E4paC45rXn5UD54meLiPh7o8EnNYRUNR+LNASxA4= X-Received: by 2002:a1f:8cc3:: with SMTP id o186mr15727253vkd.18.1588059654879; Tue, 28 Apr 2020 00:40:54 -0700 (PDT) MIME-Version: 1.0 References: <20200427213926.12306-1-stephen@networkplumber.org> In-Reply-To: <20200427213926.12306-1-stephen@networkplumber.org> From: David Marchand Date: Tue, 28 Apr 2020 09:40:43 +0200 Message-ID: To: Stephen Hemminger Cc: dev , pascal.mazon@6wind.com, Keith Wiles , Olga Shern X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] net/tap: fix crash from unitialized memory in rte_flow_destroy X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 27, 2020 at 11:39 PM Stephen Hemminger wrote: > > The TAP driver does not initialize all the elements of the rte_flow > structure. This can lead to crash in rte_flow_destroy. > > (gdb) where > flow=3D0x100e99280, error=3D0x0) > at drivers/net/tap/tap_flow.c:1514 > > (gdb) p remote_flow > $1 =3D (struct rte_flow *) 0x6b6b6b6b6b6b6b6b > > Which is here: > static int > tap_flow_destroy_pmd(struct pmd_internals *pmd, > struct rte_flow *flow, > struct rte_flow_error *error) > { > struct rte_flow *remote_flow =3D flow->remote_flow; > ... > if (remote_flow) { > remote_flow->msg.nh.nlmsg_flags =3D NLM_F_REQUEST | NLM_F= _ACK; > > Simplest fix is to use rte_zmalloc() so remote_flow and other fields > are always set at zero. > > Fixes: 2bc06869cd94 ("net/tap: add remote netdevice traffic capture") > Cc: pascal.mazon@6wind.com Not sure why you copied Pascal (I'd say he stopped working on dpdk 2 years = ago). Please use the devtools/get-maintainer.sh script. Thanks. --=20 David Marchand