From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 93CD7A04FB; Tue, 17 Dec 2019 09:43:40 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BBF4C2C17; Tue, 17 Dec 2019 09:43:39 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 3A05C1F5 for ; Tue, 17 Dec 2019 09:43:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576572217; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vUygrjC3E5klLc7My7q5QRKzevYmkB8ebarVJ71P2ks=; b=jPhBv/F2BpBPfZME3GetqZ0w0lFcCv+iXFKCEab0EuB4xKBRzvt8A8vUV4lrp8tAJaXxZ7 i/Vt6VmpX8yOihmbZ6a09p2PQAd9gwi5jZ2Rgl0wj1Jyr8XjtqdNufCAfeij5fYGm5IFmF CLscbzwpJVp5CAIgGcsXEvGUlXNAzvQ= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-27-CLl443-SPgeGx_whY5R3GQ-1; Tue, 17 Dec 2019 03:43:36 -0500 Received: by mail-vk1-f198.google.com with SMTP id y28so4838217vkl.23 for ; Tue, 17 Dec 2019 00:43:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KTvrlYo+NjQJvrfhX2niKFl64+0bVFbKbx0KaA/fhgU=; b=K73r660OZDoOYa5MoEjHnnNDwtlFmVoh4o6FsKd9fkR4GlAxHfK3/aULvlunIpn04g xBw3LBJLpPo8mgfD9QHkB9UxTvYqdN4EmxrY0Wc6STRNIz4n5scK/254RuxWavQ4rC26 EH+wozRu3O8p/de6hBuCVEESkZzxwE6oJwRhIczud0XGXOYpGBAwHAr8PbKMKtMeSxw2 9aSEPLRE8yiwiqS7va4T3A9s5hBsS3eptmSasotQDty0xq/Pn+1M1FPHoSLwISyzchq6 r6qn1BOWqzjUr81jKpunhP7mxFm/FxiYPvqjHOvd8xsu1bdBooY3ChC5S4im3NCltQTx V3DA== X-Gm-Message-State: APjAAAXRUnD+zPiAymMRldX0E9yP1yW8toko584+jNcnId8aPff5Da+l 4vgjztPh9ay1h7C6Pe6lE36rY6eeXGkty9EP1lKzJxKluSQULsqwONUPhu+yU3Hf24HItJEry4h 6GeCaHRSFL9ISEjWCslw= X-Received: by 2002:a1f:5385:: with SMTP id h127mr2377251vkb.56.1576572215855; Tue, 17 Dec 2019 00:43:35 -0800 (PST) X-Google-Smtp-Source: APXvYqz5QjnS7p/6+KtkBHx0psMCs2NYSr4YD4v9levL8N2GV+FyM38w6I2b28PKkgxJSmeVNEe0rx9ENfIW5N4QZ4w= X-Received: by 2002:a1f:5385:: with SMTP id h127mr2377243vkb.56.1576572215595; Tue, 17 Dec 2019 00:43:35 -0800 (PST) MIME-Version: 1.0 References: <20191217104347.21955-1-lironh@marvell.com> In-Reply-To: <20191217104347.21955-1-lironh@marvell.com> From: David Marchand Date: Tue, 17 Dec 2019 09:43:24 +0100 Message-ID: To: Liron Himi Cc: dev , Cristian Dumitrescu X-MC-Unique: CLl443-SPgeGx_whY5R3GQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] lib/cfgfile: update map file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Comment on the patch title, we never prefix titles with lib/. This is implicit and just makes the title longer. Please look at the dpdk git history. I would go with the 'cfgfile: ' prefix. On Tue, Dec 17, 2019 at 9:28 AM wrote: > > From: Liron Himi > > rte_cfgfile_section_num_entries_by_index was missing from the map > file. > meson build failed when calling this function The problem is not linked to meson, but linking a binary to cfgfile built as a shared library. We are missing a Fixes: line and a Cc: stable@dpdk.org (the backport won't apply cleanly though). > > Signed-off-by: Liron Himi > --- > lib/librte_cfgfile/rte_cfgfile_version.map | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_cfgfile/rte_cfgfile_version.map b/lib/librte_cfgf= ile/rte_cfgfile_version.map > index 906eee96b..b0389e7d8 100644 > --- a/lib/librte_cfgfile/rte_cfgfile_version.map > +++ b/lib/librte_cfgfile/rte_cfgfile_version.map > @@ -14,6 +14,7 @@ DPDK_20.0 { > rte_cfgfile_save; > rte_cfgfile_section_entries; > rte_cfgfile_section_entries_by_index; > + rte_cfgfile_section_num_entries_by_index; Those entries must be sorted in alphabetical order. > rte_cfgfile_section_num_entries; > rte_cfgfile_sections; > rte_cfgfile_set_entry; > -- > 2.23.0 > --=20 David Marchand