[PATCH] remove extension keyword for flex arrays

[PATCH] remove extension keyword for flex arrays

[David Marchand]

Flex arrays are part of the C99 standard.
No need to mark them with __extension__.

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
I noticed this while reviewing Tyler series on some libraries.
Let's see if the compilers in the CI agrees with the patch.

---
 drivers/crypto/ipsec_mb/ipsec_mb_private.h | 2 +-
 lib/cryptodev/rte_cryptodev.h              | 2 +-
 lib/ip_frag/ip_reassembly.h                | 2 +-
 lib/ipsec/ipsec_sad.c                      | 2 +-
 lib/ipsec/sa.h                             | 2 +-
 lib/rib/rte_rib.c                          | 2 +-
 lib/rib/rte_rib6.c                         | 2 +-
 7 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/crypto/ipsec_mb/ipsec_mb_private.h b/drivers/crypto/ipsec_mb/ipsec_mb_private.h
index 52722f94a0..be6dbe9b1b 100644
--- a/drivers/crypto/ipsec_mb/ipsec_mb_private.h
+++ b/drivers/crypto/ipsec_mb/ipsec_mb_private.h
@@ -125,7 +125,7 @@ struct ipsec_mb_dev_private {
 	/**< PMD  type */
 	uint32_t max_nb_queue_pairs;
 	/**< Max number of queue pairs supported by device */
-	__extension__ uint8_t priv[];
+	uint8_t priv[];
 };
 
 /** IPSEC Multi buffer queue pair common queue pair data for all PMDs */
diff --git a/lib/cryptodev/rte_cryptodev.h b/lib/cryptodev/rte_cryptodev.h
index 00ba6a234a..31881123f9 100644
--- a/lib/cryptodev/rte_cryptodev.h
+++ b/lib/cryptodev/rte_cryptodev.h
@@ -1525,7 +1525,7 @@ struct rte_crypto_raw_dp_ctx {
 	cryptodev_sym_raw_operation_done_t dequeue_done;
 
 	/* Driver specific context data */
-	__extension__ uint8_t drv_ctx_data[];
+	uint8_t drv_ctx_data[];
 };
 
 /**
diff --git a/lib/ip_frag/ip_reassembly.h b/lib/ip_frag/ip_reassembly.h
index 5443c738a6..54afed5417 100644
--- a/lib/ip_frag/ip_reassembly.h
+++ b/lib/ip_frag/ip_reassembly.h
@@ -82,7 +82,7 @@ struct rte_ip_frag_tbl {
 	struct ip_frag_pkt *last;     /* last used entry. */
 	struct ip_pkt_list lru;       /* LRU list for table entries. */
 	struct ip_frag_tbl_stat stat; /* statistics counters. */
-	__extension__ struct ip_frag_pkt pkt[]; /* hash table. */
+	struct ip_frag_pkt pkt[]; /* hash table. */
 };
 
 #endif /* _IP_REASSEMBLY_H_ */
diff --git a/lib/ipsec/ipsec_sad.c b/lib/ipsec/ipsec_sad.c
index 7cb492d187..7e147e729c 100644
--- a/lib/ipsec/ipsec_sad.c
+++ b/lib/ipsec/ipsec_sad.c
@@ -42,7 +42,7 @@ struct rte_ipsec_sad {
 	 * (spi_dip or spi_dip_sip). Used only in add/delete
 	 * as a helper struct.
 	 */
-	__extension__ struct hash_cnt cnt_arr[];
+	struct hash_cnt cnt_arr[];
 };
 
 TAILQ_HEAD(rte_ipsec_sad_list, rte_tailq_entry);
diff --git a/lib/ipsec/sa.h b/lib/ipsec/sa.h
index 2560d33d84..719b5c735c 100644
--- a/lib/ipsec/sa.h
+++ b/lib/ipsec/sa.h
@@ -59,7 +59,7 @@ union sym_op_data {
 struct replay_sqn {
 	rte_rwlock_t rwl;
 	uint64_t sqn;
-	__extension__ uint64_t window[];
+	uint64_t window[];
 };
 
 /*IPSEC SA supported algorithms */
diff --git a/lib/rib/rte_rib.c b/lib/rib/rte_rib.c
index aa3296de19..b95d329c8b 100644
--- a/lib/rib/rte_rib.c
+++ b/lib/rib/rte_rib.c
@@ -40,7 +40,7 @@ struct rte_rib_node {
 	uint8_t		depth;
 	uint8_t		flag;
 	uint64_t	nh;
-	__extension__ uint64_t ext[];
+	uint64_t ext[];
 };
 
 struct rte_rib {
diff --git a/lib/rib/rte_rib6.c b/lib/rib/rte_rib6.c
index b7df3926f8..89c8390c63 100644
--- a/lib/rib/rte_rib6.c
+++ b/lib/rib/rte_rib6.c
@@ -38,7 +38,7 @@ struct rte_rib6_node {
 	uint8_t			ip[RTE_RIB6_IPV6_ADDR_SIZE];
 	uint8_t			depth;
 	uint8_t			flag;
-	__extension__ uint64_t ext[];
+	uint64_t ext[];
 };
 
 struct rte_rib6 {
-- 
2.44.0

RE: [PATCH] remove extension keyword for flex arrays

[Morten Brørup]

> From: David Marchand [mailto:david.marchand@redhat.com]
> Sent: Wednesday, 12 June 2024 09.13
> 
> Flex arrays are part of the C99 standard.
> No need to mark them with __extension__.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---

Thank you for cleaning this up.
Acked-by: Morten Brørup <mb@smartsharesystems.com>

Re: [PATCH] remove extension keyword for flex arrays

[David Marchand]

On Wed, Jun 12, 2024 at 9:43 AM Morten Brørup <mb@smartsharesystems.com> wrote:
> >
> > Flex arrays are part of the C99 standard.
> > No need to mark them with __extension__.
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>

CI is happy, and so am I.
Applied, thanks.


-- 
David Marchand