From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 09716A055A; Tue, 25 Feb 2020 14:53:05 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 020041BF8D; Tue, 25 Feb 2020 14:53:04 +0100 (CET) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 7B0BF1BC24 for ; Tue, 25 Feb 2020 14:53:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582638782; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RMUNemFUwmzTITHVx2ffj0QDY4JNAhJf7q4qQnXIhP4=; b=Bz2Ggua6kbhgy6UbIAkhPZDNqCGHAxm8yTJQz8DvzsfLvuje2qLorOpu7PQJIwc324nAWk xHSxzzo1ZJ6BdZ6lI8FUgmI1azXTX8DzF+GJR9a6CdHc79P8swAvJWj+zrtDL35pxQgfvS +TcPSqdIzpTJ+jLnt2vGBOsxfW+OFFw= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-366-k2XGXPfmPZuF3s0f1xb67w-1; Tue, 25 Feb 2020 08:53:00 -0500 X-MC-Unique: k2XGXPfmPZuF3s0f1xb67w-1 Received: by mail-vk1-f197.google.com with SMTP id s4so5915842vkk.7 for ; Tue, 25 Feb 2020 05:53:00 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wiWuDpgbmZlOY/NEbVItVzH4WatS5ISp3tcLXJfyNmc=; b=U1baGh5f54jhvYmvzPkPNPhSzlAGwBiq83tOvytDmo2iRjiQIc7ccoBqCrYslaHWeW B84WmnT/b5dQFfHIZQNiUkBs8w8EDDbX9mznZoqXVqtXrf+25h0iIB9OA6Vyl1e8TAK8 3uvbziIuYolpJDF95gpnj1tRqfvATxgkpwyj5iFkFUHm23nRDD6QU3ph+gYmNa6Pqs0A WMVE+Igntf0QPyOw4W6xRe1SAnS5JZAwGj7LGtF12Q7ok2n2r/U19xs+bt7ZZETxrnBA dN3hNopLx8T/mFujeFmEOm+LKMxUUoGmYRkArGkKaFPBWBC95LjTdQCPWc3Ook+t7NcN M8Fw== X-Gm-Message-State: APjAAAUq5u9SygzS2kXhy6yRNndkGX31LVUA36OvRY2KCcIfVxwUkh/q sGLXHElQ1tgDzVKZxrx8kp6gFhh6hZa7ywI3v1mT/eDIsQg/tQVAyR9Aki39e0pC9eX1Wr3X+ep 0yh5TJHziXbUqOyIZ5dc= X-Received: by 2002:ab0:488b:: with SMTP id x11mr27815674uac.86.1582638779573; Tue, 25 Feb 2020 05:52:59 -0800 (PST) X-Google-Smtp-Source: APXvYqxX6SMkXVncukq6YhanN0oOBtnpF5xmjn1YlkcrXZJp2T9JRILjfpKapsc8hlkH5JNdhmfvhaXzz2eR+O+n5Ck= X-Received: by 2002:ab0:488b:: with SMTP id x11mr27815662uac.86.1582638779337; Tue, 25 Feb 2020 05:52:59 -0800 (PST) MIME-Version: 1.0 References: <20200130142003.2645765-1-ferruh.yigit@intel.com> In-Reply-To: <20200130142003.2645765-1-ferruh.yigit@intel.com> From: David Marchand Date: Tue, 25 Feb 2020 14:52:48 +0100 Message-ID: To: Ferruh Yigit Cc: Neil Horman , John McNamara , Marko Kovacevic , dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] doc: deprecate using MAX values as array size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jan 30, 2020 at 3:20 PM Ferruh Yigit wrote= : > Adding the deprecation notice as reminder for next ABI breakage release > (20.11). > This one time breakage is required to be able to extend enum/define > without breaking ABI. > > Signed-off-by: Ferruh Yigit > --- > doc/guides/rel_notes/deprecation.rst | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/= deprecation.rst > index dfcca87ab..99d81564a 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -38,6 +38,20 @@ Deprecation Notices > remove it from the externally visible ABI and allow it to be updated i= n the > future. > > +* lib: will fix extending some enum/define breaking the ABI. There are m= ultiple > + samples in DPDK that enum/define terminated with a ``.*MAX.*`` value w= hich is > + used by iterators, and arrays holding these values are sized with this > + ``.*MAX.*`` value. So extending this enum/define increases the ``.*MAX= .*`` > + value which increases the size of the array and depending on how/where= the > + array is used this may break the ABI. > + ``RTE_ETH_FLOW_MAX`` is one sample of the mentioned case, adding a new= flow > + type will break the ABI because of ``flex_mask[RTE_ETH_FLOW_MAX]`` arr= ay > + usage in following public struct hierarchy: > + ``rte_eth_fdir_flex_conf -> rte_fdir_conf -> rte_eth_conf (in the midd= le)``. > + Need to identify this kind of usages and fix in 20.11, otherwise this = blocks > + us extending existing enum/define. > + One solution can be using a fixed size array instead of ``.*MAX.*`` va= lue. > + > * dpaa2: removal of ``rte_dpaa2_memsegs`` structure which has been repla= ced > by a pa-va search library. This structure was earlier being used for h= olding > memory segments used by dpaa2 driver for faster pa->va translation. Th= is > -- > 2.24.1 > Acked-by: David Marchand -- David Marchand