From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EDED542CA9; Tue, 13 Jun 2023 15:43:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8717C40A8A; Tue, 13 Jun 2023 15:43:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 521C340698 for ; Tue, 13 Jun 2023 15:43:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686663832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dDgJXs9kueZqwnCPIWr7Q3rcy7nGYfoNbZVF/1TOhg0=; b=URud+rMCmn+WyFwKDZvPh6IruvEjrVsDHrwrjefsUdky5h1W1qudl3FD6AXtB720nzIfHx Oumted6jwP9jAWTwZz9bBIw1cmh8dxRuI3uEO/LivyXBc6cZxuJjzNSHaIV3Ffhi2QfMNJ XE+ZWXqWMPX13yzYUnOUPilVBUqFMxE= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-509-g1yGE3auNTKeNEnvUKTFIw-1; Tue, 13 Jun 2023 09:43:47 -0400 X-MC-Unique: g1yGE3auNTKeNEnvUKTFIw-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-25c13937316so389113a91.2 for ; Tue, 13 Jun 2023 06:43:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686663826; x=1689255826; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dDgJXs9kueZqwnCPIWr7Q3rcy7nGYfoNbZVF/1TOhg0=; b=FluPOjqutrdpvYNNOvtVqjcmieMwPSxqZ+LAsIC28tfVJjaK6VS/nOUmPs1165BLnk lLkEu+dWjlZnsgkRmyErZXFy1smxeFkYpL9e0U3/soVTogryH+jf9o1Zw9utgoC9ejAo vCTpOEGQVp6b9K/SIydoQeH7Nojun0A9uL9Lc68yaYJNEQSRa1e2b/Kp215hNnxrFlMw ry2t90RFHhDOCA9ON1NdtTN33zi+2NX5UzQCk3fZCoRQbZQETzGn24GLmZbo3AtQZ26x OgkCaMVByHzzWVcRsn2EmH1REzkyYsEjPpxNKwwfWgM9yhndbB/htbI+zmDO8GOSXTtz aOvw== X-Gm-Message-State: AC+VfDxZYrvomCwG6uLauOFEkq1Y5x74oU+tEXyRlnMHtwBz7V0drxh2 P0h0+mgTHJ906w2vNtVgEbdXDnCXYC/ga0FnAhNaoVq/cJH8uxJA82ucPkIZLdAcnTEGqRV7cb7 ejrLZ+XtTbpc/F0HKiO4= X-Received: by 2002:a17:90a:7e02:b0:250:ab4f:59b1 with SMTP id i2-20020a17090a7e0200b00250ab4f59b1mr10270579pjl.11.1686663826043; Tue, 13 Jun 2023 06:43:46 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4b7VYM7ZNAQS8nYFl6/KCjcAw1jIVEkDbwAlOTuNfVF3n/B9Sd9sGdGb2H7XELEicBV5d+re/MlnmLUxlsIVs= X-Received: by 2002:a17:90a:7e02:b0:250:ab4f:59b1 with SMTP id i2-20020a17090a7e0200b00250ab4f59b1mr10270566pjl.11.1686663825772; Tue, 13 Jun 2023 06:43:45 -0700 (PDT) MIME-Version: 1.0 References: <20230612162104.170749-1-bruce.richardson@intel.com> <20230612171456.173378-1-bruce.richardson@intel.com> In-Reply-To: <20230612171456.173378-1-bruce.richardson@intel.com> From: David Marchand Date: Tue, 13 Jun 2023 15:43:34 +0200 Message-ID: Subject: Re: [PATCH v2 1/2] build: change flag variable type to boolean To: Bruce Richardson Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Jun 12, 2023 at 7:15=E2=80=AFPM Bruce Richardson wrote: > > The has_libnuma flag was using 0 and 1 integer values, instead of the > more appropriate boolean type. Change to use true/false instead. > > Signed-off-by: Bruce Richardson This patch lgtm (with or without the suggestion on config/arm below). Reviewed-by: David Marchand [snip] > diff --git a/config/arm/meson.build b/config/arm/meson.build > index 43f6a551a2..faba5e38cf 100644 > --- a/config/arm/meson.build > +++ b/config/arm/meson.build > @@ -592,7 +592,7 @@ if update_flags > part_number =3D soc_config['part_number'] > soc_flags =3D soc_config.get('flags', []) > if not soc_config.get('numa', true) > - has_libnuma =3D 0 > + has_libnuma =3D false > endif Maybe has_libnuma =3D soc_config.get('numa', true) ? > > disable_drivers +=3D ',' + soc_config.get('disable_drivers', '') The same cleanup could be done to has_libfdt. Additionnally, I wonder if we could remove those "=3D=3D true" or "=3D=3D false" checks here and there in meson.build files. --=20 David Marchand