From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3114DA0C45; Wed, 6 Oct 2021 09:11:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 161E7410FA; Wed, 6 Oct 2021 09:11:20 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 97EC9410F6 for ; Wed, 6 Oct 2021 09:11:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1633504278; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Yn+Wy8ZvUNx0PVMh9xZlmT6cozfg+Tb1a69Nchee160=; b=DOYYL8gOzK2Rg9qxH7HleUdHTiGz+sxA5lYUANBOCXflM/jIrizdRj+n+lj6u5czKHe60K KJlzQZsiu+S/7qN0+Nq9+TswV+DfDYJQ4pwVNLmvKUpyVWXjO3+X58+t6fGSczjM15J2t4 4Jg6PSAblb0dJGhiqXkyEbCvuyTb6DU= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-523-C6ZLNXO6O7OodfeS2olGYA-1; Wed, 06 Oct 2021 03:11:17 -0400 X-MC-Unique: C6ZLNXO6O7OodfeS2olGYA-1 Received: by mail-lf1-f71.google.com with SMTP id bq35-20020a056512152300b003fd45087a72so1231617lfb.9 for ; Wed, 06 Oct 2021 00:11:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Yn+Wy8ZvUNx0PVMh9xZlmT6cozfg+Tb1a69Nchee160=; b=KnYw3v7Vb5bO4zCowjCYuOhngyxfiB5CdHFfu5R8UiAIlV4D7VeuJo7batsxhqGr5o /VUZjhUfD4CMRP7PMT3kYkKqzjY+zgoS2hndE5qlsH7ymqpaofdOXBrk6Ebrnd4KwQlv gGFkbJ06Sz2qO19npDBaIV5A02WMveH0HXiXrLyFA0qGnXpM5mVPwrLeIURSG4SI5m3n RdeLiMp0wtAi8X2+VtmH5VZ/uqAG+e62gH3cR0xjTlkbB2EpHdToHJZygvDKFRl8VTLe FKjc6TaEU84ZTCiZtr0CW+jknAB55mJNOT0hErSci+nSlqhH5beh9dm6M7JWyZwawyNK 7GfA== X-Gm-Message-State: AOAM533jjaSUw9p57Ti8WB/WnAtsgB1BTAexCYpdo1btCorGxC94Z9h7 shPwchKVX14qbSZpkA7p/MS7PETw8fKCzl35UcU1POJOQdFarDtXiuaplRz9JdItKvyPxnBzRub jDTVwKViaMEKHBB0ykYo= X-Received: by 2002:a2e:8584:: with SMTP id b4mr28152264lji.477.1633504275573; Wed, 06 Oct 2021 00:11:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyMKB0zKQixXnl78gMQK1y+P1A3lXquOts8rTHWlA7zLNwiPciKgUwsNCgvFx+4x/VRp+rkH8BKircXOCKnpK4= X-Received: by 2002:a2e:8584:: with SMTP id b4mr28152243lji.477.1633504275341; Wed, 06 Oct 2021 00:11:15 -0700 (PDT) MIME-Version: 1.0 References: <20211003082710.8398-1-pbhagavatula@marvell.com> <20211006065012.16508-1-pbhagavatula@marvell.com> <20211006065012.16508-14-pbhagavatula@marvell.com> In-Reply-To: <20211006065012.16508-14-pbhagavatula@marvell.com> From: David Marchand Date: Wed, 6 Oct 2021 09:11:04 +0200 Message-ID: To: Pavan Nikhilesh , Ray Kinsella Cc: Jerin Jacob Kollanukkaran , dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v3 14/14] eventdev: mark trace variables as internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Pavan, Ray, On Wed, Oct 6, 2021 at 8:52 AM wrote: > > From: Pavan Nikhilesh > > Mark rte_trace global variables as internal i.e. remove them > from experimental section of version map. > Some of them are used in inline APIs, mark those as global. > > Signed-off-by: Pavan Nikhilesh > Acked-by: Ray Kinsella Please, sort those symbols. I check with ./devtools/update-abi.sh $(cat ABI_VERSION) > --- > lib/eventdev/version.map | 77 ++++++++++++++++++---------------------- > 1 file changed, 35 insertions(+), 42 deletions(-) > > diff --git a/lib/eventdev/version.map b/lib/eventdev/version.map > index 068d186c66..617fff0ae6 100644 > --- a/lib/eventdev/version.map > +++ b/lib/eventdev/version.map > @@ -88,57 +88,19 @@ DPDK_22 { > rte_event_vector_pool_create; > rte_eventdevs; > > - #added in 21.11 > - rte_event_fp_ops; > - > - local: *; > -}; > - > -EXPERIMENTAL { > - global: > - > # added in 20.05 At the next ABI bump, ./devtools/update-abi.sh will strip those comments from the stable section. You can notice this when you run ./devtools/update-abi.sh $CURRENT_ABI as suggested above. I would strip the comments now that the symbols are going to stable. Ray, do you have an opinion? -- David Marchand