From: David Marchand <david.marchand@redhat.com>
To: Thomas Monjalon <thomas@monjalon.net>,
John McNamara <john.mcnamara@intel.com>
Cc: Marko Kovacevic <marko.kovacevic@intel.com>, dev <dev@dpdk.org>,
Flavia <flavia.musatescu@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: fix release notes for removed testpmd commands
Date: Wed, 9 Oct 2019 16:57:14 +0200 [thread overview]
Message-ID: <CAJFAV8zGMo6CfMuPnDy7=rD+585aNmSzGjUV0jyh6yHhWCJGgA@mail.gmail.com> (raw)
In-Reply-To: <20191009134709.1007-1-thomas@monjalon.net>
On Wed, Oct 9, 2019 at 3:47 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> The notes were not visible in the generated doc output because
> of an indentation mistake.
> While fixing the indentation, the formatting is improved.
>
> Fixes: e5db17a1e54e ("app/testpmd: remove duplicated Rx offload commands")
> Cc: flavia.musatescu@intel.com
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> doc/guides/rel_notes/release_19_11.rst | 19 +++++++++++--------
> 1 file changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_notes/release_19_11.rst
> index be91b04ad9..0062e012ed 100644
> --- a/doc/guides/rel_notes/release_19_11.rst
> +++ b/doc/guides/rel_notes/release_19_11.rst
> @@ -91,14 +91,17 @@ Removed Items
> Also, make sure to start the actual text at the margin.
> =========================================================
>
> - * Removed duplicated set of commands for RX offloading configuration from app/testpmd:
> - “port config all crc-strip|scatter|rx-cksum|rx-timestamp|hw-vlan|hw-vlan-filter|
> - hw-vlan-strip|hw-vlan-extend on|off”.
> -
> - The testpmd commands set that can be used instead in order to enable or disable Rx
> - offloading on all Rx queues of a port is:
> - "port config <port_id> rx_offload crc_strip|scatter|ipv4_cksum|udp_cksum|tcp_cksum|
> - timestamp|vlan_strip|vlan_filter|vlan_extend on|off"
> +* Removed duplicated set of commands for Rx offload configuration from testpmd::
> +
> + port config all crc-strip|scatter|rx-cksum|rx-timestamp|
> + hw-vlan|hw-vlan-filter|hw-vlan-strip|hw-vlan-extend on|off
> +
> + The testpmd commands set that can be used instead
> + in order to enable or disable Rx offloading on all Rx queues of a port is::
A bit hard to digest: "can be used instead in order to".
Might be worth some proofreading, John?
> +
> + port config <port_id> rx_offload crc_strip|scatter|
> + ipv4_cksum|udp_cksum|tcp_cksum|timestamp|
> + vlan_strip|vlan_filter|vlan_extend on|off
>
>
> API Changes
But at least the generated doc now contains something :-)
Reviewed-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
next prev parent reply other threads:[~2019-10-09 14:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 13:47 Thomas Monjalon
2019-10-09 14:57 ` David Marchand [this message]
2019-10-24 12:16 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zGMo6CfMuPnDy7=rD+585aNmSzGjUV0jyh6yHhWCJGgA@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=flavia.musatescu@intel.com \
--cc=john.mcnamara@intel.com \
--cc=marko.kovacevic@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).