From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9558EA3160 for ; Wed, 9 Oct 2019 16:57:30 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E89D91E8A7; Wed, 9 Oct 2019 16:57:29 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id D0E411E886 for ; Wed, 9 Oct 2019 16:57:28 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1570633048; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=qb0c2YDv+5pT9nuIaPy4tBmPQgLECS8byCBBtyizFyY=; b=bZF6ghAi9jjJiqOh3WdlbkGUARZdm1PtQMI0OQt4KeKmAQnfqMOYSgYaCkPkiJEuuZg6ZP 6Frct/0wZ1mSt7DOozNLKw0DHlkmQRyzCewrg/yNNj8+CJ7x03fL7fKGG+TbIpJ2q/qYzJ ZrYV6adBygvoWMuNjWJv3JOU1MD/8+0= Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-331-mUPt_NjcPPafLky5GkPxVg-1; Wed, 09 Oct 2019 10:57:26 -0400 Received: by mail-ua1-f71.google.com with SMTP id r39so621657uad.3 for ; Wed, 09 Oct 2019 07:57:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=qb0c2YDv+5pT9nuIaPy4tBmPQgLECS8byCBBtyizFyY=; b=n/j/iAW3ctVQEVoxhUJpwVvCMHst9hkt/rFNK3lcxHUgoGSNSsMcVb+YcWM25Qfejt 1GgroxTDY5hvBZubwJztdX9r6VJS3cciGpGRrpvL5meSOvinDPzVwoQ8RYPFRfpNdP6O oo4y+OdRfJKaT1MkR6y2UuKTZz1UIktqaD4aEUPOEXo4iBUOuLWCEXfQ51oa7gCTiQIs 2tmXHxaaAYw1QzFLhVMGylnFqRzN/CssXC3QKgdQeUlAhkchvhnFgtRSKkUX2gURK7+K 7Di7ikK5tHZI0HAbXEzGRUlWeafszX37h0SHVFLcW5N96Y1olVe4q3IXP37goVkYjHqH l8NA== X-Gm-Message-State: APjAAAWTEx/AdQid4J9A55a+OvN+B28RT1/BYIEjzrP13kIBF/Mns/ya sL49GqmI4s6iOpc0ra206wk1muCeEEb/4V3DsNYiaju4pLdjjR0zLZCkRQO93p0EoLiZy2BSzDF jYCs+P2w8WS9Vu+7g3hc= X-Received: by 2002:a05:6102:115c:: with SMTP id j28mr2178022vsg.105.1570633045691; Wed, 09 Oct 2019 07:57:25 -0700 (PDT) X-Google-Smtp-Source: APXvYqx2RvSB2IAXwID0o3GcQ+AxZ0wbp7Q39u8DagX37kqfnq3t5XnV7i3AbqBaubnnIrvPUp6P3MVjTunX8KA3b5I= X-Received: by 2002:a05:6102:115c:: with SMTP id j28mr2177997vsg.105.1570633045345; Wed, 09 Oct 2019 07:57:25 -0700 (PDT) MIME-Version: 1.0 References: <20191009134709.1007-1-thomas@monjalon.net> In-Reply-To: <20191009134709.1007-1-thomas@monjalon.net> From: David Marchand Date: Wed, 9 Oct 2019 16:57:14 +0200 Message-ID: To: Thomas Monjalon , John McNamara Cc: Marko Kovacevic , dev , Flavia X-MC-Unique: mUPt_NjcPPafLky5GkPxVg-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] doc: fix release notes for removed testpmd commands X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 9, 2019 at 3:47 PM Thomas Monjalon wrote: > > The notes were not visible in the generated doc output because > of an indentation mistake. > While fixing the indentation, the formatting is improved. > > Fixes: e5db17a1e54e ("app/testpmd: remove duplicated Rx offload commands"= ) > Cc: flavia.musatescu@intel.com > > Signed-off-by: Thomas Monjalon > --- > doc/guides/rel_notes/release_19_11.rst | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/doc/guides/rel_notes/release_19_11.rst b/doc/guides/rel_note= s/release_19_11.rst > index be91b04ad9..0062e012ed 100644 > --- a/doc/guides/rel_notes/release_19_11.rst > +++ b/doc/guides/rel_notes/release_19_11.rst > @@ -91,14 +91,17 @@ Removed Items > Also, make sure to start the actual text at the margin. > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D > > - * Removed duplicated set of commands for RX offloading configuration = from app/testpmd: > - =E2=80=9Cport config all crc-strip|scatter|rx-cksum|rx-timestamp|hw= -vlan|hw-vlan-filter| > - hw-vlan-strip|hw-vlan-extend on|off=E2=80=9D. > - > - The testpmd commands set that can be used instead in order to enabl= e or disable Rx > - offloading on all Rx queues of a port is: > - "port config rx_offload crc_strip|scatter|ipv4_cksum|udp_= cksum|tcp_cksum| > - timestamp|vlan_strip|vlan_filter|vlan_extend on|off" > +* Removed duplicated set of commands for Rx offload configuration from t= estpmd:: > + > + port config all crc-strip|scatter|rx-cksum|rx-timestamp| > + hw-vlan|hw-vlan-filter|hw-vlan-strip|hw-vlan-extend = on|off > + > + The testpmd commands set that can be used instead > + in order to enable or disable Rx offloading on all Rx queues of a port= is:: A bit hard to digest: "can be used instead in order to". Might be worth some proofreading, John? > + > + port config rx_offload crc_strip|scatter| > + ipv4_cksum|udp_cksum|tcp_cksum|time= stamp| > + vlan_strip|vlan_filter|vlan_extend = on|off > > > API Changes But at least the generated doc now contains something :-) Reviewed-by: David Marchand -- David Marchand