From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id EBF0C428E3; Fri, 7 Apr 2023 09:19:08 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C54A040E03; Fri, 7 Apr 2023 09:19:08 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 8505140150 for ; Fri, 7 Apr 2023 09:19:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680851947; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=eXuQWkakV4yrP8eKsU+8hdpSeT24uOeb0eXW9jTZJmE=; b=Rf4LDKnrGQtsiJsTP5LpJKTAyY2mkKALqOY7ks6a0hGskc9emOBn/UjxNz3ry8DzJwcF8G tdaD3Gh5PgHUguzZRg5xor1pyX+rWAVyVLMm0LUghSPp4gv2QbuMnlOe6kjvTwl7gOm6Tc m9BnZXmPOWWMIXRBvp48o5ahrjAXTS4= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-387-IkUde2vGP467WRXYfSVn1g-1; Fri, 07 Apr 2023 03:19:05 -0400 X-MC-Unique: IkUde2vGP467WRXYfSVn1g-1 Received: by mail-pj1-f72.google.com with SMTP id 98e67ed59e1d1-244b348230aso96192a91.0 for ; Fri, 07 Apr 2023 00:19:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680851945; x=1683443945; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eXuQWkakV4yrP8eKsU+8hdpSeT24uOeb0eXW9jTZJmE=; b=fL/58b9qFQiN884+52tw+tOJ68E3RlNF/nz5BkMKWUaAH9imnNm7l8CsAb/7bD7H6+ nTrIhNScv3YM8lp6vwAJJ3gEn5R8MZKQvd1SxJXa5/uxQMw+Ghq6P+EHUYwk/y0rA620 3DsIWvT9LsjsLE5tOR1OGqmy3AQidKMXW8Oy3qADsCfsu5P+yzdxdDgS0Tnnhf6O2qCB vGO5maSxnhsI9whetbfg7gj3oHwvuvFsS2s/an9isvnf1QIFHjEk4FxuRkAGjIXZNNfM /2qFG+x9cpEDOaYI8DhTKLzM1MRX/k76u/P0xjiB/XtsULXCzvAin8RCWkMxY9R/7s// rWuQ== X-Gm-Message-State: AAQBX9dnNeBQIbSGOdqdQDOA0aHC6QYCd9kXReDSlFuJw6hp6NqlKCKh Nv0q7peMpvPcPdGUmCvnvuQzn9Y8P6GHF0wVP1GF3I5iQd42YieKRCWasy+HKFiZBXkx6VJhwrP OvaXVTHsDM60t5JEXqpo= X-Received: by 2002:a05:6a00:2ea3:b0:625:ccea:1627 with SMTP id fd35-20020a056a002ea300b00625ccea1627mr820319pfb.5.1680851944818; Fri, 07 Apr 2023 00:19:04 -0700 (PDT) X-Google-Smtp-Source: AKy350aWpaS4pAW0ACZ1JKsiBMthgIkL/pb1xf/3sQTh0MfRlUQcPjIVC/+NZXL28tIrVnojVouosDcswY4pQdP/pCQ= X-Received: by 2002:a05:6a00:2ea3:b0:625:ccea:1627 with SMTP id fd35-20020a056a002ea300b00625ccea1627mr820307pfb.5.1680851944450; Fri, 07 Apr 2023 00:19:04 -0700 (PDT) MIME-Version: 1.0 References: <20230124140746.594066-1-nipun.gupta@amd.com> <20230407060152.16335-1-nipun.gupta@amd.com> In-Reply-To: <20230407060152.16335-1-nipun.gupta@amd.com> From: David Marchand Date: Fri, 7 Apr 2023 09:18:53 +0200 Message-ID: Subject: Re: [PATCH 0/6] add support for CDX bus To: Nipun Gupta Cc: dev@dpdk.org, thomas@monjalon.net, ferruh.yigit@amd.com, harpreet.anand@amd.com, nikhil.agarwal@amd.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Fri, Apr 7, 2023 at 8:02=E2=80=AFAM Nipun Gupta wr= ote: > > Support AMD CDX bus, for FPGA based CDX devices. The CDX > devices are memory mapped on system bus for embedded CPUs. > > It uses sysfs interface and the vfio-cdx driver to discover > and initialize the CDX devices. > > The patches are intended for DPDK 23.07 release, and have been sent > as an RFC as patches are yet to be merged in Linux. > > Linux CDX bus patches has been added into linux next: > https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/= drivers/cdx > > VFIO patches are also submitted in upstream: > https://www.spinics.net/lists/kvm/msg310623.html Hard to tell just from this link what the status is. Has it been reviewed? When are you expecting this to get merged? > > CDX is a Hardware Architecture designed for AMD FPGA devices. It > consists of mechanism for interaction between FPGA, Firmware and > the APUs (Application CPUs). > Firmware resides on RPU (Realtime CPUs) which interacts with > the FPGA program manager and the APUs. The RPU provides memory-mapped > interface (RPU if) which is used to communicate with APUs. > > VFIO CDX driver provides the CDX device resources like MMIO and interrupt= s > to map to user-space. DPDK CDX bus uses sysfs interface and the vfio-cdx > driver to discover and initialize the CDX devices for user-space > applications. > > RFC patches in DPDK were submitted at: > http://patches.dpdk.org/project/dpdk/patch/20230124140746.594066-2-nipun.= gupta@amd.com/ > > Changes RFC->v1: > - Marked few API's as internal which were not required > to be provided to user. Just a quick pass on this series. - There is an issue with the exported header rte_bus_cdx.h. All the bus specific / driver only parts must be moved to a dedicated bus_cdx_driver.h header (which must be listed in driver_sdk_headers). - To whom is the rte_cdx_dump symbol intended to? Is this for use by user applications? If so, the rte_bus_cdx.h can be kept, to export this symbol. But otherwise, everything in rte_bus_cdx.h can be moved to bus_cdx_driver.h= . - Please remove the rte_ prefix for static symbols in *.c. --=20 David Marchand