From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 14D2F42BA9; Fri, 26 May 2023 10:55:10 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E21B740DDA; Fri, 26 May 2023 10:55:09 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 6FD5F40A89 for ; Fri, 26 May 2023 10:55:08 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685091308; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sKwx49G4d3DZXJ0r7JJEmRcZqcL088SHb4zTEZpYEZU=; b=ThhAnEJTIBX/cuFHeMmptgu0qm8UhTkx0mia6zWrLr/dM24AyNiyohqW+nA/ZhJhFx6jr3 4UafXvaQxEz+8DkDQi0McZ6cx42joyh4VzzLtzb6sz/hqPtru1aWLacWh+NDEJ134D4+tM lyRL7OTqzAr3Xw54+QcFPABQyR9dl60= Received: from mail-pj1-f71.google.com (mail-pj1-f71.google.com [209.85.216.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-387-QQLvmL-oMASUVDpVcGATUA-1; Fri, 26 May 2023 04:55:06 -0400 X-MC-Unique: QQLvmL-oMASUVDpVcGATUA-1 Received: by mail-pj1-f71.google.com with SMTP id 98e67ed59e1d1-25624744f6aso436759a91.0 for ; Fri, 26 May 2023 01:55:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685091305; x=1687683305; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=sKwx49G4d3DZXJ0r7JJEmRcZqcL088SHb4zTEZpYEZU=; b=Ah1O9zd3cOuuRFfpjZu96awSHZoGls9yb49pHD2e7ED8lrIkC78qWPs3n/WA671h80 +NoDKOkCGvaHpzFVmpYfC0Wv2MziNd2gWpE9S/UeQR1MvHx9Q2zzYXOHrswOSWVLgH9P hXcBLD3FT3mTbflU/6EA5vvE5z129xK8xKYoQtMc52DVkGXCMTRDJKd/MSa7EkStCxjj BV41cSyM9tJBPg9GGDP5fLEiGWqpqt3EHP2kB3hJThPnz6mqcftU+SMT/gB0ZU2h6m4W g2IouDDFz/q6lGvfBGnY6rdbpFX+KEI4Z5bIi4A6I0zgrPmJpkVY3ZLkCoR54RhB0YX2 JIcw== X-Gm-Message-State: AC+VfDwrrRfhr2cqIA65PP99Drpijkruo4hVtnAaOmdcDqwxecyFM06T gk0Gi/nl5OaoAZfbgoHCX/O1FgxxFjqHdPtlqo6GVBIwNpV+xmpIaLLu5HKrKxYMmH01A5wPVaK M0OAP5MzenS2aE4VxgQk= X-Received: by 2002:a17:90a:cb92:b0:247:14ac:4d3a with SMTP id a18-20020a17090acb9200b0024714ac4d3amr1228635pju.20.1685091305589; Fri, 26 May 2023 01:55:05 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4d9FR5M+IBJmqAdup3i5ePRRTDMIoZtnGOcRfdbJJSWW1Ec+kVH7gV1kof+apfHD49HKD21QqTv2eSGBQbx+8= X-Received: by 2002:a17:90a:cb92:b0:247:14ac:4d3a with SMTP id a18-20020a17090acb9200b0024714ac4d3amr1228617pju.20.1685091305359; Fri, 26 May 2023 01:55:05 -0700 (PDT) MIME-Version: 1.0 References: <20230525162551.70359-1-maxime.coquelin@redhat.com> <20230525162551.70359-15-maxime.coquelin@redhat.com> In-Reply-To: <20230525162551.70359-15-maxime.coquelin@redhat.com> From: David Marchand Date: Fri, 26 May 2023 10:54:54 +0200 Message-ID: Subject: Re: [PATCH v3 14/28] vhost: add helper for interrupt injection To: Maxime Coquelin Cc: dev@dpdk.org, chenbo.xia@intel.com, mkp@redhat.com, fbl@redhat.com, jasowang@redhat.com, cunming.liang@intel.com, xieyongji@bytedance.com, echaudro@redhat.com, eperezma@redhat.com, amorenoz@redhat.com, lulu@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, May 25, 2023 at 6:26=E2=80=AFPM Maxime Coquelin wrote: > @@ -900,6 +905,24 @@ vhost_need_event(uint16_t event_idx, uint16_t new_id= x, uint16_t old) > return (uint16_t)(new_idx - event_idx - 1) < (uint16_t)(new_idx -= old); > } > > +static __rte_always_inline void > +vhost_vring_inject_irq(struct virtio_net *dev, struct vhost_virtqueue *v= q) > +{ > + int ret; > + > + ret =3D dev->backend_ops->inject_irq(dev, vq); > + if (ret) { No need for ret. > + if (dev->flags & VIRTIO_DEV_STATS_ENABLED) > + vq->stats.guest_notifications_error++; > + return; > + } > + > + if (dev->flags & VIRTIO_DEV_STATS_ENABLED) > + vq->stats.guest_notifications++; > + if (dev->notify_ops->guest_notified) > + dev->notify_ops->guest_notified(dev->vid); > +} > + > static __rte_always_inline void > vhost_vring_call_split(struct virtio_net *dev, struct vhost_virtqueue *v= q) > { --=20 David Marchand