From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DC6484594A; Mon, 9 Sep 2024 14:25:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C1DB640E31; Mon, 9 Sep 2024 14:25:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B630A40299 for ; Mon, 9 Sep 2024 14:25:17 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1725884717; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=2usTyEyHR06FQ+2btvHBnTxa1e91E7KOFk7a8vNryQU=; b=K4FTTv4qNgIFicsv9f0eLAwSsSruVlsxjQAPxVHVEs6BQBe8BUrkiUTyRO7aImCEpR+U22 +WXQx39v1nrfoaygvFjLwc7CJdO2l8LIu44lkIbNcnvX4Th59xn/5ICDcfhsUkh/3158O7 dwuQBhty0aybHd5VLbeTIqj4fxmI32g= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-26-v5nSf__WNzCkNXuT_N2f5w-1; Mon, 09 Sep 2024 08:25:16 -0400 X-MC-Unique: v5nSf__WNzCkNXuT_N2f5w-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2f760cbd9deso9910511fa.0 for ; Mon, 09 Sep 2024 05:25:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725884715; x=1726489515; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=2usTyEyHR06FQ+2btvHBnTxa1e91E7KOFk7a8vNryQU=; b=skNHRWGNUY0M7uq07eobdIPiqxMzP/RG7cDfVVPDpBfQ0YZf3tHYANSXasY+G+U9LA h7zckyorLXCORqsQrCXj2IwfIbdlR7Vr80Auha3IOEAnJNCVil+FJ/aPKqKpRdnLmY75 raCZdNWcT4yGnm1AYE2XJ+FnDv4vJdaaLLb4KjmA10iq8J2jm9ujic2MtrUDU1jKx5bA D3omHBxiCGuyz4K6aBR7fU//sE+l4dAzXiZI0Ml62qvTqsOMjURTAp20rcO8UfwQOVER MOoXvQK582cNbJJn6W6/mvwZUXizHloF798yCySoKw4/DNMcLbjll7OTxpViQsNC6ae9 9ZJg== X-Forwarded-Encrypted: i=1; AJvYcCUwP5jBOu/MoQGqRTsujV+52XfLLq2GLJs2YZCC819RCq53Z7AiWv762sbKR14XYXBkt68=@dpdk.org X-Gm-Message-State: AOJu0YywNN2I9ma+GYDTXz+OpHAUn0N2AgDNCpTURgbMsbIm1xL9183w Z6lA0j1bEdRiCeUQp/5+yK7E/HhMRLuVXTWoqNDHMtRi9VtgCASMZuFr7UwrKLU3oCnPH4JrQ5a uQbkDqMNxTXXcTji8EkgJIISthC2o2ygztW0uzMi9whpcqxNUB+PFa00s1ZFOeO8XbfD1BkebNk zgvANBVrIATyQ4JsE= X-Received: by 2002:a2e:819:0:b0:2f7:4c9d:7a87 with SMTP id 38308e7fff4ca-2f75232641cmr54189351fa.21.1725884714652; Mon, 09 Sep 2024 05:25:14 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFqYQis8Eix6zAtUSi1Oq2fDYagdbxWrvZ2p9CCZVYJXFF4aQtqHEte0vDzB8Ai99Qzq3QNy3IYv4qMjqN/XPo= X-Received: by 2002:a2e:819:0:b0:2f7:4c9d:7a87 with SMTP id 38308e7fff4ca-2f75232641cmr54189191fa.21.1725884714105; Mon, 09 Sep 2024 05:25:14 -0700 (PDT) MIME-Version: 1.0 References: <20240809095829.589396-2-mattias.ronnblom@ericsson.com> <20240812124930.604796-1-mattias.ronnblom@ericsson.com> <6f228b70-8b85-4a91-965d-2b99658c668e@lysator.liu.se> In-Reply-To: <6f228b70-8b85-4a91-965d-2b99658c668e@lysator.liu.se> From: David Marchand Date: Mon, 9 Sep 2024 14:25:02 +0200 Message-ID: Subject: Re: [PATCH v3 0/5] Improve EAL bit operations API To: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: Tyler Retzlaff , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , dev@dpdk.org, Heng Wang , Stephen Hemminger , =?UTF-8?Q?Morten_Br=C3=B8rup?= , Jack Bond-Preston , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Sep 9, 2024 at 2:05=E2=80=AFPM Mattias R=C3=B6nnblom wrote: > > Mattias, there are issues reported by the CI (compilation on Ubuntu > > 22.04 in GHA, and unit test failure in UNH), please have a look. > > > > > > Standard practice in DPDK header files is the following: > > -- > /* rte_bar.h */ > #ifdef __cplusplus > extern "C" { > #endif > > #include > > void > rte_foo_do(void); > > /../ > -- > > That seems not like best practice to me, since rte_bar.h is messing > around with linkage of constructs of any files included. In particular, > it prohibits replacing _Generic with C++ function overloading, in C++ TUs= . > > What one should do is to have extern "C" linkage only on functions which > the include file in question (e.g., rte_foo.h) itself declares. This is probably not the best practice, but since you intend to fix it, it will be perfect afterwards :-). > > -- > /* rte_bar.h */ > #include > > #ifdef __cplusplus > extern "C" { > #endif > > void > rte_foo_do(void); > > /../ > -- > > There are 259 header files in the DPDK repo in need of fixing. > > Should the fix be 259 patches, or something smaller? One large patch, or > a patch per library, or something else. Please advise, over. The change seems mechanical, so one single change is ok. --=20 David Marchand