From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0F4342671; Fri, 29 Sep 2023 11:34:21 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C31EB402B1; Fri, 29 Sep 2023 11:34:21 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id E735C40287 for ; Fri, 29 Sep 2023 11:34:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695980059; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/OpA2xljK/bsf1AU1qmBPAIUco6jixI2FdPgq2Fr1eo=; b=gLXWE9uBtPf9b2TdW3Img0S90QPQHpHqMNwv2zS9zNW9Nntt/oUxHTHKE8zGjeu+FWpaXz k/x1MlFjvaXehko3FXeytZfASnhOjRnRIDIsDY67lkCmv7K8FQkSm8Qi5EpP1abgZjmo9N hV0DM635X+pF10mhg+5t+s1hhPgOh98= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-208-ZY3kUdVSNqulHmYFm4Xw2g-1; Fri, 29 Sep 2023 05:34:17 -0400 X-MC-Unique: ZY3kUdVSNqulHmYFm4Xw2g-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2b710c5677eso207856891fa.0 for ; Fri, 29 Sep 2023 02:34:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695980056; x=1696584856; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/OpA2xljK/bsf1AU1qmBPAIUco6jixI2FdPgq2Fr1eo=; b=uexUvhHMWg9UeBQrPIJCbSgz75cOaMfNhSpb/YlPnh322r/9jkhi5h7wMNRou0wJk6 hM5xOzEisFDEyyQumbWmvkh6zHADH8whRSzO4YoFeBv1rz3G3IiCgFQUD9YT9pJRNdh8 RxtnZ41SgU/OLzUJ9KsonvmKU6hw+im28LdONNC0D8A29dk9Mpb4TfBkkBpaxeAhAsB2 ujsZYgaFPclpzx1ZPZtUSgumR6e67HokWZTMPXLsdhKRlV+NGkcZbyjIjTJ0Wy2MBN28 i2g9gK71uX1GL7nC/ScmjQtygy0qbZVTIYzw5Fcz9O8FYjsvERo7qe8gHyS4umqVbCo0 t/dg== X-Gm-Message-State: AOJu0YzCskqK9gZ+G9booMz+TY3uBHF/6MjeR9KpnmarjaPvUYI4rm4d Ry94ji/enwViplwa6qXb8v1Fqq1rDIyg50ZNstCpg3O2AHYx4Z3xhjQ2ZivxXJI+3PQJkW1hGlk 0uBpYnfUTzyh8j2196pc= X-Received: by 2002:a2e:804c:0:b0:2bb:bfa5:b72c with SMTP id p12-20020a2e804c000000b002bbbfa5b72cmr3304067ljg.15.1695980056365; Fri, 29 Sep 2023 02:34:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGWoXHPmUQJ+DWxT4fMIhbrlVXNY9nysnq+Jp5a1IzHo8rSAO8G3TdpWvQwzwZQnn9AdOceGfFLdnZriya71wk= X-Received: by 2002:a2e:804c:0:b0:2bb:bfa5:b72c with SMTP id p12-20020a2e804c000000b002bbbfa5b72cmr3304047ljg.15.1695980056070; Fri, 29 Sep 2023 02:34:16 -0700 (PDT) MIME-Version: 1.0 References: <1691717521-1025-1-git-send-email-roretzla@linux.microsoft.com> <1692738045-32363-1-git-send-email-roretzla@linux.microsoft.com> <1692738045-32363-2-git-send-email-roretzla@linux.microsoft.com> <5908573.LM0AJKV5NW@thomas> <98CBD80474FA8B44BF855DF32C47DC35D87C1F@smartserver.smartshare.dk> In-Reply-To: From: David Marchand Date: Fri, 29 Sep 2023 11:34:04 +0200 Message-ID: Subject: Re: [PATCH v6 1/6] eal: provide rte stdatomics optional atomics API To: Bruce Richardson Cc: =?UTF-8?Q?Morten_Br=C3=B8rup?= , Thomas Monjalon , Tyler Retzlaff , dev@dpdk.org, techboard@dpdk.org, Honnappa Nagarahalli , Ruifeng Wang , Jerin Jacob , Sunil Kumar Kori , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= , Joyce Kong , David Christensen , Konstantin Ananyev , David Hunt X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Sep 29, 2023 at 11:26=E2=80=AFAM Bruce Richardson wrote: > > On Fri, Sep 29, 2023 at 11:02:38AM +0200, David Marchand wrote: > > On Fri, Sep 29, 2023 at 10:54=E2=80=AFAM Morten Br=C3=B8rup wrote: > > > In my opinion, our move to C11 thus makes RTE_BUILD_BUG_ON obsolete. > > > > That's my thought too. > > > > > > > > We should mark RTE_BUILD_BUG_ON as deprecated, and disallow RTE_BUILD= _BUG_ON in new code. Perhaps checkpatches could catch this? > > > > For a clear deprecation of a part of DPDK API, I don't see a need to > > add something in checkpatch. > > Putting a RTE_DEPRECATED in RTE_BUILD_BUG_ON directly triggers a build > > warning (caught by CI since we run with Werror). > > > > Would it not be sufficient to just make it an alias for the C11 static > assertions? It's not like its a lot of code to maintain, and if app users > have it in their code I'm not sure we get massive benefit from forcing th= em > to edit their code. I'd rather see it kept as a one-line macro purely fro= m > a backward compatibility viewpoint. We can replace internal usages, thoug= h > - which can be checked by checkpatch. No, there is no massive benefit, just trying to reduce our ever growing API surface. Note, this macro should have been kept internal but it was introduced at a time such matter was not considered... --=20 David Marchand