From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B360A32A2 for ; Thu, 24 Oct 2019 14:56:40 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 57F381EA4D; Thu, 24 Oct 2019 14:56:40 +0200 (CEST) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 60E481EA4D for ; Thu, 24 Oct 2019 14:56:39 +0200 (CEST) Received: from mail-vk1-f199.google.com (mail-vk1-f199.google.com [209.85.221.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7039266C5B for ; Thu, 24 Oct 2019 12:56:38 +0000 (UTC) Received: by mail-vk1-f199.google.com with SMTP id u64so10639876vke.18 for ; Thu, 24 Oct 2019 05:56:38 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kgjFFmW9dnsS64yAoWeRyyGE2wE62f7Pm3ns58VxHeA=; b=BHqdjKCENnuLet9HToD858F1ngH36aiN3LU+Ix9PET5Sa1R4vUaAEaFCtJ54+YdRru +8LxlwnwaT6hPUHgCdXGG7fkMdEvuk6k1R1YcjRY7kIrVlSfq66kKNr/R/ywy2XEYhcw PSMpcjIy0gYAgcx2RXOgBcryA3QXDUkvjgzY673K6gOM/UeQbtKIihjWUnA5f4pUqUzs O635w7JHen/CtYmoEdjix6l2wwislKxDFFFXaoy2iA0R3kebVc/agWEdQ79waqZUwDSj 5RSRXkVTplju/F3UL3q+9gfONkypRAKtSDnEKMze5P6PvR97/ddshSljYaLzahUxO1HU n6tQ== X-Gm-Message-State: APjAAAUWma1DZ15V5ny0qyqwQLvH8HOF+uVCLWm9hlOxNWY8mVN+oYPr 4wnM54mfs8wH5RFKVOeR9Xx8spV62f3Ra6gXuKArJ51erxGe+TOFy7WJLz5E1yXtlLLtC5xP85V kWCb99kfNDmj9v/Wi3J8= X-Received: by 2002:a67:7d95:: with SMTP id y143mr1877499vsc.39.1571921797627; Thu, 24 Oct 2019 05:56:37 -0700 (PDT) X-Google-Smtp-Source: APXvYqx8saTSAt5rqg1Yw+PqcQdD6DdCjYjP/wFwfeZVmrzaNJzoS2SIf5Mr1m8waDxzp8sYnKj0zNPkIjhAi0JxbcI= X-Received: by 2002:a67:7d95:: with SMTP id y143mr1877482vsc.39.1571921797323; Thu, 24 Oct 2019 05:56:37 -0700 (PDT) MIME-Version: 1.0 References: <1571772857-18287-1-git-send-email-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 24 Oct 2019 14:56:26 +0200 Message-ID: To: David Marchand Cc: dev , Bruce Richardson , dpdk stable , Thomas Monjalon , "Burakov, Anatoly" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: remove dead code on NUMA node detection X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 23, 2019 at 7:49 PM Burakov, Anatoly wrote: > > On 22-Oct-19 8:34 PM, David Marchand wrote: > > RTE_EAL_ALLOW_INV_SOCKET_ID had been introduced and documented as used > > with xen dom0 support (dropped for some time now). > > > > Closely looking at this, the code was changed later and ensures that the > > socket id is in the [0..RTE_MAX_NUMA_NODES] range anyway. > > > > Let's drop this dead code and the build option with it. > > > > Fixes: 94ef2964148a ("eal/linux: fix numa node detection") > > Cc: stable@dpdk.org > > > > Signed-off-by: David Marchand > > --- > Acked-by: Stephen Hemminger > > Acked-by: Anatoly Burakov Applied. -- David Marchand