From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 463C24610D; Wed, 29 Jan 2025 14:26:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 10A3C402CC; Wed, 29 Jan 2025 14:26:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 3D3C7402AE for ; Wed, 29 Jan 2025 14:26:21 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1738157180; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=K4L64A63t9koftFCHfCe1kWWStNcwfOEf0PYCmwljEg=; b=LBt52xJtVZU8QHQUg3lA48JECEfSt9YzhFHAJ57oqhoytcGkrmbsQaaCx2aBxSUGbaQsFb Aut7snwzAYQvfYTaREImGWxzpBNSDRtf9YOipBjYtUT9F0kIAjgwQl+J9PsUoUFHfnJBJF Oi8sgo9IUYzIK50SMLwo5DYrpyatE40= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-fuetfERnOwmld-uFHvaoUw-1; Wed, 29 Jan 2025 08:26:19 -0500 X-MC-Unique: fuetfERnOwmld-uFHvaoUw-1 X-Mimecast-MFC-AGG-ID: fuetfERnOwmld-uFHvaoUw Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-53e1ee761d7so3375198e87.1 for ; Wed, 29 Jan 2025 05:26:19 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738157178; x=1738761978; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=K4L64A63t9koftFCHfCe1kWWStNcwfOEf0PYCmwljEg=; b=v13Tm3l7Xz696MsWo0tA2y9iLvSKRooLF9mcwL+yJPaZBzrg8MzZT5j0KWvKrmFRf4 5Aa8dobGiJ55VbPfgm0ur6nopm0Nis7pLGrrNZ8PIdTuT9u78sMm14qJ91g8mgDCESko kQXIsiIgpvv5vO1T1RtAZO9BkPZ//QxC5R6L4sti4J2Qq0RDv4jPe4Q8qgBUz/AXBSNx 7mNHRP/KuC5oK5jyVqba2vvxxWB288bCusyIGxCRhIGmrrDGI+fbH41KSUdKun5JtDOt o5MLy9mYJ2pvzhtpCYUlRe5sUzLHLhz4e4xBBn9ZqLnWVytis6SbHI9bQ2ka0GvOP3eK KYGQ== X-Gm-Message-State: AOJu0YzNL6mKw64+6G6e1Pj+kCXNtTgb6H7F4Ogp31kYta4MISsYI30j Enlqt+YJe1aaCecjp4bO0vHcx+K4PmbzW4hy6XYQCuXPnILy4fxXmERTov+Z9e3QS1AaJiT1KsK Cevwl6d/TloLBsY+bu+dVQQdBkntO/w4rWrGRUE0Pd/ZhA8r/KLPqfjC1hR98COHQckgIKf5Etl cTRuxDzKzXiEfu/UU= X-Gm-Gg: ASbGncvRPVYi9YEprY+3WP9Gm8j/X8jmmSH6nx6ZUEnhvkQFNiLpQbE/BGgF8oz8saB VY81qFJW6Hzi5e+ASjHty+hK2P0Q+A9DGW2QizZGqWsdi/lFXCv1hUbrdjS5L/UgJ X-Received: by 2002:ac2:4e08:0:b0:542:2402:4dd2 with SMTP id 2adb3069b0e04-543e4bdea5amr974501e87.10.1738157177929; Wed, 29 Jan 2025 05:26:17 -0800 (PST) X-Google-Smtp-Source: AGHT+IHKeqjzN/ZlKk9/sbpOAf8Jf22FiZxJjbDfFX8aj4XBYtrUVtGbiA170tu6B4p+5WMCPzC/1QDqDduZfv27LcU= X-Received: by 2002:ac2:4e08:0:b0:542:2402:4dd2 with SMTP id 2adb3069b0e04-543e4bdea5amr974489e87.10.1738157177509; Wed, 29 Jan 2025 05:26:17 -0800 (PST) MIME-Version: 1.0 References: <1735263196-2809-1-git-send-email-andremue@linux.microsoft.com> <1737498970-4631-1-git-send-email-andremue@linux.microsoft.com> In-Reply-To: <1737498970-4631-1-git-send-email-andremue@linux.microsoft.com> From: David Marchand Date: Wed, 29 Jan 2025 14:26:06 +0100 X-Gm-Features: AWEUYZk5k0lsGRnySxZyNHr-VSlFbUSoe8ImiYjRpSLfBWCKeMf-nDbOJXDL6Tc Message-ID: Subject: Re: [PATCH v16 0/3] add diagnostics macros to make code portable To: Andre Muezerie Cc: dev@dpdk.org, stephen@networkplumber.org, bruce.richardson@intel.com, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6Mk9jUGoOiOWNhu2GLFT5gQSb0GKbmG2Ugy60h4LhtU_1738157178 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Jan 21, 2025 at 11:36=E2=80=AFPM Andre Muezerie wrote: > > v16: > * Updated comment for RTE_CAST_PTR. > > v15: > * Fixed a comment in rte_common.h to make Doxygen happy. > * Fixed a typo (extra comma). > * Added missing RTE_PTR_UNQUAL needed for ARM64. > > v14: > * Renamed RTE_PTR_DROP_QUALIFIERS into RTE_PTR_UNQUAL to more resemble > C23 typeof_unqual. > * Added macro RTE_CAST_PTR to make the cast more readable when removing > a type qualifier from a pointer. > > v13: > * Renamed RTE_IGNORE_CAST_QUAL into RTE_PTR_DROP_QUALIFIERS. > * Added (void *) cast to RTE_PTR_DROP_QUALIFIERS to avoid the need > for casting the result in most places where the macro is used. > > v12: > * Added macro RTE_IGNORE_CAST_QUAL and used it as a more compact and > readable form to suppress warnings where a cast is used to remove > a type qualifier. > > v11: > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > it was needed. > > v10: > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > it was needed. > > v9: > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > it was needed. > > v8: > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > it was needed. > > v7: > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > it was needed. > > v6: > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > it was needed. > > v5: > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > it was needed. > > v4: > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > it was needed. > > v3: > * Added __rte_diagnostic_ignored_wcast_qual to a few more places where > it was needed. > > v2: > * Removed __rte_diagnostic_ignored_wstrict_aliasing (introduced > in v1). > * Removed the pragmas from many files where they were not needed. > * In the files where the pragmas were indeed needed, reduced the > scope during which they are active, reducing the chance that > unforeseen issues are hidden due to warning suppression. > > Andre Muezerie (3): > eal: add diagnostics macros to make code portable > drivers/common: add diagnostics macros to make code portable > drivers/net: add diagnostics macros to make code portable I moved a bit the casting macros in rte_common.h (and put them next to RTE_CAST_FIELD). Thanks for this work Andr=C3=A9, series applied. Note: there is probably some cleaning to do in the rest of the tree: $ git grep -l '(void \*)(uintptr_t)' | wc -l 92 --=20 David Marchand