Re: [dpdk-dev] [PATCH v14 01/23] event/dlb: add documentation and meson infrastructure

[David Marchand <david.marchand@redhat.com>]

On Sat, Oct 31, 2020 at 7:16 PM Timothy McDaniel
<timothy.mcdaniel@intel.com> wrote:
>
> Note that config/rte_config.h contains several configuration
> switches, providing for fine control of the PMD's
> runtime behaviour.
>
> The meson infrastructure is expanded as additional files are
> added to this patchset.
>
> Adds announcement of availabililty of the new driver

availability*

> for Intel Dynamic Load Balancer 1.0 hardware.
>
> Signed-off-by: Timothy McDaniel <timothy.mcdaniel@intel.com>
> ---
>  MAINTAINERS                            |  6 +++++-
>  config/rte_config.h                    |  6 ++++++
>  doc/guides/eventdevs/dlb.rst           | 36 ++++++++++++++++++++++++++++++++++
>  doc/guides/eventdevs/index.rst         |  1 +
>  doc/guides/rel_notes/release_20_11.rst |  5 +++++
>  drivers/event/dlb/meson.build          | 13 ++++++++++++
>  drivers/event/dlb/version.map          |  3 +++
>  drivers/event/meson.build              |  2 +-
>  8 files changed, 70 insertions(+), 2 deletions(-)
>  create mode 100644 doc/guides/eventdevs/dlb.rst
>  create mode 100644 drivers/event/dlb/meson.build
>  create mode 100644 drivers/event/dlb/version.map
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index a3d1927..b904132 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -1162,6 +1162,11 @@ Cavium OCTEON TX timvf
>  M: Pavan Nikhilesh <pbhagavatula@marvell.com>
>  F: drivers/event/octeontx/timvf_*
>
> +Intel DLB
> +M: Timothy McDaniel <timothy.mcdaniel@intel.com>
> +F: drivers/event/dlb/
> +F: doc/guides/eventdevs/dlb.rst
> +
>  Marvell OCTEON TX2
>  M: Pavan Nikhilesh <pbhagavatula@marvell.com>
>  M: Jerin Jacob <jerinj@marvell.com>
> @@ -1198,7 +1203,6 @@ M: Peter Mccarthy <peter.mccarthy@intel.com>
>  F: drivers/event/opdl/
>  F: doc/guides/eventdevs/opdl.rst
>
> -

Please leave this empty line.


>  Rawdev Drivers
>  --------------
>
> diff --git a/doc/guides/rel_notes/release_20_11.rst b/doc/guides/rel_notes/release_20_11.rst
> index d8ac359..0a95bf0 100644
> --- a/doc/guides/rel_notes/release_20_11.rst
> +++ b/doc/guides/rel_notes/release_20_11.rst
> @@ -55,6 +55,11 @@ New Features
>       Also, make sure to start the actual text at the margin.
>       =======================================================
>
> +* **Added a new driver for the Intel Dynamic Load Balancer v1.0 device.**
> +
> +  Added the new ``dlb`` eventdev driver for the Intel DLB V1.0 device. See the
> +  :doc:`../eventdevs/dlb` eventdev guide for more details on this new driver.
> +
>  * **Added write combining store APIs.**
>

eventdev drivers go after net drivers.


>    Added ``rte_write32_wc`` and ``rte_write32_wc_relaxed`` APIs
> diff --git a/drivers/event/dlb/meson.build b/drivers/event/dlb/meson.build
> new file mode 100644
> index 0000000..5324043
> --- /dev/null
> +++ b/drivers/event/dlb/meson.build
> @@ -0,0 +1,13 @@
> +# SPDX-License-Identifier: BSD-3-Clause
> +# Copyright(c) 2019-2020 Intel Corporation
> +
> +if not is_linux or not dpdk_conf.has('RTE_ARCH_X86_64')
> +        build = false
> +        reason = 'only supported on ARCH_X86_64 Linux'
> +        subdir_done()
> +endif
> +
> +sources = files(
> +)

If you go with empty list, you can also start with headers = files()
(rather than install_headers, see later comment).

> +
> +deps += ['mbuf', 'mempool', 'ring', 'pci', 'bus_pci']

Odd to see dependencies with nothing to build.



-- 
David Marchand