From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8D5AEA00C5; Wed, 16 Feb 2022 11:01:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2F3A1410FF; Wed, 16 Feb 2022 11:01:27 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id B2F57410FB for ; Wed, 16 Feb 2022 11:01:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1645005685; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=IoMXRmGtKLhLHoqYACkfPxALL8WUvdAbIkXVs7PVh3s=; b=XbnJN1DMWfuyCY85JxbVC2xvMxisS9PefCDQDT6MQpc0YHfqA3PbhOyGRVuoSHjJJ6MyKl HqHfOdoiXnGqwfDx+7gFJb1Ws/zdzY7sJ4nYPPTqonB7DK6XcyHj7CL+7ARLmkwlZOIldp 2MjLAx5/G+8pAuVDkeyT1c63HNVhIWY= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-596-bNDhhIb0ObK1Tjnu8GDDPg-1; Wed, 16 Feb 2022 05:01:22 -0500 X-MC-Unique: bNDhhIb0ObK1Tjnu8GDDPg-1 Received: by mail-lj1-f200.google.com with SMTP id b35-20020a2ebc23000000b002447143a325so735578ljf.11 for ; Wed, 16 Feb 2022 02:01:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=IoMXRmGtKLhLHoqYACkfPxALL8WUvdAbIkXVs7PVh3s=; b=WcSu/cX34QoHH9HLxAq0pKyDYIKsyosZOF0XoaKHP6bITw7lL1cISQ6bXn65GanhSJ 6NQrCFqlwpKdm11mmeGlDXeKk1pDBBlVfCHio83sFLtgPiMRhZABVnXsl0nLpeQHkYET dkokq6wftm941TkdVUdch3sXAZUSOd2pnjfGLjAP8xWUxsHJPWN2fEZkk9ZAIqPEhHr7 yxf/hiCclpslYPDqOSJ6SYyT1UloiTNt6aiOurHg6WBlbIS5/kes7NPd21TrWcA27vPj 3yih0DUtCmI+WbTMoYZxM06FIbh8JXRfJhtFDgYcgNoaDhLTASlVSDtNz7jyUZKucs65 1uhQ== X-Gm-Message-State: AOAM533oPVubJaoW3eNN0xb+Hmga9g9dICqkI5q4KBaRvJXatioIai52 uv5330LnsMdAgTK8mXUMoVQahHjhMiEJ5JtD1nQvS6fhOzpnRKGUmzEH9FtNKCYkplVxZqgXua5 BZksTI5DIMjwpPr5P6HY= X-Received: by 2002:a2e:a171:0:b0:244:c2fc:d1d with SMTP id u17-20020a2ea171000000b00244c2fc0d1dmr1419436ljl.159.1645005680760; Wed, 16 Feb 2022 02:01:20 -0800 (PST) X-Google-Smtp-Source: ABdhPJxXyjbimBwY7Uz8OIKSFIWUhL+TGzgAbA7R1AtE6ebMk3zTvSVWBHkMKuwOEAGV8Gnloo2H/jPs7wLlw8wG9A0= X-Received: by 2002:a2e:a171:0:b0:244:c2fc:d1d with SMTP id u17-20020a2ea171000000b00244c2fc0d1dmr1419417ljl.159.1645005680560; Wed, 16 Feb 2022 02:01:20 -0800 (PST) MIME-Version: 1.0 References: <20220211065315.66814-1-wenxuanx.wu@intel.com> In-Reply-To: From: David Marchand Date: Wed, 16 Feb 2022 11:01:09 +0100 Message-ID: Subject: Re: [PATCH] eal/linux: fix fail to stop device monitor error To: Long Li Cc: "wenxuanx.wu@intel.com" , "qiming.yang@intel.com" , "qi.z.zhang@intel.com" , "nhorman@tuxdriver.com" , "dev@dpdk.org" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Feb 16, 2022 at 9:10 AM Long Li wrote: > > > Subject: [PATCH] eal/linux: fix fail to stop device monitor error > > > > [You don't often get email from wenxuanx.wu@intel.com. Learn why this is > > important at http://aka.ms/LearnAboutSenderIdentification.] > > > > From: Wenxuan Wu > > > > The ret value stands for whether the device monitor has been successfully > > closed, and has nothing to do with rte_intr_callback_unregister funcs once it > > return a value greater than 0 .So if the closure procedure has gone to the > > right exit point ,we should set this value to 0. > > It seems to be a display problem with the patch in this email. There is no issue with displaying. The proposed patch can be found in patchwork under: https://patchwork.dpdk.org/project/dpdk/patch/20220211065315.66814-1-wenxuanx.wu@intel.com/ > > But the patch at https://patchwork.dpdk.org/project/dpdk/patch/20220211084131.72606-1-wenxuanx.wu@intel.com/ looks good to me. The patch you reference is in another mail thread you can find from patchwork (see "mailing list archive" link in patch): https://inbox.dpdk.org/dev/20220211084131.72606-1-wenxuanx.wu@intel.com/ -- David Marchand