From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9629CA0542; Wed, 5 Oct 2022 18:57:16 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4071740E2D; Wed, 5 Oct 2022 18:57:16 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E4F7D40694 for ; Wed, 5 Oct 2022 18:57:14 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664989034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hcGatwGwueFwRXxZpyFvkHoKb+ylwx8yEZDckyXeNfg=; b=Jb8ycYEsI+ahV38pATbiwIZYAtkBEELCjRJ3Z55sIl9Q1Cornl1D/KOhioz+67GM6GD1WJ ARFFuPiWQFCGGuArn6ZQpY5DO3GsNtdPqnBMDoYghYFt9js9ZraIPPUXqpNg0Y/MgtrrRV Q7zOz1bgIZI8dpGgLb1ekT5bzfz6OOA= Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-539-Ce-tX8UaMPW3-EHWgzF6KA-1; Wed, 05 Oct 2022 12:57:13 -0400 X-MC-Unique: Ce-tX8UaMPW3-EHWgzF6KA-1 Received: by mail-pg1-f199.google.com with SMTP id b11-20020a630c0b000000b0044c0bb18323so6436110pgl.17 for ; Wed, 05 Oct 2022 09:57:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date; bh=hcGatwGwueFwRXxZpyFvkHoKb+ylwx8yEZDckyXeNfg=; b=szylzeOAUOdVtYBjQqi4SHgdYrJkblijoBvynkZvGyFhyUzDV7LjbFk8+6HggMQTet yIc1JpHPNs853v9DERfBHs/iZPgQ3BtU5AxWpM3G4e/OgBXHlanSsgZbQ3z0B6lQ+u8o Em1M8O2tCI7+vm0Yert0OuMZ+8XM0lipqefbFUadT7MIbzeTz35MPJgxPVcwQHZLGzvQ kJkB/pnueIkQXjfJyShWSfCmzgDl5q1j8OqREmBh13bzW5g67LhJVbHpx/Ht+F/gRHs5 PniyfCDpwhRtBNmnyo+gymQ/hPRYkrmDMltAas+/+VvaVHXnwkBngD1HIOsTe8XU07Ze 0oDw== X-Gm-Message-State: ACrzQf01bK0jLJH7WRtrFrKsHq7sqHLLnTTdOS5pakGfAAb3PJ8wYUb3 k7RM8wVtycmogi6dA7HObWpzqzuY44drW3VYND5Q6o21IBymgKCcz/Y6ZkN+tnrNluaw6GuveKV qQLOJELs+h60gwxAYB54= X-Received: by 2002:a17:90b:1c8e:b0:205:783b:fe32 with SMTP id oo14-20020a17090b1c8e00b00205783bfe32mr6120755pjb.39.1664989032033; Wed, 05 Oct 2022 09:57:12 -0700 (PDT) X-Google-Smtp-Source: AMsMyM45R8KBblXAJ2zK7Y9Pvj8pvvtAwWAs4ETPvwee6V4xmx6QFkdVLAgF1wDhDiahyplev2GYF+7aMCXiA2T9Y7E= X-Received: by 2002:a17:90b:1c8e:b0:205:783b:fe32 with SMTP id oo14-20020a17090b1c8e00b00205783bfe32mr6120736pjb.39.1664989031745; Wed, 05 Oct 2022 09:57:11 -0700 (PDT) MIME-Version: 1.0 References: <20221005152347.330954-1-ktraynor@redhat.com> In-Reply-To: <20221005152347.330954-1-ktraynor@redhat.com> From: David Marchand Date: Wed, 5 Oct 2022 18:57:00 +0200 Message-ID: Subject: Re: [PATCH] examples/l2fwd-cat: fix build To: Kevin Traynor Cc: dev@dpdk.org, Tomasz Kantecki , Bruce Richardson , Dmitry Kozlyuk X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 5, 2022 at 5:24 PM Kevin Traynor wrote: > > and need to be included for the build > since they were removed from . > > ../examples/l2fwd-cat/cat.c: In function =E2=80=98parse_set=E2=80=99: > ../examples/l2fwd-cat/cat.c:66:16: > warning: implicit declaration of function =E2=80=98isblank=E2=80=99 > [-Wimplicit-function-declaration] > 66 | while (isblank(*str)) > | ^~~~~~~ > ../examples/l2fwd-cat/cat.c:18:1: > note: include =E2=80=98=E2=80=99 or provide a declaration of =E2= =80=98isblank=E2=80=99 > 17 | #include "cat.h" > +++ |+#include > 18 | > ../examples/l2fwd-cat/cat.c:70:15: > warning: implicit declaration of function =E2=80=98isdigit=E2=80=99 > [-Wimplicit-function-declaration] > 70 | if ((!isdigit(*str) && *str !=3D '(') || *str =3D=3D '\0'= ) > | ^~~~~~~ > ../examples/l2fwd-cat/cat.c:70:15: > note: include =E2=80=98=E2=80=99 or provide a declaration of =E2= =80=98isdigit=E2=80=99 > ../examples/l2fwd-cat/cat.c:75:17: > error: =E2=80=98errno=E2=80=99 undeclared (first use in this function) > 75 | errno =3D 0; > | ^~~~~ > ../examples/l2fwd-cat/cat.c:18:1: > note: =E2=80=98errno=E2=80=99 is defined in header =E2=80=98=E2= =80=99; > did you forget to =E2=80=98#include =E2=80=99? > 17 | #include "cat.h" > +++ |+#include > > Fixes: 72b452c5f259 ("eal: remove unneeded includes from a public header"= ) > > Signed-off-by: Kevin Traynor > --- > examples/l2fwd-cat/cat.c | 2 ++ > 1 file changed, 2 insertions(+) There is another issue, caught when building this example out of the meson build process (can be caught with DPDK_BUILD_TEST_EXAMPLES=3Dl2fwd-cat devtools/test-meson-builds.sh). Not urgent, can you look at it? (I added a rte_common.h inclusion in cat.h as a workaround, there may be a bettter fix to do). We could also enhance build coverage in GHA, since the intel-cmt-cat/intel-cmd-cat-devel packages are available for Ubuntu/Fedora distribs. --=20 David Marchand