From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 486C043A39; Thu, 1 Feb 2024 12:57:37 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C698040299; Thu, 1 Feb 2024 12:57:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id AE5424021D for ; Thu, 1 Feb 2024 12:57:35 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706788655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xk4SEZC+W3LYOx/iVmqRnQVsf/t/1xUfiH+HjH+HM/Y=; b=Ag6Q2Ay9TfO1fQZZzQbf2tBqXv1Pm8zhNF27EJ5xVswrpgVTOMwQn9aLAGkLNfVSajuLXl jD5NxuqCUY/v/9Q8fQlfe2m9Mj8+kXzk6QSkII5pHA9sRBJtuBX8DSZ2TtAucduL/x8NWQ tyb2JvQ09WkqVFb4C+yzcCFkoIgbnHE= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-341-4HFtPKiMOaeXebM8SWyT-Q-1; Thu, 01 Feb 2024 06:57:33 -0500 X-MC-Unique: 4HFtPKiMOaeXebM8SWyT-Q-1 Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-2cf37b157f5so8448631fa.0 for ; Thu, 01 Feb 2024 03:57:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706788652; x=1707393452; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xk4SEZC+W3LYOx/iVmqRnQVsf/t/1xUfiH+HjH+HM/Y=; b=i3OtGHHm+CD1d0tloA7x8n0lhYACTX8tnqDmrleA8Y4ym/9MUz7ykh4F6yZyIP0U/U wu1Ib3uCZuO++o8msrmTPZpBjF7J0rwaiHdhKnZr3QR5mOYiiIraUqCBZ01g0i2ptIm6 zbNd/57fms4Ps4ufJ3CAz4izCl+2r6c6nF1QncNS5vaZRLl0cchvC8JpQ4vAgFIIFuzl rOkPjuTOSql6qqvKJqNBJ4bAa9M5B92bCaCqNn2cQG4wAsmFY7CDVzegfRjWIf5kMxda R5+PzVHK+rXy1FehQFmGIQQDC7h5ms+2tFqtdGyyl1aMNGvYIo/+C7Rqq9Zk7Ba1JxJW Ykmw== X-Gm-Message-State: AOJu0Yz6YoadcPnnEAaXIS0usgDIStGnEOPgg+ps3Hp+wSleyJzdU2jG GvaFjtwU1OiSn4FyvL43s7KyD+Ygx2/FWkimYLrsGlf9ddIoANl0+ZG+RdIJoFAWU4EZAYNjDf6 TxLIG4Z2tjbCkaV+eFEFZR7ZcltR/nR2gp7NE6zqtUL7G9weacIRrsswM3EBD5ZQjG6oGVqWljn 1tAHECpn8OjggP564= X-Received: by 2002:a2e:7c19:0:b0:2cc:89f4:15a3 with SMTP id x25-20020a2e7c19000000b002cc89f415a3mr1264770ljc.49.1706788652531; Thu, 01 Feb 2024 03:57:32 -0800 (PST) X-Google-Smtp-Source: AGHT+IEjsFgUmHk1ULXD42hwd5LywwdsnJENuXCHmsWpcxdWVVP0FKyuCBC5+nxPgXkkeYIg42csly8hUtJc90m6Dis= X-Received: by 2002:a2e:7c19:0:b0:2cc:89f4:15a3 with SMTP id x25-20020a2e7c19000000b002cc89f415a3mr1264758ljc.49.1706788652218; Thu, 01 Feb 2024 03:57:32 -0800 (PST) MIME-Version: 1.0 References: <20231224220201.762377-1-jonathan.erb@threater.com> <20240118172602.898004-1-jonathan.erb@threater.com> In-Reply-To: <20240118172602.898004-1-jonathan.erb@threater.com> From: David Marchand Date: Thu, 1 Feb 2024 12:57:20 +0100 Message-ID: Subject: Re: [PATCH] telemetry: correct json empty dictionaries To: Jonathan Erb Cc: ciara.power@intel.com, dev@dpdk.org, bruce.richardson@intel.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 19, 2024 at 8:48=E2=80=AFAM Jonathan Erb wrote: > > Fix to allow telemetry to handle empty dictionaries correctly. > > This patch resolves an issue where empty dictionaries are reported > by telemetry as '[]' rather than '{}'. Initializing the output > buffer based on the container type resolves the issue. > > Signed-off-by: Jonathan Erb Thanks for the fix. Could you point at the change that introduced this issue? I will add the Fixes: tag when applying. --=20 David Marchand