From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 23F69A0C45; Thu, 28 Oct 2021 10:21:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0AE954067B; Thu, 28 Oct 2021 10:21:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 853EA4003F for ; Thu, 28 Oct 2021 10:21:20 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1635409280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+DLmertYN9v25qxNdgcew9y6opmjCgFmwAiUMM5O2qQ=; b=MXwY/oL3t8cBBZDffohTZ6TJ9sLUyJ+hO7v67d2jOCSHGrK7Rj4EB/V+m0lR0+a47+BlL9 9UUkzJbBE0opwhNe8zbBcOLq9N5vYI+9Qv2I8gSzqGK8Plbux8NSAQg3Ze37mBJZt4HIQQ 7UIUa4TQEgWh0fdRZPxMvgkge6D4Rso= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-587-VmF6PQO3O7qYqyqZXnqDBA-1; Thu, 28 Oct 2021 04:21:16 -0400 X-MC-Unique: VmF6PQO3O7qYqyqZXnqDBA-1 Received: by mail-lj1-f198.google.com with SMTP id r13-20020a2e970d000000b00211a01c5f3fso1349923lji.7 for ; Thu, 28 Oct 2021 01:21:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+DLmertYN9v25qxNdgcew9y6opmjCgFmwAiUMM5O2qQ=; b=qs6ctlXF/HMuszmlSbzU4Gza5JXxBfp9HjovIccZRP46W9pDx41clxd14IBoJvGfoY dSdi4shNDexmiwmSEWnydFVeCD+AnW4zveoSipxuJi+TuEsGq2UXTRs5HpEsPNYGrG87 s4JXv/Bi1hWEAnL4IDDUp8ycO7NDgKuk32KLrpghdPmVsK6GxPBmuh1upiR6IL4PmqKL b8FG7hF81ioWJp58Higsn5RjEqmd40fHfu4LN+LbSzPneECnMY80vI6oM9VecUbcsjb3 fLvs2N4zy4g4Nq5BWAFLs3qfl8+eeLI/EsQV/1gOQQhD3vz7F9oQ8mhvcmJYzcNK+njV HvwQ== X-Gm-Message-State: AOAM53238Rf6uPIq2Leaf8f6u2/eAz0bBU6VG5WJBV03ZDdUUVAVZFqx ogfMrjPYj1yVfncfylZA8qH6FKzGUYQe+Ku66Dkuu1LJzYEbCULIxND1Wa6385LJpGOzgz/WNlj 8tYLzMj6fz+/CgYmwYco= X-Received: by 2002:a2e:7f1b:: with SMTP id a27mr2973717ljd.55.1635409275075; Thu, 28 Oct 2021 01:21:15 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxn3WXA8mnUr0plbBcLdiyGIvsWf8E+Z9w15Ed6xpbEhbNoBSaCTv3vHJvVd0GkpYbi+MicigWif/rxTlmXHiM= X-Received: by 2002:a2e:7f1b:: with SMTP id a27mr2973696ljd.55.1635409274897; Thu, 28 Oct 2021 01:21:14 -0700 (PDT) MIME-Version: 1.0 References: <25dd76eca01ec57d64be9c0a78ac2752f602984f.1631788595.git.anatoly.burakov@intel.com> In-Reply-To: From: David Marchand Date: Thu, 28 Oct 2021 10:21:03 +0200 Message-ID: To: "Xia, Chenbo" , "Burakov, Anatoly" Cc: "Yigit, Ferruh" , "dev@dpdk.org" Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 22, 2021 at 1:31 PM Xia, Chenbo wrote: > > > -----Original Message----- > > From: Yigit, Ferruh > > Sent: Wednesday, September 22, 2021 5:27 PM > > To: Xia, Chenbo ; Burakov, Anatoly > > ; dev@dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent > > > > On 9/22/2021 4:30 AM, Xia, Chenbo wrote: > > > Hi Anatoly, > > > > > >> -----Original Message----- > > >> From: dev On Behalf Of Anatoly Burakov > > >> Sent: Thursday, September 16, 2021 6:37 PM > > >> To: dev@dpdk.org > > >> Subject: [dpdk-dev] [PATCH v1 1/2] vfio: make API return values consistent > > >> > > >> Currently, when VFIO support is not compiled, FreeBSD and Linux have > > >> different return values. Fix Linux implementation to follow FreeBSD one. > > >> > > >> Signed-off-by: Anatoly Burakov > > >> --- > > >> > > >> Notes: > > >> Current minimum support Linux kernel is 4.4, and Meson build file sets > > the > > > > > > Do you mean currently DPDK support linux >= 4.4? I am not aware of this, > > could you > > > show me where it is defined? > > > > > > > https://git.dpdk.org/dpdk/tree/doc/guides/linux_gsg/sys_reqs.rst?h=v21.08#n124 > > > > Commit d2feae68bf30 ("doc: update minimum supported Linux kernel") > > Thanks Ferruh! > > About removing the fallback or not, if we decide to remove, maybe for other files > that check linux kernel version, we also need to change some check because we are > assuming kernel version >= 4.4 here. If that's a strong requirement, I'll vote for > yes... >From those comments, it is unclear I can merge this series. Anatoly? Thanks. -- David Marchand