From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9308142969; Mon, 17 Apr 2023 09:10:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6711440DFB; Mon, 17 Apr 2023 09:10:55 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id ECD4840698 for ; Mon, 17 Apr 2023 09:10:53 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681715453; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DOIf15BDksJvYwuJMpLOfYF884Rxe6YUOj70H9G87RY=; b=RMbiqeg6ORL+9KHKgqZxBKo3VeK4EhVgjj0YMe9+MZ5Z6OxPVoo4/MIRHSBjoSmE2jl8Xg 4AUnjReDo11A5fvHH47WGk/Y0XwUlc1XWjDMqqjQY/Z/vWWmvQlZSzrRUuHnpfzDcwecOs UHQEgZgAybz7n7ElfUpQf4VV3Kx6nyo= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-518-mxhdp63YOc2jR0fazQeTcg-1; Mon, 17 Apr 2023 03:10:52 -0400 X-MC-Unique: mxhdp63YOc2jR0fazQeTcg-1 Received: by mail-pj1-f72.google.com with SMTP id b13-20020a17090a6acd00b0024498a6e9ecso8133833pjm.2 for ; Mon, 17 Apr 2023 00:10:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681715451; x=1684307451; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=DOIf15BDksJvYwuJMpLOfYF884Rxe6YUOj70H9G87RY=; b=mAiNVP2EMahvrRQEcmfjCMUJccvTUy9PL/Qh9aSUlgWgrEBSerO6+4+H7oOyLZ3iBk cRIdiphUkhPZlaX8phuY5wxWPqO5a7p+/uZdWcaIBrTVm+GhOISKwN7h6mdp4fbgcbR2 0W+gw5phhKUztgi61ofWub2DLS7wD3Ys5O/4XldE49f82Yh+2QT6Gmpqb/jCa8FUt7xS IyU8xKSI+EUwVRe55zVXjTBP2AA/8x2dGHrnjYbN2KDSwGHf+2y7sBZW9naAfT5vDl6X BhPA2tv2CGwrRVOgvpqkQSXiFD73ffNn6F4CI03uxV8dLg5Kp5b7SzguqzqFWBfYGnu+ yeaA== X-Gm-Message-State: AAQBX9dNDjPLgOu4kALCM6SIVIunlsgbtYHYnRWt+Goq6hplOz/xAm2N OhnS+X1GiuvBx/1jozKZV3y7ZauFiHPZ4E7QVcxI911xA0C6AQaiZXNMF/zwfbZ8OL3haxbVS5q nTPQN/qLrBsh8jTNo9cI= X-Received: by 2002:a17:90a:138a:b0:246:a24a:49a7 with SMTP id i10-20020a17090a138a00b00246a24a49a7mr3662680pja.8.1681715451143; Mon, 17 Apr 2023 00:10:51 -0700 (PDT) X-Google-Smtp-Source: AKy350YOQnrmRJYPajDN2Jh4YvCDPjwfVbQ11Y9jNLIgJp+6jPPbSzXtF9dIh19DKFwMdKAO8NQ1uJB4IbVcUha1C+k= X-Received: by 2002:a17:90a:138a:b0:246:a24a:49a7 with SMTP id i10-20020a17090a138a00b00246a24a49a7mr3662671pja.8.1681715450831; Mon, 17 Apr 2023 00:10:50 -0700 (PDT) MIME-Version: 1.0 References: <20230417015140.40421-1-mingjinx.ye@intel.com> In-Reply-To: <20230417015140.40421-1-mingjinx.ye@intel.com> From: David Marchand Date: Mon, 17 Apr 2023 09:10:39 +0200 Message-ID: Subject: Re: [PATCH v3] net/i40e: support enable/disable source pruning To: Mingjin Ye Cc: dev@dpdk.org, qiming.yang@intel.com, stable@dpdk.org, yidingx.zhou@intel.com, Yuying Zhang , Beilei Xing , Thomas Monjalon , Ferruh Yigit , Kevin Traynor , Luca Boccassi , "Xueming(Steven) Li" X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Apr 17, 2023 at 3:58=E2=80=AFAM Mingjin Ye = wrote: > > VRRP advertisement packets are dropped on i40e PF device because > when a MAC address is added to a device, packets originating from > that MAC address are dropped. > This patch adds a PMD specific API to enable/disable source > pruning to fix above issue. > > Bugzilla ID: 648 > > Fixes: 94b3c1a72507 ("net/i40e: move testpmd commands") > Fixes: bce83974ba2c ("net/i40e: set Tx loopback from PF") > Fixes: 96974a6600ec ("net/i40e: move private APIs to a specific file") > Fixes: 689bba33272d ("i40e: add VEB switching support") > Fixes: 440499cf5376 ("net/i40e: support floating VEB") > Fixes: ef4c16fd9148 ("net/i40e: refactor RSS flow") I see this as a new feature. Please don't mark faulty any commit that touched this code (especially the ones that only moved code around). This is confusing. > Cc: stable@dpdk.org Cc: stable maintainers. This commit changes the default behavior, with no way to return to the old behavior (afaics). Backporting it poses a risk of breaking existing applications. > > Signed-off-by: Mingjin Ye --=20 David Marchand