From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7311645BB8; Fri, 25 Oct 2024 16:55:24 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B6F84026B; Fri, 25 Oct 2024 16:55:24 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 2D4D44021F for ; Fri, 25 Oct 2024 16:55:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729868122; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/ECIAWPDQWurZvlQX7NV13T5FHZqKMCQ9Eulmp1pySw=; b=GeFDnvPqS9VIV9oMxCYQUAwSf/w55jiT/CFw5Z19RFKAYm9aRaRz23z2/SW3fpq6bmRnKL cvgBlWuNLobXFYVn/bNKbao9u5XGTvE/yn3mgABX+Zv0c8WqYfz6HhTUAn6UncCkF5mLKK m2tI86CRa3bp62sKLPW6GzqGICaHRgs= Received: from mail-lj1-f198.google.com (mail-lj1-f198.google.com [209.85.208.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-127-PTgb_xNpN5S2sDkM5-0zJg-1; Fri, 25 Oct 2024 10:55:21 -0400 X-MC-Unique: PTgb_xNpN5S2sDkM5-0zJg-1 Received: by mail-lj1-f198.google.com with SMTP id 38308e7fff4ca-2fb60277fb2so16196191fa.0 for ; Fri, 25 Oct 2024 07:55:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729868120; x=1730472920; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/ECIAWPDQWurZvlQX7NV13T5FHZqKMCQ9Eulmp1pySw=; b=OzG1H93hjIy+17R8g/HL37iiCfVZMrc85WHeOpy5fZMn7d3/JDY1rWd5+dN9pSMoBM VYcRoNRaL38vY+dgYv8a32Y+5pENK3l5szd2Qx18m6bFwpUMkoz8dnK8eKTOyo3qysR/ iK94H4nsJJUrsxsR+6Csz+GkBGQmruIdg0U2qBWHCs0ASqj5KfVGwBNhjiHn5OCVNyxs 1xhs/lz1wGypWF7MZ/K4k+nHi0PlsqKJD/+MvxfqgPQR3c2/Dgu+LK4eNSrqB8gcV2Vm 7ngufU8K4FlPKlUs4nAZcVn/rVid5WYwgZTs71LLGXKkpSCTKmYECH7q/Sb6jH9DvTrZ dfyw== X-Gm-Message-State: AOJu0YxOa8Nxyx11+DZHf7QSv86Vg/1yxSVOR5/YHt7/ojfl1Q4rFtp5 2dObK+yXYEAFR8sNxEYY7Bg6OXpxIjNvFQErQl8Kveg2Y5BK+oStHSz2t4Fu6WtKZMK0F77ptaC /m5F3nnd05dWYQ2fPvotwwySdPCEYV3/WXfh4uz5LXm9uRznNamjlA9MxNrpJS9zXRpcgR7SKQW G+yhJyLb73g1jWXyI= X-Received: by 2002:a2e:709:0:b0:2fa:d177:13e6 with SMTP id 38308e7fff4ca-2fc9d35b125mr48544801fa.21.1729868119963; Fri, 25 Oct 2024 07:55:19 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHmH713BF3U/M7uMCp54UE0vN4oel6sqsmeUye5XSJyJnUJzlUGGTD4cNIwMjOXaBdOjnaRP9nhCt8Ue7Opatc= X-Received: by 2002:a2e:709:0:b0:2fa:d177:13e6 with SMTP id 38308e7fff4ca-2fc9d35b125mr48544581fa.21.1729868119527; Fri, 25 Oct 2024 07:55:19 -0700 (PDT) MIME-Version: 1.0 References: <20241017142214.1669370-1-bruce.richardson@intel.com> In-Reply-To: From: David Marchand Date: Fri, 25 Oct 2024 16:55:08 +0200 Message-ID: Subject: Re: [PATCH 0/6] Reduce scope address-of-packed-member warning To: Bruce Richardson Cc: dev@dpdk.org X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Oct 25, 2024 at 3:24=E2=80=AFPM David Marchand wrote: > > On Thu, Oct 17, 2024 at 4:22=E2=80=AFPM Bruce Richardson > wrote: > > > > The warning for address-of-packed-member was being disabled globally in > > DPDK. While for drivers which need to access hardware-defined > > data-structures the use of packed may make sense, for normal libs and > > applications the use of packed data should be generally avoided. > > > > This patchset initially applies some fixes for cases where we are > > unnecessarily causing the warning to trigger. Thereafter the 6th patch > > removes the global enabling of the warning and replaces it with more > > selective disabling for drivers and for a couple of other components > > which have not yet been fixed. > > > > Bruce Richardson (6): > > ip_frag: remove use of unaligned variable > > efd: remove unnecessary packed attributes > > bus/ifpga: remove packed attribute > > pipeline: remove packed attribute > > net: add smaller IPv4 cksum function for simple cases > > build: limit scope of packed member warning disabling > > > > app/test-eventdev/test_pipeline_common.c | 25 +----------- > > app/test-pmd/icmpecho.c | 23 +---------- > > app/test-pmd/txonly.c | 22 +---------- > > app/test/packet_burst_generator.c | 49 +----------------------- > > app/test/test_reassembly_perf.c | 29 +------------- > > config/meson.build | 1 - > > drivers/bus/ifpga/bus_ifpga_driver.h | 2 +- > > drivers/meson.build | 9 +++-- > > examples/ipsec-secgw/meson.build | 6 +++ > > lib/efd/rte_efd.c | 4 +- > > lib/ip_frag/rte_ipv4_reassembly.c | 4 +- > > lib/net/rte_ip.h | 33 ++++++++++++++++ > > lib/pipeline/rte_table_action.c | 2 +- > > lib/vhost/meson.build | 5 ++- > > 14 files changed, 60 insertions(+), 154 deletions(-) > > Recheck-request: rebase=3Dmain,iol-unit-amd64-testing,iol-unit-arm64-test= ing Unfortunately, there is a small conflict and the CI can't retest this serie= s. Bruce, can you send a v2 please? --=20 David Marchand