From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5E7AFA0548; Wed, 8 Jun 2022 10:42:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4EF0140689; Wed, 8 Jun 2022 10:42:06 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 2137F4021D for ; Wed, 8 Jun 2022 10:42:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1654677724; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pcxVb4ka0OEqM07kcTX43NpQEcttCegox0DlNg5Ojk4=; b=J8s9FiQVdPvjJb8yMEIEKMO/R+ui41il9mZM1NF5n3U2I/qju9SKIO2hcHg896xYyXDEId gT0OPEoJ6pdkNlLyyA/mEY6YPnC4ouwwA/e0wz0kbb44WR3OMG8fwZ5QOolB/pTcXJTrV6 l2apjsu0F5a95MvUNn+yoE16AmY86UI= Received: from mail-lf1-f71.google.com (mail-lf1-f71.google.com [209.85.167.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-654-CG3FO5W3MHaNcD4EWfqWIQ-1; Wed, 08 Jun 2022 04:42:03 -0400 X-MC-Unique: CG3FO5W3MHaNcD4EWfqWIQ-1 Received: by mail-lf1-f71.google.com with SMTP id p36-20020a05651213a400b004779d806c13so9994011lfa.10 for ; Wed, 08 Jun 2022 01:42:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pcxVb4ka0OEqM07kcTX43NpQEcttCegox0DlNg5Ojk4=; b=UBgxKKV9pb8YXehcndF3MT44UqD3zzOFF9/krLBi0kx1EsSoerGnIS0yrUCICM5twj eRtNmZyTDNlICSTEP/NhPQZm5OD2pRrwKHq026C7AxI5WN3B8e6y0fF3u5FYdZnvN8Bq ecIVS33Sn9AvOIp3/yDdO3XTKM14pi4JY/HsYp/R+N9QtoDB8bLp1l60KabLqEHnzM1/ DCJVsL+zQOdcjlpdCY367bG578JziBLoYdwhqoWfssFJUeGNcy+DsJ6t+uFE5owpPFgE zE39OkyWS5oRYMj52d9itKzsLcZqO4VC2ayI9r+Jy1qLoiKdNtKdhu067BgjN3p32aFl ehFw== X-Gm-Message-State: AOAM532z7Vr5dXcRSvvO3aHqNB88crsBrDTzjlEILzTSt3MXVWzuxnz/ IIr8PmdiIN0lywHU4Ab5+cYG7DRqCI4wz5HYUNyyKparnh5EdRZtvQG5HHrudMbVNPecG4rsgvW F1sHRiN+rmVAeYB4lgQU= X-Received: by 2002:a05:6512:3130:b0:479:385f:e2ac with SMTP id p16-20020a056512313000b00479385fe2acmr10890204lfd.575.1654677722020; Wed, 08 Jun 2022 01:42:02 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzMVWKLOJlgg9UwVCrErt3GIBJGziQ1K48h3kJEL9XLnYRWBeUOd22MzLQwJMyWMZ6fGRoNAfbCeW84uX/vBL4= X-Received: by 2002:a05:6512:3130:b0:479:385f:e2ac with SMTP id p16-20020a056512313000b00479385fe2acmr10890193lfd.575.1654677721766; Wed, 08 Jun 2022 01:42:01 -0700 (PDT) MIME-Version: 1.0 References: <20220531141307.253385-1-kda@semihalf.com> In-Reply-To: <20220531141307.253385-1-kda@semihalf.com> From: David Marchand Date: Wed, 8 Jun 2022 10:41:50 +0200 Message-ID: Subject: Re: [PATCH v4 0/8] Introduce support for RISC-V architecture To: Stanislaw Kardach Cc: dev , Frank Zhao , Sam Grove , Marcin Wojtas , upstream@semihalf.com, Heinrich Schuchardt Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, May 31, 2022 at 4:14 PM Stanislaw Kardach wrote: > > This patchset adds support for building and running DPDK on 64bit RISC-V > architecture. The initial support targets rv64gc (rv64imafdc) ISA and > was tested on SiFive Unmatched development board with the Freedom U740 > SoC running Linux (freedom-u-sdk based kernel). > I have tested this codebase using DPDK unit and perf tests as well as > test-pmd, l2fwd and l3fwd examples. > The NIC attached to the DUT was Intel X520-DA2 which uses ixgbe PMD. > On the UIO side, since U740 does not have an IOMMU, I've used igb_uio, > uio_pci_generic and vfio-pci noiommu drivers. > > Functional verification done using meson tests. fast-tests suite passing with > the default config. > > PMD verification done using a Intel x520-DA2 NIC (ixgbe) and the test-pmd > application. Packet transfer checked using all UIO drivers available for > non-IOMMU platforms: uio_pci_generic, vfio-pci noiommu and igb_uio. > > The i40e PMD driver is disabled on RISC-V as the rv64gc ISA has no vector > operations. > > RISCV support is currently limited to Linux as the time measurement frequency > discovery is tied to reading a device-tree node via procfs. > > Clang compilation currently not supported due to issues with missing relocation > relaxation. > > Commit 1 introduces EAL and build system support for RISC-V architecture > as well as documentation updates. > Commits 2-5 add missing defines and stubs to enable RISC-V operation in > non-EAL parts. > Commit 6 adds RISC-V specific cpuflags test. > Commits 7-8 add RISC-V build testing to test-meson-builds.sh and github CI. Overall, the series lgtm. It did not get much reviews, but the porting is straightforward and clean enough. I'm waiting for some compilation to finish and I will merge it for 22.07-rc1. Some comments that will probably require some followup patches for rc2: - I removed the known issue about --no-huge from the EAL patch. This seems to be a generic issue that does not block the RISC V port and can be re-submitted as a separate patch. - I had some trouble with finding a right toolchain for test-meson-builds.sh. The mentionned toolchains in the cross build guide don't work for me on FC36. I managed to cross compile with a Bootlin toolchain, though I had to adjust the cross compilation file. I'll probably end up compiling my own toolchain later unless you have a better idea. At least the compilation in GHA works. - The hardcoded pkg-config path in config/riscv/riscv64_linux_gcc does not seem generic. It is probably not a big issue, but I'd rather move it to a Ubuntu specific cross compile meson file. WDYT? - I adjusted some coding style in some asm and some indentation and wording in meson. - The cross compilation guide mentions using crossbuild-essential-riscv64 for Ubuntu. We should switch to it in GHA. Though after trying myself, there is an issue in the C++ headers check in GHA for some acl header including rte_vect.h. Can you have a look? - There was a patch from Heinrich about native compilation, can you review it? -- David Marchand