From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C11C43B28; Fri, 16 Feb 2024 08:52:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48D7140284; Fri, 16 Feb 2024 08:52:23 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B615D40266 for ; Fri, 16 Feb 2024 08:52:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1708069942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5GOikViKdet3Ep13x1e9H2VRDA/6bTOmUuQO+4UELnQ=; b=EtCKJ6tBUPHZz9On6WjBPsxeNvXZdGGmXRAV5GDe8i6IgxyzRv2AcGMi55HAsn2sJru7HJ afgNcSjZ+Mu1mgDGw+ia5qvDwkZlGvHY1egP6XU1J158bvOnQfWDfv5R42mGGaCqcu/wIu kEfGAQj0fpfOSzwMtS44LWJPjE22SIY= Received: from mail-lj1-f200.google.com (mail-lj1-f200.google.com [209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-277-oXWKiw9aMd6pziWsLsj7_A-1; Fri, 16 Feb 2024 02:52:20 -0500 X-MC-Unique: oXWKiw9aMd6pziWsLsj7_A-1 Received: by mail-lj1-f200.google.com with SMTP id 38308e7fff4ca-2d099291380so3112161fa.1 for ; Thu, 15 Feb 2024 23:52:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708069939; x=1708674739; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5GOikViKdet3Ep13x1e9H2VRDA/6bTOmUuQO+4UELnQ=; b=sEoTCVQlg6ZRmATSfHAtyUddH/MhySPuX6P5F2vl1g0vYgvtwER2gELDGZBY5Ias+R MOEAYP+tPDSEXOPHm8jMbtRQXIwzobwKLmdlLppZBtTYXAiA0RlHAtJTDgrmWtx/pk9+ 6gXp8MrcHTYTMI/ge/WajZt2wFTUU0DZrVeJzL3NamODck4KB/2HmKJW20jHahBp26ox N+XQ8hnBhZAhysxG3A9sQxQ1/XUp1W5PChRkh5vwxvB5lqrfNHs6hzgVVl/wHqysLRBR oinEG3VVcEX7MpWgJK9h0pudTHuF4DEOfGgTo7PhsPCMxYb+shCRuh+vd9Jf/OaiyXYM YpDw== X-Gm-Message-State: AOJu0YzaN27RsCyfwrsS1RdE5G52aIlZKLFNONo5tpxfDjUdfxZcTEY6 Tx3H93uMD+cpN34nexmltsOp/4PuiCDhaycj95K2bqIn7YYyciFwujPdHk1WBSoVeevYNPx284Z Os/r8go12jTjIBDyNs03KLsVHqLUzqcXtuFnvizIOOeg3h76qLWEG7ATIjhgpKk222I+ukbCYvB wYaFtCTgcGMGkiVl4= X-Received: by 2002:a2e:9217:0:b0:2d0:dfa6:2b3f with SMTP id k23-20020a2e9217000000b002d0dfa62b3fmr3286207ljg.1.1708069939321; Thu, 15 Feb 2024 23:52:19 -0800 (PST) X-Google-Smtp-Source: AGHT+IGyXEb7lMmgxqY1Ehmv5GaEiyn5ahPl4+GjoXurPNPC78jRP3z7I7hYjvt6EDBkdJaUThuZp375KlmhhHbAxao= X-Received: by 2002:a2e:9217:0:b0:2d0:dfa6:2b3f with SMTP id k23-20020a2e9217000000b002d0dfa62b3fmr3286197ljg.1.1708069938989; Thu, 15 Feb 2024 23:52:18 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Fri, 16 Feb 2024 08:52:07 +0100 Message-ID: Subject: Re: meson option to customize RTE_PKTMBUF_HEADROOM patch To: Parthakumar Roy Cc: "dev@dpdk.org" , Bruce Richardson X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hello, On Thu, Feb 15, 2024 at 8:02=E2=80=AFPM Parthakumar Roy wrote: > > Hello, > Bruce Richardson suggested that I submit this patch - at IBM we needed to= adjust the pkt_mbuf_headroom for our application to work. This is my first= ever patch through a mailing list, I have only done it through Pull Reques= ts before, so let me know if I need to correct something. Thanks for the contribution. I have some comments on the form. First of all, there are issues (the change is included as part of a multipart mail + html) in the format of the change itself, which distracted our CI tools. As a result, the patch was not recognised and can't be tested by the CI. We also need a SoB. Please have a look at the contributors guide (esp. chaptors 1 and 8): https://doc.dpdk.org/guides/contributing/patches.html > > Message: > Add meson configuration option to adjust RTE_PKTMBUF_HEADROOM You must describe with more detail the goal/usecase that you want to address with a change. For example here, I am curious to know how you need to adjust the headroom. Is it for increasing it? I consider the current headroom already quite huge (it is enough to encapsulate 2 whole vxlan tunnel headers, for example). --=20 David Marchand