From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 846ECA0C43; Tue, 19 Oct 2021 09:01:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6FC3D40E2D; Tue, 19 Oct 2021 09:01:48 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 0457140DF5 for ; Tue, 19 Oct 2021 09:01:46 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1634626906; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BtTL0P3RC5HugsOjJHMTCkVoOAxV7lzr0fMo/3H0ARQ=; b=Hvms593SrkATRl8+4QznxmiDn7Tlu3SvsvweChq2uVI1gJCoeZa37Me+IicMyLDFB0zgl8 oc2cBe9PA0m2uuty8/FEOkMT4sojnsadui0uvsavYQN6bEOlla1e6ZYlBLMtcraAnB/QHK IdkB/Os47ZzG4YTRcJ4a8783MdYS4gI= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-530-AN-IPZ4nN5q9ryCGoialAQ-1; Tue, 19 Oct 2021 03:01:45 -0400 X-MC-Unique: AN-IPZ4nN5q9ryCGoialAQ-1 Received: by mail-lj1-f199.google.com with SMTP id k12-20020a2ea26c000000b00210f22d4769so532817ljm.4 for ; Tue, 19 Oct 2021 00:01:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=BtTL0P3RC5HugsOjJHMTCkVoOAxV7lzr0fMo/3H0ARQ=; b=U7iEJ+8eBVYq+/T3lv/gTty2bLwNSrQCbwEitFkJ2uHvljatEtSFmZIorr2DgSUvo0 p5gIQ1dQDytM9FmX6fLyvmTYIFedd7GUlC7kx3zNg5StPMc/x2AABDoDRBomRkL14QU1 3uK46h1RzrRLgwVua3UpdDWMo1q80LVBsm7Fc0fgtp78S8txR4za+RLjdTC/ISlx51EZ MqE0A10IrXlIcnqDCb+95QZUD1jnD4DneVEH1E6ITXpCN6yVLxCq12T0f94ikAcluk8Q Dbi09Ghp12wBEi6BeqQ5mPL1kJhN7NN7FJO5F9yGjJPimQdjn56TJI5f8NDbsXwBsEk+ HJgQ== X-Gm-Message-State: AOAM53363YH7xdBNseGqLqsyn9+DsWwU7nT8uXyTFkYMsFB0cXowdUDe p55+4HQdvmRfjuaBV0Okok0hGnWuJR8rnNle5leOOWmyl6CRal/D5TIQzgDcRhhwBe7VCkaAprK afhRuPFerJuXeyX8ApBU= X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr4313375lfq.553.1634626903421; Tue, 19 Oct 2021 00:01:43 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxLhZSsJQSt7Ddhz5rSNr8Pf7SoVa7Tscet7zEgvpZvvc+sdwh1SDiGp9IGhkT6BmvQUs/EmOgbCyVzUl3Jcjg= X-Received: by 2002:ac2:4bc1:: with SMTP id o1mr4313355lfq.553.1634626903214; Tue, 19 Oct 2021 00:01:43 -0700 (PDT) MIME-Version: 1.0 References: <20211006065012.16508-1-pbhagavatula@marvell.com> <20211015190221.2160-1-pbhagavatula@marvell.com> <20211015190221.2160-14-pbhagavatula@marvell.com> In-Reply-To: From: David Marchand Date: Tue, 19 Oct 2021 09:01:32 +0200 Message-ID: To: Pavan Nikhilesh Bhagavatula , Ray Kinsella Cc: Jerin Jacob , Jerin Jacob Kollanukkaran , dpdk-dev Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v4 14/14] eventdev: mark trace variables as internal X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Pavan, On Mon, Oct 18, 2021 at 5:07 PM Pavan Nikhilesh Bhagavatula wrote: > >[for-main]dell[dpdk-next-eventdev] $ ./devtools/checkpatches.sh -n > >14 > > > >### eventdev: move inline APIs into separate structure > > > >INFO: symbol event_dev_fp_ops_reset has been added to the > >INTERNAL > >section of the version map > >INFO: symbol event_dev_fp_ops_set has been added to the INTERNAL > >section of the version map > >INFO: symbol event_dev_probing_finish has been added to the > >INTERNAL > >section of the version map > > These can be ignored as they are internal Those first warnings are informational. > > >ERROR: symbol rte_event_fp_ops is added in the DPDK_22 section, but > >is > >expected to be added in the EXPERIMENTAL section of the version map > > This is a replacement for rte_eventdevs, ethdev rework also doesn=E2=80= =99t mark > it as experimental. @David Marchand @Ray Kinsella any opinions? This check is there to ensure that added symbols first go through a period in experimental status. Same as for ethdev, the use of inlines in stable API directly exposes a new symbol to applications. With this implementation, this check can be waived and the symbol can go directly to stable status. This symbol being exposed as stable, it will be frozen in ABI until next breakage. I see you reserved 6 spots for new ops, so it looks ok. --=20 David Marchand