From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
by inbox.dpdk.org (Postfix) with ESMTP id E391CA09E8;
Tue, 8 Dec 2020 16:32:13 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
by dpdk.org (Postfix) with ESMTP id 204B472D9;
Tue, 8 Dec 2020 16:32:12 +0100 (CET)
Received: from us-smtp-delivery-124.mimecast.com
(us-smtp-delivery-124.mimecast.com [63.128.21.124])
by dpdk.org (Postfix) with ESMTP id 2076BA3
for <dev@dpdk.org>; Tue, 8 Dec 2020 16:32:10 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
s=mimecast20190719; t=1607441528;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
in-reply-to:in-reply-to:references:references;
bh=PPXz+8TkXm+BvWxkfaoCFL+pPO3ncLVU3T1s1c7bRPs=;
b=hhbrfcSbC5+2Rb7LDLjAAueCZN7klh40oxqDuRzyLnFCDim6Ka4KZOXctNZKHhb9FHsZIU
b0Ha0n6G/ZNbWaTeqswNXUopfHZ5ytx6cdCg0q38xTCKnUr+nKLpQg3vfNcvtBYmGW1E78
JRuKF3oJHhgKQ2G4D8rR9FMdA8VosdA=
Received: from mail-vs1-f72.google.com (mail-vs1-f72.google.com
[209.85.217.72]) (Using TLS) by relay.mimecast.com with ESMTP id
us-mta-436-1_W6Kk7jNz-WNT_z8UrqBA-1; Tue, 08 Dec 2020 10:32:07 -0500
X-MC-Unique: 1_W6Kk7jNz-WNT_z8UrqBA-1
Received: by mail-vs1-f72.google.com with SMTP id y82so3532031vsc.14
for <dev@dpdk.org>; Tue, 08 Dec 2020 07:32:07 -0800 (PST)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=PPXz+8TkXm+BvWxkfaoCFL+pPO3ncLVU3T1s1c7bRPs=;
b=UGCwmkaDxCjk3UATTZea5fgySrs9zlsxcBdTqO8DkCGW5mfv02YnQZhSeC3AJXtbHj
3IMxkVEEDg4yBiOI+mT6bkvBb+XMMTlIoZhJ7IEowu1nUt3W0aE7AM2G1ik8710lp9ZR
Fczo8yjwOpvvkM10gZA2IVsNZykw/+swxqwaf06k3SsNvMECYt5Kzt227SIDaP9BXazs
R5ooJ8VbQmEInYNN1SSldyu6FWoZzG62ZVLqo5ijPnwyLupOdUltvsik0l9sU5ItSU9s
R25EN7lJEpbOtwU8LssKjfV+njLPinPt5J7tOTBjt+jipzGZsc2XhUMVfu0h5d8efdfE
wkaA==
X-Gm-Message-State: AOAM533Emg4RoqRkdSgCC0rVNV2emmkmCcGeTLQKNfh/0erloLD8+I1j
lFuIm4DzElD5GfJskf7iiuTpDSW+Bj9rfP6/wgnUeiiX7umDxcVQXByJx+pEmLNqPrvD9/udxDq
sTJN6egD0L3gs8muglQc=
X-Received: by 2002:a05:6102:212a:: with SMTP id
f10mr16695833vsg.18.1607441526390;
Tue, 08 Dec 2020 07:32:06 -0800 (PST)
X-Google-Smtp-Source: ABdhPJx5J+IfIwTVTFwhQsmZIRwdtlc+lLDkl6iJ5tRnBLm5uJ+T+C/EayOyJpGTcO5d1uJGOyVfmMSiYcVo3KWUrJw=
X-Received: by 2002:a05:6102:212a:: with SMTP id
f10mr16695806vsg.18.1607441526172;
Tue, 08 Dec 2020 07:32:06 -0800 (PST)
MIME-Version: 1.0
References: <20201207173235.1397351-1-thomas@monjalon.net>
In-Reply-To: <20201207173235.1397351-1-thomas@monjalon.net>
From: David Marchand <david.marchand@redhat.com>
Date: Tue, 8 Dec 2020 16:31:54 +0100
Message-ID: <CAJFAV8zNr72L=Vm0T33kpho0C5NmqDy9o_8MicSZ6aWGEoVJVg@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>, Bruce Richardson <bruce.richardson@intel.com>,
Ray Kinsella <mdr@ashroe.eu>, Neil Horman <nhorman@tuxdriver.com>
Authentication-Results: relay.mimecast.com;
auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH 1/1] devtools: adjust verbosity of ABI check
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>
On Mon, Dec 7, 2020 at 6:33 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> diff --git a/devtools/check-abi.sh b/devtools/check-abi.sh
> index ab6748cfbc..381db2cdd1 100755
> --- a/devtools/check-abi.sh
> +++ b/devtools/check-abi.sh
[snip]
> @@ -46,23 +46,24 @@ for dump in $(find $refdir -name "*.dump"); do
> fi
> dump2=$(find $newdir -name $name)
> if [ -z "$dump2" ] || [ ! -e "$dump2" ]; then
> - echo "Error: can't find $name in $newdir"
> + echo "Error: cannot find $name in $newdir" >&2
> error=1
> continue
> fi
> + echo abidiff $ABIDIFF_OPTIONS $dump $dump2
On error, this same command is repeated below, so I don't see the need
for this new debug message.
> abidiff $ABIDIFF_OPTIONS $dump $dump2 || {
> abiret=$?
> - echo "Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'"
> + echo "Error: ABI issue reported for 'abidiff $ABIDIFF_OPTIONS $dump $dump2'" >&2
> error=1
> echo
--
David Marchand