From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id ACE43A0577; Mon, 6 Apr 2020 22:09:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 81FDE2B96; Mon, 6 Apr 2020 22:09:06 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 340902B86 for ; Mon, 6 Apr 2020 22:09:05 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586203744; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=A4BdSW+7R3lV6nY0GwGWto81Uc/S5UP4l8WyBW0k3a4=; b=MbfNl6rpdyUt/mGUAwbqR9WrQhKUv/mbnfDA3RmIpGkdu65CpfJ3oExgCGqeH0coJeCtdT gAYjrzb5x+nFIFh5Qt9cwrIb9VQAmGEcVMvSwv2jMBKSMUG+yzRKNK4E/Ag8zgAC0/8d8D 6r/EBq/aAgL5mQSA/2u151o2AZKycns= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-466-k0Ubf_DHMcuhpFe6ypBFlA-1; Mon, 06 Apr 2020 16:08:59 -0400 X-MC-Unique: k0Ubf_DHMcuhpFe6ypBFlA-1 Received: by mail-ua1-f70.google.com with SMTP id d2so267283uak.11 for ; Mon, 06 Apr 2020 13:08:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+DT92vGHR1xWi207o60hF/PxuijDsxCaHQFiFDxn/JQ=; b=SAXSBGGDoPE/JEA2pyOE/03laqdOumluJGxtGAZql4PYwxT9vzMFX5s13FzGsePHX6 Yahu0gFub6tBotkiVDzgQyFpZN1mluwC5Gx5sRhczafTfSuyzqRvIzGm9MZkTJd+mY63 1qheXtgLGWCp9Ei7cnJcrFPga3Jbxk5i+Zav96p7/u1RD+0RC2iJRp2GsLCfC1w8tuAD 7xAfnBkdOa8YrOL2DO6ZWT6lHkOQbtgomAlN4L0qNeCII/jtAWosXVMs/A/gXcq64rfk /rD2H7BZmJvTRdmQJF9N+7kCNI+q242YL+vrEa2lyQu1crw7L25Drr3+BJZWQw7LEj5p toMw== X-Gm-Message-State: AGi0Puasj02I5KGUq2lgRw9uavbuyUbzw/Jav/WgrtZTtjYyjz2dQQtE fMPyDdQSDmHHrIS1Ij10y5CgDoopT4XvoQBR+f99AmIl6i5WKzlZIwNlmtZ/EgC14H6YiVmYH5l nQN/m20zUS/L60n8U4R8= X-Received: by 2002:a1f:3649:: with SMTP id d70mr808522vka.12.1586203738938; Mon, 06 Apr 2020 13:08:58 -0700 (PDT) X-Google-Smtp-Source: APiQypI3jp7BmP8maPcyJ44RAjdBqN7cVYHZxLf3McVVvWNdjGFakkdfH+Auh5zRrltcC728eqCSYtwqLOIvTXCQnvY= X-Received: by 2002:a1f:3649:: with SMTP id d70mr808502vka.12.1586203738648; Mon, 06 Apr 2020 13:08:58 -0700 (PDT) MIME-Version: 1.0 References: <20200331165657.29368-1-michael.haeuptle@hpe.com> In-Reply-To: From: David Marchand Date: Mon, 6 Apr 2020 22:08:47 +0200 Message-ID: To: "Haeuptle, Michael" Cc: "Burakov, Anatoly" , dev X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] eal: Fixes VFIO/sysfs race condition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Apr 6, 2020 at 9:15 PM Haeuptle, Michael wrote: > This is my first submission... how do I get the fixes reference? I recommend reading: https://doc.dpdk.org/guides/contributing/patches.html But let me help you this time. For the missing Fixes: tag, we want to get the sha1 of the commit that first exhibited the issue. For this you must either use git bisect (not always possible) or go back in the git history and find the culprit commit. git log -p --follow and git blame can help identify it (just be cautious and skip purely cosmetic changes if any). In your case, I *think* the commit is 340b7bb8d583661369a9491ade63fe2407e85267, since it introduced the vfio_open_group_fd() function and the check on its return value. I did not see changes between this commit and origin/master wrt to vfio_open_group_fd() return values. It might have been older than this, the vfio maintainer can help confirm. Anatoly, can you double check :-) ? For the formatting of the Fixes: tag, you have a git macro in https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-body Which then gives: $ git fixline 340b7bb8d58 Fixes: 340b7bb8d583 ("vfio: extend data structure for multi container") > > Back porting it to 19.11 would be great. This issue shows up in SPDK 20.0= 1, which uses 19.11. For the criterias on what should be backported: https://doc.dpdk.org/guides/contributing/stable.html#what-changes-should-be= -backported. You can annotate a patch with a version, but it will be informational only. What is important is to Cc: stable@dpdk.org so that stable maintainers see this fix and consider it for backport in the currently maintained branches (atm 18.11 and 19.11). The Fixes: line already gives an idea of which branches are concerned. The stable maintainers have scripts to catch fixes of interest for them (+ those scripts also check if a change is a fix of a previous fix that got backported itself). Here, if the above Fixes: is correct, it means this backport is a candidate to backport to 18.11 and 19.11. --=20 David Marchand