From: David Marchand <david.marchand@redhat.com>
To: Andre Muezerie <andremue@linux.microsoft.com>
Cc: dev@dpdk.org, roretzla@linux.microsoft.com,
"Morten Brørup" <mb@smartsharesystems.com>
Subject: Re: [PATCH v3] eal: fix macros for MSVC: noinline, alwaysinline, hot
Date: Thu, 23 Jan 2025 14:09:11 +0100 [thread overview]
Message-ID: <CAJFAV8zOCKAsDMDagY9QB9qBNia0_VpLL7swogqarRzTaD9uMg@mail.gmail.com> (raw)
In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F9DA@smartserver.smartshare.dk>
On Wed, Jan 22, 2025 at 6:10 PM Morten Brørup <mb@smartsharesystems.com> wrote:
>
> > From: Andre Muezerie [mailto:andremue@linux.microsoft.com]
> > Sent: Wednesday, 22 January 2025 17.24
> >
> > MSVC supports forcing code to be inlined or forcing code to not be
> > inlined, like other compilers. It does not support the "hot" hint
> > though.
> >
> > This patch fixes existing macros __rte_noinline and
> > __rte_always_inline so that they also do what is expected from them
> > when used with MSVC. __rte_hot is updated to become a noop when
> > MSCS is used.
> >
> > Signed-off-by: Andre Muezerie <andremue@linux.microsoft.com>
> Acked-by: Morten Brørup <mb@smartsharesystems.com>
Applied, thanks Andre.
--
David Marchand
prev parent reply other threads:[~2025-01-23 13:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 16:11 [PATCH] lib/eal: fix macros for noinline and alwaysinline for MSVC Andre Muezerie
2024-11-27 19:39 ` [PATCH v2] " Andre Muezerie
2025-01-22 16:24 ` [PATCH v3] eal: fix macros for MSVC: noinline, alwaysinline, hot Andre Muezerie
2025-01-22 17:10 ` Morten Brørup
2025-01-23 13:09 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zOCKAsDMDagY9QB9qBNia0_VpLL7swogqarRzTaD9uMg@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=andremue@linux.microsoft.com \
--cc=dev@dpdk.org \
--cc=mb@smartsharesystems.com \
--cc=roretzla@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).