From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 43EC3460FC; Thu, 23 Jan 2025 14:09:29 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 09AF340269; Thu, 23 Jan 2025 14:09:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 71C1E40263 for ; Thu, 23 Jan 2025 14:09:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1737637766; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d2DcxcWLZSmDWiGc4d+VWjvijL8+VCJsxP8J8zmHlSM=; b=ZFC7kPp4tws2ZwEuQ+lJo+4ANhxqhMDZ56jmZNjhhRZcJKozsPi8MX7qVqE++BlV2ynqly 6wQ45AvbtiA6x6FCxDlCxRX5MBgQL48kJwG3KXaL8DyjFIPLwF2+z4cMEaDxgGvjmW/rNq SxOThu2XvKjBpwrmznhmyGGpq/Hi3ug= Received: from mail-lj1-f199.google.com (mail-lj1-f199.google.com [209.85.208.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-275-cnJgApzjPZ-OA3i253g8cg-1; Thu, 23 Jan 2025 08:09:25 -0500 X-MC-Unique: cnJgApzjPZ-OA3i253g8cg-1 X-Mimecast-MFC-AGG-ID: cnJgApzjPZ-OA3i253g8cg Received: by mail-lj1-f199.google.com with SMTP id 38308e7fff4ca-30218346140so4340181fa.0 for ; Thu, 23 Jan 2025 05:09:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737637764; x=1738242564; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=d2DcxcWLZSmDWiGc4d+VWjvijL8+VCJsxP8J8zmHlSM=; b=l+X9bBzVpyWfu9YhJGos6kD6oeACLriU3HO8JFw8CIWI4kcUsyPpd3P2H2GW1z8kvj BmmytrHFV+Nk0ll/Dazh/AW4s9+ZkRm7MyUbWk41GXleamTQVf11MjJR/KJoVKw/dqy2 bvMmy1OPiLL0vTdL94yK0AiaJD+hX3BMFynHoTaQyzp1UBxt5WEgPcG5Wmd/eS1DsVO3 +PAofHLDnsVxRzne792BTimSj9tOdQfXvOaSOdZQ7vuOrfWeAvRUaElMZzJkp+PlNVph x6TN0+7r7jnCZijxmYLOdIT6WwYWigW6nT882F/iJtzqxgXCLWv+a0gcZ+LSaFzh9v7I Xt6g== X-Gm-Message-State: AOJu0YyZBr1n5FTUM06NRQqvdWssOXVNnMiNOrGNxQxcCGaYHI7dHuvI RX69jb3fNPQMDM3m78LKkImXYskszylMeV0Izv/JW15CZyEQo5rHOflxnqXRrFm+9DOsVimJ0Vy QjAHfugYiLf5K0KwzLtIW+t7dDCdxBEEQNjRpULkaIbjz20ZWitSbW9lMjn1pE21l0KH0YR24dC jx7uafyBHxgjnzWGA= X-Gm-Gg: ASbGncs5Y7qNlb2N6T7TjVHb6PNXfiMptnK9EgizycM6GkywXZSRVkvIPAHHuQpKOlW Jry2lVHRL/mBdPWkEELTS7pUNnpzoXwiBhfAH6IZm+zw9ky14ezsnFQ== X-Received: by 2002:a05:651c:1601:b0:302:1fce:3956 with SMTP id 38308e7fff4ca-3072ca60a25mr99707461fa.4.1737637763896; Thu, 23 Jan 2025 05:09:23 -0800 (PST) X-Google-Smtp-Source: AGHT+IFYZ3dUE/+NMyssThFDBN8wBh3GCMNnGV4hEN/sNbCbloV5XG3BbdY43r+vWMYADNvPQiJ5SCYPj6+tA7vIcVE= X-Received: by 2002:a05:651c:1601:b0:302:1fce:3956 with SMTP id 38308e7fff4ca-3072ca60a25mr99707371fa.4.1737637763503; Thu, 23 Jan 2025 05:09:23 -0800 (PST) MIME-Version: 1.0 References: <1732723879-23806-1-git-send-email-andremue@linux.microsoft.com> <1737563065-18741-1-git-send-email-andremue@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35E9F9DA@smartserver.smartshare.dk> In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9F9DA@smartserver.smartshare.dk> From: David Marchand Date: Thu, 23 Jan 2025 14:09:11 +0100 X-Gm-Features: AbW1kvZrttHYlUG3r160lKqFS60Uz9kfZjUj1fE6mmYUnR7cp37SOAthhlX2WVk Message-ID: Subject: Re: [PATCH v3] eal: fix macros for MSVC: noinline, alwaysinline, hot To: Andre Muezerie Cc: dev@dpdk.org, roretzla@linux.microsoft.com, =?UTF-8?Q?Morten_Br=C3=B8rup?= X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: zq1yixeSv3qusnJA4srubPUvENrXeVRGDN0CinGAtbo_1737637764 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jan 22, 2025 at 6:10=E2=80=AFPM Morten Br=C3=B8rup wrote: > > > From: Andre Muezerie [mailto:andremue@linux.microsoft.com] > > Sent: Wednesday, 22 January 2025 17.24 > > > > MSVC supports forcing code to be inlined or forcing code to not be > > inlined, like other compilers. It does not support the "hot" hint > > though. > > > > This patch fixes existing macros __rte_noinline and > > __rte_always_inline so that they also do what is expected from them > > when used with MSVC. __rte_hot is updated to become a noop when > > MSCS is used. > > > > Signed-off-by: Andre Muezerie > Acked-by: Morten Br=C3=B8rup Applied, thanks Andre. --=20 David Marchand