Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs

[David Marchand <david.marchand@redhat.com>]

On Wed, May 8, 2019 at 10:54 PM Thomas Monjalon <thomas@monjalon.net> wrote:

> Two public functions from EAL and metrics libraries need to return
> some new error codes instead of calling rte_panic or rte_exit.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>  doc/guides/rel_notes/deprecation.rst | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index b47c8c254..e61278429 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -20,6 +20,9 @@ Deprecation Notices
>  * kvargs: The function ``rte_kvargs_process`` will get a new parameter
>    for returning key match count. It will ease handling of no-match case.
>
> +* eal: The function ``rte_eal_remote_launch`` will return new error codes
> +  after read or write error on the pipe, instead of calling ``rte_panic``.
> +
>

Nit: do we need error codes ? or only a single new error code ?


 * eal: both declaring and identifying devices will be streamlined in
> v18.11.
>    New functions will appear to query a specific port from buses, classes
> of
>    device and device drivers. Device declaration will be made coherent
> with the
> @@ -82,3 +85,6 @@ Deprecation Notices
>  * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the
> xforms
>    structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
>    ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
> +
> +* metrics: The function ``rte_metrics_init`` will have a non-void return
> +  in order to notify errors instead of calling ``rte_exit``.
> --
> 2.21.0
>
>
Acked-by: David Marchand <david.marchand@redhat.com>

-- 
David Marchand