From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 311A34C93 for ; Thu, 9 May 2019 09:34:37 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id r62so789491vsc.9 for ; Thu, 09 May 2019 00:34:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PjUrBIL8zvFwCm0YaI6gZ7Bbhb1R8lNdL74OY1xTk8Y=; b=iFai6zyo7FVCey9AwFgGf3cPy4Unnr5R6lc4eQq9ChOJMif9pZQyxVhGrp5C+dBsgV 5aMoK3ZyifS63u6nq+lyKWzkgDEKr5gXlWgBr3wD88HNolIubYLNReUW80f80wiB14Ci imWw9SlpNrMUc1xMiLt2Ty9MIFyOZiE9enge1urRlz+3olaiGBHy5axPPpw5NAkXqgrR YPW+syZcv1B/0RtWofVgqf+C5oOHGyh3m5rhCcoG3kUUdYGyKQ3d1fQE5/yFk1ay2EKq kotuvSOi+GHDdY448fJMoucgIlPDXHZAkbzxuTedm1UqvkGFzX8tB1h35j9O3hNCebX+ BtJw== X-Gm-Message-State: APjAAAXt4TVV+sELq6PDUp/IMnBh9dAaQ8auCxU2KP0KHXhcdEOgGGzS iNQGoCafbsQQHs8KJcnAggmP+RRW+XEdYAUTpY7S2A== X-Google-Smtp-Source: APXvYqyXKdkSmOfAztIKKaX85vrnESsbCJmT5tGcRT9ieMgaRyR9Li/k9uuIQ5dhJEPuSvKrOk+caJHVCD8DthRNrpw= X-Received: by 2002:a67:2781:: with SMTP id n123mr431158vsn.141.1557387271716; Thu, 09 May 2019 00:34:31 -0700 (PDT) MIME-Version: 1.0 References: <20190508205413.31134-1-thomas@monjalon.net> In-Reply-To: <20190508205413.31134-1-thomas@monjalon.net> From: David Marchand Date: Thu, 9 May 2019 09:34:20 +0200 Message-ID: To: Thomas Monjalon Cc: Arnon Warshavsky , Stephen Hemminger , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 May 2019 07:34:37 -0000 On Wed, May 8, 2019 at 10:54 PM Thomas Monjalon wrote: > Two public functions from EAL and metrics libraries need to return > some new error codes instead of calling rte_panic or rte_exit. > > Signed-off-by: Thomas Monjalon > --- > doc/guides/rel_notes/deprecation.rst | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index b47c8c254..e61278429 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -20,6 +20,9 @@ Deprecation Notices > * kvargs: The function ``rte_kvargs_process`` will get a new parameter > for returning key match count. It will ease handling of no-match case. > > +* eal: The function ``rte_eal_remote_launch`` will return new error codes > + after read or write error on the pipe, instead of calling ``rte_panic``. > + > Nit: do we need error codes ? or only a single new error code ? * eal: both declaring and identifying devices will be streamlined in > v18.11. > New functions will appear to query a specific port from buses, classes > of > device and device drivers. Device declaration will be made coherent > with the > @@ -82,3 +85,6 @@ Deprecation Notices > * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the > xforms > structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and > ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``. > + > +* metrics: The function ``rte_metrics_init`` will have a non-void return > + in order to notify errors instead of calling ``rte_exit``. > -- > 2.21.0 > > Acked-by: David Marchand -- David Marchand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 7E8FEA0096 for ; Thu, 9 May 2019 09:34:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6BEFB4CA0; Thu, 9 May 2019 09:34:38 +0200 (CEST) Received: from mail-vs1-f68.google.com (mail-vs1-f68.google.com [209.85.217.68]) by dpdk.org (Postfix) with ESMTP id 311A34C93 for ; Thu, 9 May 2019 09:34:37 +0200 (CEST) Received: by mail-vs1-f68.google.com with SMTP id r62so789491vsc.9 for ; Thu, 09 May 2019 00:34:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=PjUrBIL8zvFwCm0YaI6gZ7Bbhb1R8lNdL74OY1xTk8Y=; b=iFai6zyo7FVCey9AwFgGf3cPy4Unnr5R6lc4eQq9ChOJMif9pZQyxVhGrp5C+dBsgV 5aMoK3ZyifS63u6nq+lyKWzkgDEKr5gXlWgBr3wD88HNolIubYLNReUW80f80wiB14Ci imWw9SlpNrMUc1xMiLt2Ty9MIFyOZiE9enge1urRlz+3olaiGBHy5axPPpw5NAkXqgrR YPW+syZcv1B/0RtWofVgqf+C5oOHGyh3m5rhCcoG3kUUdYGyKQ3d1fQE5/yFk1ay2EKq kotuvSOi+GHDdY448fJMoucgIlPDXHZAkbzxuTedm1UqvkGFzX8tB1h35j9O3hNCebX+ BtJw== X-Gm-Message-State: APjAAAXt4TVV+sELq6PDUp/IMnBh9dAaQ8auCxU2KP0KHXhcdEOgGGzS iNQGoCafbsQQHs8KJcnAggmP+RRW+XEdYAUTpY7S2A== X-Google-Smtp-Source: APXvYqyXKdkSmOfAztIKKaX85vrnESsbCJmT5tGcRT9ieMgaRyR9Li/k9uuIQ5dhJEPuSvKrOk+caJHVCD8DthRNrpw= X-Received: by 2002:a67:2781:: with SMTP id n123mr431158vsn.141.1557387271716; Thu, 09 May 2019 00:34:31 -0700 (PDT) MIME-Version: 1.0 References: <20190508205413.31134-1-thomas@monjalon.net> In-Reply-To: <20190508205413.31134-1-thomas@monjalon.net> From: David Marchand Date: Thu, 9 May 2019 09:34:20 +0200 Message-ID: To: Thomas Monjalon Cc: Arnon Warshavsky , Stephen Hemminger , dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190509073420.Sn0kRQXRWkftwCGVH7K0YO4X6co93XlbBQ2BrK0dnMA@z> On Wed, May 8, 2019 at 10:54 PM Thomas Monjalon wrote: > Two public functions from EAL and metrics libraries need to return > some new error codes instead of calling rte_panic or rte_exit. > > Signed-off-by: Thomas Monjalon > --- > doc/guides/rel_notes/deprecation.rst | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst > b/doc/guides/rel_notes/deprecation.rst > index b47c8c254..e61278429 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -20,6 +20,9 @@ Deprecation Notices > * kvargs: The function ``rte_kvargs_process`` will get a new parameter > for returning key match count. It will ease handling of no-match case. > > +* eal: The function ``rte_eal_remote_launch`` will return new error codes > + after read or write error on the pipe, instead of calling ``rte_panic``. > + > Nit: do we need error codes ? or only a single new error code ? * eal: both declaring and identifying devices will be streamlined in > v18.11. > New functions will appear to query a specific port from buses, classes > of > device and device drivers. Device declaration will be made coherent > with the > @@ -82,3 +85,6 @@ Deprecation Notices > * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the > xforms > structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and > ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``. > + > +* metrics: The function ``rte_metrics_init`` will have a non-void return > + in order to notify errors instead of calling ``rte_exit``. > -- > 2.21.0 > > Acked-by: David Marchand -- David Marchand