* [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs
@ 2019-05-08 20:54 Thomas Monjalon
2019-05-08 20:54 ` Thomas Monjalon
` (3 more replies)
0 siblings, 4 replies; 12+ messages in thread
From: Thomas Monjalon @ 2019-05-08 20:54 UTC (permalink / raw)
To: arnon, david.marchand, stephen; +Cc: dev
Two public functions from EAL and metrics libraries need to return
some new error codes instead of calling rte_panic or rte_exit.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index b47c8c254..e61278429 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -20,6 +20,9 @@ Deprecation Notices
* kvargs: The function ``rte_kvargs_process`` will get a new parameter
for returning key match count. It will ease handling of no-match case.
+* eal: The function ``rte_eal_remote_launch`` will return new error codes
+ after read or write error on the pipe, instead of calling ``rte_panic``.
+
* eal: both declaring and identifying devices will be streamlined in v18.11.
New functions will appear to query a specific port from buses, classes of
device and device drivers. Device declaration will be made coherent with the
@@ -82,3 +85,6 @@ Deprecation Notices
* cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
+
+* metrics: The function ``rte_metrics_init`` will have a non-void return
+ in order to notify errors instead of calling ``rte_exit``.
--
2.21.0
^ permalink raw reply [flat|nested] 12+ messages in thread* [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs
2019-05-08 20:54 [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs Thomas Monjalon
@ 2019-05-08 20:54 ` Thomas Monjalon
2019-05-09 5:31 ` Arnon Warshavsky
` (2 subsequent siblings)
3 siblings, 0 replies; 12+ messages in thread
From: Thomas Monjalon @ 2019-05-08 20:54 UTC (permalink / raw)
To: arnon, david.marchand, stephen; +Cc: dev
Two public functions from EAL and metrics libraries need to return
some new error codes instead of calling rte_panic or rte_exit.
Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
---
doc/guides/rel_notes/deprecation.rst | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst
index b47c8c254..e61278429 100644
--- a/doc/guides/rel_notes/deprecation.rst
+++ b/doc/guides/rel_notes/deprecation.rst
@@ -20,6 +20,9 @@ Deprecation Notices
* kvargs: The function ``rte_kvargs_process`` will get a new parameter
for returning key match count. It will ease handling of no-match case.
+* eal: The function ``rte_eal_remote_launch`` will return new error codes
+ after read or write error on the pipe, instead of calling ``rte_panic``.
+
* eal: both declaring and identifying devices will be streamlined in v18.11.
New functions will appear to query a specific port from buses, classes of
device and device drivers. Device declaration will be made coherent with the
@@ -82,3 +85,6 @@ Deprecation Notices
* cryptodev: the ``uint8_t *data`` member of ``key`` structure in the xforms
structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
+
+* metrics: The function ``rte_metrics_init`` will have a non-void return
+ in order to notify errors instead of calling ``rte_exit``.
--
2.21.0
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs
2019-05-08 20:54 [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs Thomas Monjalon
2019-05-08 20:54 ` Thomas Monjalon
@ 2019-05-09 5:31 ` Arnon Warshavsky
2019-05-09 5:31 ` Arnon Warshavsky
2019-05-13 20:54 ` Thomas Monjalon
2019-05-09 7:34 ` David Marchand
2019-05-09 14:55 ` Ferruh Yigit
3 siblings, 2 replies; 12+ messages in thread
From: Arnon Warshavsky @ 2019-05-09 5:31 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: David Marchand, Stephen Hemminger, dev
On Wed, May 8, 2019 at 11:54 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> Two public functions from EAL and metrics libraries need to return
> some new error codes instead of calling rte_panic or rte_exit.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>
> --
> 2.21.0
>
>
Acked-By: Arnon Warshavsky <arnon@qwilt.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs
2019-05-09 5:31 ` Arnon Warshavsky
@ 2019-05-09 5:31 ` Arnon Warshavsky
2019-05-13 20:54 ` Thomas Monjalon
1 sibling, 0 replies; 12+ messages in thread
From: Arnon Warshavsky @ 2019-05-09 5:31 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: David Marchand, Stephen Hemminger, dev
On Wed, May 8, 2019 at 11:54 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> Two public functions from EAL and metrics libraries need to return
> some new error codes instead of calling rte_panic or rte_exit.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
>
> --
> 2.21.0
>
>
Acked-By: Arnon Warshavsky <arnon@qwilt.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs
2019-05-09 5:31 ` Arnon Warshavsky
2019-05-09 5:31 ` Arnon Warshavsky
@ 2019-05-13 20:54 ` Thomas Monjalon
2019-05-13 20:54 ` Thomas Monjalon
1 sibling, 1 reply; 12+ messages in thread
From: Thomas Monjalon @ 2019-05-13 20:54 UTC (permalink / raw)
To: dev; +Cc: Arnon Warshavsky, David Marchand, Stephen Hemminger
09/05/2019 07:31, Arnon Warshavsky:
> On Wed, May 8, 2019 at 11:54 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> > Two public functions from EAL and metrics libraries need to return
> > some new error codes instead of calling rte_panic or rte_exit.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-By: Arnon Warshavsky <arnon@qwilt.com>
Acked-by: David Marchand <david.marchand@redhat.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs
2019-05-13 20:54 ` Thomas Monjalon
@ 2019-05-13 20:54 ` Thomas Monjalon
0 siblings, 0 replies; 12+ messages in thread
From: Thomas Monjalon @ 2019-05-13 20:54 UTC (permalink / raw)
To: dev; +Cc: Arnon Warshavsky, David Marchand, Stephen Hemminger
09/05/2019 07:31, Arnon Warshavsky:
> On Wed, May 8, 2019 at 11:54 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> > Two public functions from EAL and metrics libraries need to return
> > some new error codes instead of calling rte_panic or rte_exit.
> >
> > Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> Acked-By: Arnon Warshavsky <arnon@qwilt.com>
Acked-by: David Marchand <david.marchand@redhat.com>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
Applied
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs
2019-05-08 20:54 [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs Thomas Monjalon
2019-05-08 20:54 ` Thomas Monjalon
2019-05-09 5:31 ` Arnon Warshavsky
@ 2019-05-09 7:34 ` David Marchand
2019-05-09 7:34 ` David Marchand
2019-05-09 7:38 ` Thomas Monjalon
2019-05-09 14:55 ` Ferruh Yigit
3 siblings, 2 replies; 12+ messages in thread
From: David Marchand @ 2019-05-09 7:34 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: Arnon Warshavsky, Stephen Hemminger, dev
On Wed, May 8, 2019 at 10:54 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> Two public functions from EAL and metrics libraries need to return
> some new error codes instead of calling rte_panic or rte_exit.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index b47c8c254..e61278429 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -20,6 +20,9 @@ Deprecation Notices
> * kvargs: The function ``rte_kvargs_process`` will get a new parameter
> for returning key match count. It will ease handling of no-match case.
>
> +* eal: The function ``rte_eal_remote_launch`` will return new error codes
> + after read or write error on the pipe, instead of calling ``rte_panic``.
> +
>
Nit: do we need error codes ? or only a single new error code ?
* eal: both declaring and identifying devices will be streamlined in
> v18.11.
> New functions will appear to query a specific port from buses, classes
> of
> device and device drivers. Device declaration will be made coherent
> with the
> @@ -82,3 +85,6 @@ Deprecation Notices
> * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the
> xforms
> structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
> +
> +* metrics: The function ``rte_metrics_init`` will have a non-void return
> + in order to notify errors instead of calling ``rte_exit``.
> --
> 2.21.0
>
>
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs
2019-05-09 7:34 ` David Marchand
@ 2019-05-09 7:34 ` David Marchand
2019-05-09 7:38 ` Thomas Monjalon
1 sibling, 0 replies; 12+ messages in thread
From: David Marchand @ 2019-05-09 7:34 UTC (permalink / raw)
To: Thomas Monjalon; +Cc: Arnon Warshavsky, Stephen Hemminger, dev
On Wed, May 8, 2019 at 10:54 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> Two public functions from EAL and metrics libraries need to return
> some new error codes instead of calling rte_panic or rte_exit.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
> ---
> doc/guides/rel_notes/deprecation.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/doc/guides/rel_notes/deprecation.rst
> b/doc/guides/rel_notes/deprecation.rst
> index b47c8c254..e61278429 100644
> --- a/doc/guides/rel_notes/deprecation.rst
> +++ b/doc/guides/rel_notes/deprecation.rst
> @@ -20,6 +20,9 @@ Deprecation Notices
> * kvargs: The function ``rte_kvargs_process`` will get a new parameter
> for returning key match count. It will ease handling of no-match case.
>
> +* eal: The function ``rte_eal_remote_launch`` will return new error codes
> + after read or write error on the pipe, instead of calling ``rte_panic``.
> +
>
Nit: do we need error codes ? or only a single new error code ?
* eal: both declaring and identifying devices will be streamlined in
> v18.11.
> New functions will appear to query a specific port from buses, classes
> of
> device and device drivers. Device declaration will be made coherent
> with the
> @@ -82,3 +85,6 @@ Deprecation Notices
> * cryptodev: the ``uint8_t *data`` member of ``key`` structure in the
> xforms
> structure (``rte_crypto_cipher_xform``, ``rte_crypto_auth_xform``, and
> ``rte_crypto_aead_xform``) will be changed to ``const uint8_t *data``.
> +
> +* metrics: The function ``rte_metrics_init`` will have a non-void return
> + in order to notify errors instead of calling ``rte_exit``.
> --
> 2.21.0
>
>
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs
2019-05-09 7:34 ` David Marchand
2019-05-09 7:34 ` David Marchand
@ 2019-05-09 7:38 ` Thomas Monjalon
2019-05-09 7:38 ` Thomas Monjalon
1 sibling, 1 reply; 12+ messages in thread
From: Thomas Monjalon @ 2019-05-09 7:38 UTC (permalink / raw)
To: David Marchand; +Cc: Arnon Warshavsky, Stephen Hemminger, dev
09/05/2019 09:34, David Marchand:
> On Wed, May 8, 2019 at 10:54 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > +* eal: The function ``rte_eal_remote_launch`` will return new error codes
> > + after read or write error on the pipe, instead of calling ``rte_panic``.
> > +
> >
>
> Nit: do we need error codes ? or only a single new error code ?
That's something to discuss.
In my opinion, we should return any errno from read and write syscalls:
return -errno;
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs
2019-05-09 7:38 ` Thomas Monjalon
@ 2019-05-09 7:38 ` Thomas Monjalon
0 siblings, 0 replies; 12+ messages in thread
From: Thomas Monjalon @ 2019-05-09 7:38 UTC (permalink / raw)
To: David Marchand; +Cc: Arnon Warshavsky, Stephen Hemminger, dev
09/05/2019 09:34, David Marchand:
> On Wed, May 8, 2019 at 10:54 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > --- a/doc/guides/rel_notes/deprecation.rst
> > +++ b/doc/guides/rel_notes/deprecation.rst
> > +* eal: The function ``rte_eal_remote_launch`` will return new error codes
> > + after read or write error on the pipe, instead of calling ``rte_panic``.
> > +
> >
>
> Nit: do we need error codes ? or only a single new error code ?
That's something to discuss.
In my opinion, we should return any errno from read and write syscalls:
return -errno;
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs
2019-05-08 20:54 [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs Thomas Monjalon
` (2 preceding siblings ...)
2019-05-09 7:34 ` David Marchand
@ 2019-05-09 14:55 ` Ferruh Yigit
2019-05-09 14:55 ` Ferruh Yigit
3 siblings, 1 reply; 12+ messages in thread
From: Ferruh Yigit @ 2019-05-09 14:55 UTC (permalink / raw)
To: Thomas Monjalon, arnon, david.marchand, stephen; +Cc: dev
On 5/8/2019 9:54 PM, Thomas Monjalon wrote:
> Two public functions from EAL and metrics libraries need to return
> some new error codes instead of calling rte_panic or rte_exit.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 12+ messages in thread* Re: [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs
2019-05-09 14:55 ` Ferruh Yigit
@ 2019-05-09 14:55 ` Ferruh Yigit
0 siblings, 0 replies; 12+ messages in thread
From: Ferruh Yigit @ 2019-05-09 14:55 UTC (permalink / raw)
To: Thomas Monjalon, arnon, david.marchand, stephen; +Cc: dev
On 5/8/2019 9:54 PM, Thomas Monjalon wrote:
> Two public functions from EAL and metrics libraries need to return
> some new error codes instead of calling rte_panic or rte_exit.
>
> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2019-05-13 20:54 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-08 20:54 [dpdk-dev] [PATCH] doc: announce API change to remove exit calls in libs Thomas Monjalon
2019-05-08 20:54 ` Thomas Monjalon
2019-05-09 5:31 ` Arnon Warshavsky
2019-05-09 5:31 ` Arnon Warshavsky
2019-05-13 20:54 ` Thomas Monjalon
2019-05-13 20:54 ` Thomas Monjalon
2019-05-09 7:34 ` David Marchand
2019-05-09 7:34 ` David Marchand
2019-05-09 7:38 ` Thomas Monjalon
2019-05-09 7:38 ` Thomas Monjalon
2019-05-09 14:55 ` Ferruh Yigit
2019-05-09 14:55 ` Ferruh Yigit
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).