From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E03CD45BBE; Thu, 24 Oct 2024 09:55:50 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D0B71433AA; Thu, 24 Oct 2024 09:55:50 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id BFE324339A for ; Thu, 24 Oct 2024 09:55:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729756544; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SHCSABn+ETwiUmX9A673zYYMmxvSw1WaguxJEkb07go=; b=JBp5OX1+2494RS8yNSk0mkdRmL5HMLjk25dFsMBGlrFFEK0ATVgyayybAy/FOn7hxZo9of IEO2lnzTyxj/lmmshrxorpOVmiET4pTevXI3qL4rn11YjdmjaTS1P1k+RTiykdQ5DWuL3C SUlz3XiplN2ydQgM7Cb7EJ9Z969kQ7A= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-169-sXcjlwxZMNiTL7uEx0p8Ig-1; Thu, 24 Oct 2024 03:55:43 -0400 X-MC-Unique: sXcjlwxZMNiTL7uEx0p8Ig-1 Received: by mail-lf1-f70.google.com with SMTP id 2adb3069b0e04-539f7d8bffbso958814e87.0 for ; Thu, 24 Oct 2024 00:55:42 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729756541; x=1730361341; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SHCSABn+ETwiUmX9A673zYYMmxvSw1WaguxJEkb07go=; b=opD/aQpdnJdteeL41jLD/lsqnj2BSrwS03eRtzQkeOAePqLHwgBVsgLuiHr2aECcST hhFOFBMzLTXg1WzsaHzYGyIJQNexowWLJ3vEi0UacEBwdLDQTKkizwmaWEYHXNCuzK/i 1pBlJ+S2misyM2UU8wCQ/OkYzJbdjdbHaApuYfLyWh5KeUk1vCvIcHqA9sMxJseG+LVg V5+Vy5519N8K+BHdBG5dTTpw22gNky91AKX65IXf8LLkZdghZr7NwSde3tVK1RrjfH1j NsQCN9dPGgsFX26yJ2o6QiwR9Qp2Ha8OMKBRwltt6DQNeikLeTufl864tiq+KSAhEAtf oPzg== X-Gm-Message-State: AOJu0YwNT/pJrO/7jMowkVKOsuuTTc7t5m0Sf5Aq4G3Isfca8c9Ndu+q t6uHyeStJASHlYDpnEhFFAB6zmM3Z9OsYIcwJGEmQ/2a5TLen91p6I52BdrgmVhEVmE7d4li509 pbFHM8ODEvrS8kmURW4S3mc7uNg6hhLOmh42UfeXjy5EY5mF42xyWioFvv4ETY1/D8xPl6kWgsO mShbHf/RmpkpwZ+C8= X-Received: by 2002:a05:6512:1285:b0:539:edc9:7400 with SMTP id 2adb3069b0e04-53b23752333mr372655e87.20.1729756541617; Thu, 24 Oct 2024 00:55:41 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE/ti6NQUD351PclmSxlC7dXP8F0IfxKSYEwiVtRO8ucFOzqmygmhZzXmikw7gO9cqdThuX1PlFADRj6mfu8rk= X-Received: by 2002:a05:6512:1285:b0:539:edc9:7400 with SMTP id 2adb3069b0e04-53b23752333mr372642e87.20.1729756541266; Thu, 24 Oct 2024 00:55:41 -0700 (PDT) MIME-Version: 1.0 References: <20241023151552.2863387-1-maxime.coquelin@redhat.com> <20241023151552.2863387-5-maxime.coquelin@redhat.com> <712b60db-8cc8-4aee-b869-550e264959c6@redhat.com> In-Reply-To: <712b60db-8cc8-4aee-b869-550e264959c6@redhat.com> From: David Marchand Date: Thu, 24 Oct 2024 09:55:29 +0200 Message-ID: Subject: Re: [PATCH 4/6] vhost: refactor VDUSE reconnection log mapping To: Maxime Coquelin Cc: dev@dpdk.org, chenbox@nvidia.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Oct 23, 2024 at 9:04=E2=80=AFPM Maxime Coquelin wrote: > >> +static int > >> +vduse_reconnect_log_map(const char *dev_name, struct vhost_reconnect_= data **reco_log, bool create) > > > > You can pass struct virtio_net *dev instead of patch 6. > > At patch 4, the struct virtio_net *dev has not yet been allocated when > this function is called. Ah yes, I missed this point. > > Or, maybe you mean I should squash patch 6 with this one? No keep it as is, moving patches or squashing does not improve the diff. --=20 David Marchand