From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D681D41E9D; Wed, 15 Mar 2023 10:47:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C118B40A7A; Wed, 15 Mar 2023 10:47:03 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 106E540141 for ; Wed, 15 Mar 2023 10:47:01 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678873621; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dEa3iNKlP8kgcSHec08o+dBpVEk0jtl/0hFBCZIZ1wE=; b=SK2RRgyfckPb2sUZv9SU3FMs6sPcrp7IIGvfHCGywX46z54144uC/aVR6dNTL1xOcKRP1i Oh6y1B0x+2WhgrezaPlLnDkFFKjfA5hjFhMabLK7SwFA6vdS3nFWwl2zpBRYv1SvvipBTW cT7SRtkyyQThjW+AsArkBzmGJS+jeu4= Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-381-vzHLA8vAN7OPv6zkSzRu4A-1; Wed, 15 Mar 2023 05:47:00 -0400 X-MC-Unique: vzHLA8vAN7OPv6zkSzRu4A-1 Received: by mail-pl1-f197.google.com with SMTP id n4-20020a170902f60400b0019f287674d3so6548123plg.1 for ; Wed, 15 Mar 2023 02:47:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678873619; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dEa3iNKlP8kgcSHec08o+dBpVEk0jtl/0hFBCZIZ1wE=; b=d3XxOC/Dp/Tbxp9m2MoZMsg73TaYuaC9QMXcpyvm0av+zl3+yDVBexFRqJw+SEUb9D CQqrrTcPvs4ScuoaOztzl5d4iNcSMy9AeeG/H4CUhDJ34YBuZlMrpaGFgx0FyoWPQvs8 XKmoDqoTxXVWEtuJrfpr/0I12BKf08rwvZJ+87Ydk178iMbcNQmMJZvjaRUrKkRPqE2O eLAY9MPOzVvwXwdGJweSwTdSFY/V2RNvMTiRzts/MQ4D4aLC2MyiTP7WFGZi29Q8+1Ui Koo3ET3SWON1WR2FqdLlAyN4phezZu4wM23c834Ep8UghGcb2Oa5Z5oy1ghF9RwJYtew LEsw== X-Gm-Message-State: AO0yUKUufuVU44MpFkKqseyuOJIgQ/5+mNIsszrOlW/6pARc0YVqUp3f kU5A0IL6a3Marzu4d6Z3YcstkSnuhRk1ERG3gKlhAKsmiRE45cdKEG685uCIj5+zIaopcDJwsIZ 58JHjPB3Gx4feOQoxyOf0uClVYf0ZJA== X-Received: by 2002:a17:90a:88a:b0:23d:ef4:513b with SMTP id v10-20020a17090a088a00b0023d0ef4513bmr3378875pjc.8.1678873619175; Wed, 15 Mar 2023 02:46:59 -0700 (PDT) X-Google-Smtp-Source: AK7set9k7dGVDt77Stz0VVg9nkJipVXBBvBH4DajEo4VaLpou2gBy14+J95hS0uLl2L8yoGH/JwAAi6OeQqf3w6jEp8= X-Received: by 2002:a17:90a:88a:b0:23d:ef4:513b with SMTP id v10-20020a17090a088a00b0023d0ef4513bmr3378848pjc.8.1678873618685; Wed, 15 Mar 2023 02:46:58 -0700 (PDT) MIME-Version: 1.0 References: <20230313171905.67720-1-stephen@networkplumber.org> <20230314173648.69528-1-stephen@networkplumber.org> <20230314154023.557ac6f4@hermes.local> In-Reply-To: <20230314154023.557ac6f4@hermes.local> From: David Marchand Date: Wed, 15 Mar 2023 10:46:47 +0100 Message-ID: Subject: Re: [PATCH v3 0/3] testpmd control C fixes To: Stephen Hemminger Cc: dev@dpdk.org, Thomas Monjalon X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Mar 14, 2023 at 11:40=E2=80=AFPM Stephen Hemminger wrote: > > On Tue, 14 Mar 2023 10:36:45 -0700 > Stephen Hemminger wrote: > > > Resolve issues around using control-C in testpmd. > > Using cmdline_poll() is broken and won't work right so > > don't use it. Instead use cmdline_interact() and fix > > the signal handling. > > > > Stephen Hemminger (3): > > testpmd: go back to using cmdline_interact > > testpmd: use sig_atomic_t for flag > > testpmd: enable interrupt in interactive mode > > > > app/test-pmd/cmdline.c | 27 ++++++++++++++------------- > > app/test-pmd/testpmd.c | 17 ++++++++++++----- > > app/test-pmd/testpmd.h | 3 ++- > > lib/cmdline/cmdline.h | 10 ++++++++++ > > lib/cmdline/cmdline_os_unix.c | 8 +++++++- > > lib/cmdline/cmdline_os_windows.c | 18 ++++++++++++++++-- > > lib/cmdline/cmdline_private.h | 2 +- > > lib/cmdline/version.map | 3 +++ > > 8 files changed, 65 insertions(+), 23 deletions(-) > > > > This patch is failing the CI tests from something that seems unrelated. > Looks like recent cyrptodev or ixgbe change broke something. There was no recent change in ixgbe. The build issue is due to added inclusion of signal.h in testpmd.h in patch= 2. root@eb72fb63faec:~/dpdk# git stash Saved working directory and index state WIP on main: baf13c3135 version: 23.03-rc2 root@eb72fb63faec:~/dpdk# ninja -C build-mini-aarch64 ninja: Entering directory `build-mini-aarch64' [104/104] Linking target app/dpdk-testpmd. root@eb72fb63faec:~/dpdk# git stash pop On branch main Your branch is up to date with 'origin/main'. Changes not staged for commit: (use "git add ..." to update what will be committed) (use "git restore ..." to discard changes in working directory) modified: app/test-pmd/testpmd.h no changes added to commit (use "git add" and/or "git commit -a") Dropped refs/stash@{0} (71b7fa29df19c6e8c553ca53e62cf89d1ef1ea97) root@eb72fb63faec:~/dpdk# git diff diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h index bdfbfd36d3..ada1d7b438 100644 --- a/app/test-pmd/testpmd.h +++ b/app/test-pmd/testpmd.h @@ -6,6 +6,7 @@ #define _TESTPMD_H_ #include +#include #ifdef RTE_LIB_GRO #include root@eb72fb63faec:~/dpdk# ninja -C build-mini-aarch64 ninja: Entering directory `build-mini-aarch64' [24/25] Compiling C object 'app/a172ced@@dpdk-testpmd@exe/.._drivers_net_ixgbe_ixgbe_testpmd.c.o'. FAILED: app/a172ced@@dpdk-testpmd@exe/.._drivers_net_ixgbe_ixgbe_testpmd.c.= o ccache aarch64-linux-gnu-gcc -Iapp/a172ced@@dpdk-testpmd@exe -Iapp -I../app -Iapp/test-pmd -I../app/test-pmd -Ilib/ethdev -I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/arm/include -I../lib/eal/arm/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Ilib/cmdline -I../lib/cmdline -Ilib/bitratestats -I../lib/bitratestats -Ilib/metrics -I../lib/metrics -Ilib/bpf -I../lib/bpf -Ilib/gro -I../lib/gro -Ilib/gso -I../lib/gso -Ilib/latencystats -I../lib/latencystats -Ilib/pdump -I../lib/pdump -Ilib/pcapng -I../lib/pcapng -Idrivers/net/ixgbe -I../drivers/net/ixgbe -Idrivers/net/ixgbe/base -I../drivers/net/ixgbe/base -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -Ilib/hash -I../lib/hash -Ilib/rcu -I../lib/rcu -Ilib/security -I../lib/security -Ilib/cryptodev -I../lib/cryptodev -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Wextra -O3 -include rte_config.h -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-address-of-packed-member -Wno-packed-not-aligned -Wno-missing-field-initializers -D_GNU_SOURCE -march=3Darmv8-a+crc -moutline-atomics -DALLOW_EXPERIMENTAL_API -Wno-deprecated-declarations -MD -MQ 'app/a172ced@@dpdk-testpmd@exe/.._drivers_net_ixgbe_ixgbe_testpmd.c.o' -MF 'app/a172ced@@dpdk-testpmd@exe/.._drivers_net_ixgbe_ixgbe_testpmd.c.o.d= ' -o 'app/a172ced@@dpdk-testpmd@exe/.._drivers_net_ixgbe_ixgbe_testpmd.c.o' -c ../drivers/net/ixgbe/ixgbe_testpmd.c In file included from ../drivers/net/ixgbe/ixgbe_ethdev.h:11, from ../drivers/net/ixgbe/ixgbe_testpmd.c:9: ../drivers/net/ixgbe/base/ixgbe_type.h:2945:17: error: conflicting types for 'u64' 2945 | #define __le64 u64 | ^~~ In file included from ../drivers/net/ixgbe/base/ixgbe_type.h:46, from ../drivers/net/ixgbe/ixgbe_ethdev.h:11, from ../drivers/net/ixgbe/ixgbe_testpmd.c:9: ../drivers/net/ixgbe/base/ixgbe_osdep.h:94:18: note: previous declaration of 'u64' was here 94 | typedef uint64_t u64; | ^~~ ninja: build stopped: subcommand failed. --=20 David Marchand