From: David Marchand <david.marchand@redhat.com>
To: Harry van Haaren <harry.van.haaren@intel.com>
Cc: dev <dev@dpdk.org>, Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [dpdk-dev] [PATCH v2] service: print errors to rte log
Date: Tue, 15 Oct 2019 20:40:07 +0200 [thread overview]
Message-ID: <CAJFAV8zOry_JBdekfg-3YM73gG0s9i1iUA14qdX9REcpBbAc7w@mail.gmail.com> (raw)
In-Reply-To: <20190821091252.39705-1-harry.van.haaren@intel.com>
On Wed, Aug 21, 2019 at 11:11 AM Harry van Haaren
<harry.van.haaren@intel.com> wrote:
>
> From: Stephen Hemminger <stephen@networkplumber.org>
>
> EAL should always use rte_log instead of putting errors to
> stderr (which maybe redirected to /dev/null in a daemon).
>
> Also checks for null before rte_free are unnecessary.
> Minor code consistency improvements.
Fixes: 21698354c832 ("service: introduce service cores concept")
Cc: stable@dpdk.org
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Signed-off-by: Harry van Haaren <harry.van.haaren@intel.com>
> Acked-by: Harry van Haaren <harry.van.haaren@intel.com>
Applied, thanks.
--
David Marchand
prev parent reply other threads:[~2019-10-15 18:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-20 23:32 [dpdk-dev] [PATCH] " Stephen Hemminger
2019-08-21 8:58 ` Van Haaren, Harry
2019-08-21 9:12 ` [dpdk-dev] [PATCH v2] " Harry van Haaren
2019-10-15 18:40 ` David Marchand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8zOry_JBdekfg-3YM73gG0s9i1iUA14qdX9REcpBbAc7w@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=harry.van.haaren@intel.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).