From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65A11A2EFC for ; Tue, 15 Oct 2019 20:40:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 34D041ED5D; Tue, 15 Oct 2019 20:40:25 +0200 (CEST) Received: from us-smtp-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.120]) by dpdk.org (Postfix) with ESMTP id 812221ED4D for ; Tue, 15 Oct 2019 20:40:23 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1571164823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FVZ30t20PrEtKHL74T2L68Pf7gn2czZ/6uAV0SgNw1w=; b=Ko4lkAyFfbr+bxSQCZfS6nIKv9ox8gJMlNKT6ZeSUVybZD3SPdry6NCEYz95VIY8ldnPNb VaSLtznPaZw7cyvQa0wcQiVmNhJ/v+LU8DLvHnR85U7zrEfdF5D/lzVUQC58cE9QFE5Qnc XObtilyHqJ1ysLW5cp833mf1IP8kzOI= Received: from mail-vk1-f200.google.com (mail-vk1-f200.google.com [209.85.221.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-206-APUM9hpOPdGi_Zh5jeEpwQ-1; Tue, 15 Oct 2019 14:40:19 -0400 Received: by mail-vk1-f200.google.com with SMTP id o66so8614368vka.19 for ; Tue, 15 Oct 2019 11:40:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tt+g41LOuFF5/olcgf9TTQJ1FtfIW5DcAwwWkS2dnyk=; b=mRppEolg1irLV3RYwciA+w3nfkGSX/aWbzaSyqVye4WML65vTOL6EpyJ8T8rQaV9jJ 0L9p3LOe+/Q30Tdy1v8CzvCOE42sts6Yi+JJKc/fFkxnib8ZH/9TH9dTOw7p7JV/gs5I Ic/QOGft3erl0die8uSVd/JJFYqQlB6ZChPcj2yiVS7m7EOdY+zlT4X8SZQyDN/qxQwv dJh1j/idT/+rvBSQArGvM4Ltg2kLV89fccvc1yJTugR5oOtp1neEzUIur/wod2hbRbsg K9GWyrFnkbAZ7VUFnDabupGDJ5Gxdtydipr8Sy6u9UAttUFlwmm7nBIlaZ9Rd4NuJ/5C LHEg== X-Gm-Message-State: APjAAAWVsZ4nBJv6nBuAYsQRIXGeySESNvXYgeKss8/eiBheORBuMfmT AuTCm5jdnrRgppteI/rHYwHyZPx4ZLl5GC0oDGDzwN5MttUTz56hry9553JR8hJ+WBUv0uajSff b+GXMrA26JG4LD83Ylck= X-Received: by 2002:a1f:3811:: with SMTP id f17mr19107394vka.56.1571164818748; Tue, 15 Oct 2019 11:40:18 -0700 (PDT) X-Google-Smtp-Source: APXvYqxSiOhEcVGRINDvV6SXdcgDnjx4GbXHKY5PVtDMmws2tkKyeZibydZcSOt8DoWqgU7/3o9+uoDJOIYjVW9DpBI= X-Received: by 2002:a1f:3811:: with SMTP id f17mr19107375vka.56.1571164818467; Tue, 15 Oct 2019 11:40:18 -0700 (PDT) MIME-Version: 1.0 References: <20190820233256.27405-1-stephen@networkplumber.org> <20190821091252.39705-1-harry.van.haaren@intel.com> In-Reply-To: <20190821091252.39705-1-harry.van.haaren@intel.com> From: David Marchand Date: Tue, 15 Oct 2019 20:40:07 +0200 Message-ID: To: Harry van Haaren Cc: dev , Stephen Hemminger X-MC-Unique: APUM9hpOPdGi_Zh5jeEpwQ-1 X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] service: print errors to rte log X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 21, 2019 at 11:11 AM Harry van Haaren wrote: > > From: Stephen Hemminger > > EAL should always use rte_log instead of putting errors to > stderr (which maybe redirected to /dev/null in a daemon). > > Also checks for null before rte_free are unnecessary. > Minor code consistency improvements. Fixes: 21698354c832 ("service: introduce service cores concept") Cc: stable@dpdk.org > > Signed-off-by: Stephen Hemminger > Signed-off-by: Harry van Haaren > Acked-by: Harry van Haaren Applied, thanks. --=20 David Marchand