From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7A609A04DB; Fri, 16 Oct 2020 17:48:05 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5EDFC1EFF6; Fri, 16 Oct 2020 17:48:04 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 14E4F1EFF5 for ; Fri, 16 Oct 2020 17:48:01 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602863280; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=2ybaTZ2qOboUfyM0GZrW4n5WpzhiLme5cIBNiLW2hKI=; b=gwMuvXBj/JT2ek2sojy+Lxb2+MTkDOycCQl4EFvnIYPeIlM6W4O6ev2cv90S+kZ3cl5DNL NsBNIFgG2RPyQQGMCej9UYN6XtKpfWFdV7cwsFJQWxzAsztFsTJWpBc2xYNJyLisLvMu2u V+0TxTmQTw/wRzXtrwSETalAGZv1H8Q= Received: from mail-vs1-f70.google.com (mail-vs1-f70.google.com [209.85.217.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-108-mHI4xAsaOFCsevDK8IfTWw-1; Fri, 16 Oct 2020 11:47:58 -0400 X-MC-Unique: mHI4xAsaOFCsevDK8IfTWw-1 Received: by mail-vs1-f70.google.com with SMTP id 7so438515vsu.23 for ; Fri, 16 Oct 2020 08:47:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2ybaTZ2qOboUfyM0GZrW4n5WpzhiLme5cIBNiLW2hKI=; b=b0XlNLF7T4XiogRt3UlgeGhFwFBzQdyZGn+HITxh8nrpvKPa/4N3LOs9OFi290but9 FXoSl14f1g/2/I2ktWzr43h3/8+lIwmCHZUZrYfokvXi8ZD1+09ErocV2BdHvSt61axi y9sTGpzakR9p5fEw+74o4oqZyQ7A/WJhDh5OcusOfePvpRN1uyo+ty/aH3fTUq99xp4G IwbY7gsidU1tl03Jdo4AwBEUvrlDgPHXqenNEptKVdnpiitukCG6cANUXnkEZRDSiqOw yi1ZCmhNUaPFmphIFTCcVvNPUggk5jiKb6FjIzYAHDaIOc0tsJBAx86loyEQPiZXlHSG xPow== X-Gm-Message-State: AOAM533G5q5JwWAFB7vUyY4vn2BVklFq+g+wFBDIZDGv3Re4xN9u3HYY ETsV8HA4RCmkf4gIhARdyJ+hQa6vS3rygEie5CrlNI0oz1N40qDS+3+GJiglWuseC4IZSAizuwN QrFpQHApP0e6A+4FZPLk= X-Received: by 2002:ab0:7313:: with SMTP id v19mr2215298uao.87.1602863277917; Fri, 16 Oct 2020 08:47:57 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzTT6tA6ttiEPrHVp2IodMbyzjJdi/raRffNh1ItIwhdl4piNaOE6wGJDU2dyrPOa12vCR/ndIp+cEay1Nj63Y= X-Received: by 2002:ab0:7313:: with SMTP id v19mr2215282uao.87.1602863277619; Fri, 16 Oct 2020 08:47:57 -0700 (PDT) MIME-Version: 1.0 References: <20200825114447.135030-1-bruce.richardson@intel.com> <20200903144942.671870-1-bruce.richardson@intel.com> In-Reply-To: <20200903144942.671870-1-bruce.richardson@intel.com> From: David Marchand Date: Fri, 16 Oct 2020 17:47:45 +0200 Message-ID: To: Bruce Richardson Cc: dev , Ma Lihong , Hemant Agrawal Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 0/3] Allow overriding of build-time constants X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hello Bruce, On Thu, Sep 3, 2020 at 4:50 PM Bruce Richardson wrote: > > A number of the more advanced DPDK build settings which are not expected to > be user modified are stored in config/rte_config.h. In some cases, for a > custom build a user may want to override those settings via CFLAGS, so we > need to ensure that the definitions do not override the user-provided > values. > > Bruce Richardson (3): > config: remove explicit undefinition of unset values > config: allow overriding some build defaults > doc: add notes on overriding extra config values $ CFLAGS="-DRTE_MAX_MEMSEG_LISTS=64" meson setup --default-library=shared --buildtype=debugoptimized -Dprefix=/home/dmarchan/git/pub/dpdk.org/build/install build $ ninja-build -C build -j4 install librte_eal.so is indeed built with the 64 value: $ pahole -C rte_mem_config build/install/lib64/librte_eal.so |grep memsegs die__process_function: tag not supported (INVALID)! struct rte_memseg_list memsegs[64]; /* 136 8704 */ But no trace of the custom value for external applications: $ grep -r RTE_MAX_MEMSEG_LISTS build/install build/install/include/rte_config.h:#ifndef RTE_MAX_MEMSEG_LISTS build/install/include/rte_config.h:#define RTE_MAX_MEMSEG_LISTS 128 Binary file build/install/lib64/librte_eal.a matches Binary file build/install/lib64/librte_eal.so.21.0 matches I can see the same using the meson option -Dc_args. -- David Marchand