From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8B16EA00E6 for ; Wed, 7 Aug 2019 10:41:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6D52737A8; Wed, 7 Aug 2019 10:41:20 +0200 (CEST) Received: from mail-ua1-f66.google.com (mail-ua1-f66.google.com [209.85.222.66]) by dpdk.org (Postfix) with ESMTP id 652603253 for ; Wed, 7 Aug 2019 10:41:19 +0200 (CEST) Received: by mail-ua1-f66.google.com with SMTP id 8so34719408uaz.11 for ; Wed, 07 Aug 2019 01:41:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=KXz1pFA/aLa2REgvXg17vrIQNb3nyOe7hNy3/BnDlUo=; b=jAJXdFPOfDQiXoyOZmuPzAIcW/m8OxJ+5rKXeis6FICK9TmVhu/EYDmVRVlJSvtpwG 3b4j6nXzpovqXhqk/3dto+7qt6yjxq3+2Z//MszGedpJ34Jf+63+AbJQU68efMlUTzO4 hZ6She4N2mFifao4zF4J3AeWOabISeruy8oT4sqvOVswAj/bg3v/Oj830DD7lrqpFPmz GPnx9jN3rHNaRoKYVn0RcEHTcjHUoDl5Dp980uMHrDZIKEMyzJS5Q06R/Cp2rYrh7lil 5fVcVBSG3WxpeuJS2g18cjTrRS+CGHx1xyjnEWWyRmdCx+SuAJHfZINv3jFbu2ILDKFP CGGA== X-Gm-Message-State: APjAAAVqeypY059lc44/d8qf+AQjl8XdojSbQOuTqatqHNL1y0pWrmZX 3iQxmfcY7W07VMsXy7XIvcUphk6J/HIobuSmOCF5YQ== X-Google-Smtp-Source: APXvYqy8NBOQeigDhEo7Q7EcZxgFAEfvB6O5kvLY5A02xelBf304+8fhxiJnOzjj7sh5fYEgTXmvqAJeDxpgdyK/fA0= X-Received: by 2002:ab0:45e3:: with SMTP id u90mr5162598uau.126.1565167278733; Wed, 07 Aug 2019 01:41:18 -0700 (PDT) MIME-Version: 1.0 References: <1565164045-27992-1-git-send-email-zhang.congwen@zte.com.cn> In-Reply-To: <1565164045-27992-1-git-send-email-zhang.congwen@zte.com.cn> From: David Marchand Date: Wed, 7 Aug 2019 10:41:07 +0200 Message-ID: To: Congwen Zhang Cc: Wenzhuo Lu , "Ananyev, Konstantin" , dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/ixgbe: fix rss_conf sizeof argument X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 7, 2019 at 10:28 AM Congwen Zhang wrote: > > The type of rss_conf is struct ixgbe_rte_flow_rss_conf *, > not struct rte_eth_rss_conf *. What is the actual issue? Does it deserve a Fixes: tag? > > Signed-off-by: Congwen Zhang > --- > drivers/net/ixgbe/ixgbe_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ixgbe/ixgbe_flow.c b/drivers/net/ixgbe/ixgbe_flow.c > index 92377b8..b2a2bfc 100644 > --- a/drivers/net/ixgbe/ixgbe_flow.c > +++ b/drivers/net/ixgbe/ixgbe_flow.c > @@ -2874,7 +2874,7 @@ static inline uint8_t signature_match(const struct rte_flow_item pattern[]) > /* check if the next not void item is END */ > act = next_no_void_action(actions, act); > if (act->type != RTE_FLOW_ACTION_TYPE_END) { > - memset(rss_conf, 0, sizeof(struct rte_eth_rss_conf)); > + memset(rss_conf, 0, sizeof(struct ixgbe_rte_flow_rss_conf)); Not sure what the maintainer prefers, but I would go with: + memset(rss_conf, 0, sizeof(*rss_conf)); > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > act, "Not supported action."); > -- > 1.8.3.1 > -- David Marchand