From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6DF9342C6F; Fri, 9 Jun 2023 16:37:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 446FF42D8F; Fri, 9 Jun 2023 16:37:02 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id E110340EDB for ; Fri, 9 Jun 2023 16:37:00 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1686321420; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=29Yb4CR0jV1b3C3LdJ4o/3rt683fj+YQGYGrc/b+Iuk=; b=jCr9qaXVZUV00DSIyrQlfKRCL0YfpUCXsowl6kDFGc6KwHKVNJ33Vf4Qu32iPrVWGZKxtf tm0QckJsXXHdS5KCE6h3TCLu7Kan3rRKR8DDC04Ar+BdXcwEeZ1/e/NWYkSX3nsBjoPaTn pdEpGlsR3QcbTZR7jCuVLGTGTsndCN8= Received: from mail-il1-f199.google.com (mail-il1-f199.google.com [209.85.166.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-119-1SGINp_yN96XWeWB42TVuA-1; Fri, 09 Jun 2023 10:36:59 -0400 X-MC-Unique: 1SGINp_yN96XWeWB42TVuA-1 Received: by mail-il1-f199.google.com with SMTP id e9e14a558f8ab-33bf805e901so17914495ab.2 for ; Fri, 09 Jun 2023 07:36:58 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686321418; x=1688913418; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=29Yb4CR0jV1b3C3LdJ4o/3rt683fj+YQGYGrc/b+Iuk=; b=f85ROXG/pCxYH/0aRTtTQY2ZwhUxLhdzKc5mS3D6WOIWp29i7FRlGUYlPisaYGRSZv g5Tjx2fm83zuOluIQAiSV4j0pjxAs8W57wmfEzSebJm6fvxeuEpN46HxfFQzLjzHg2/H ChVb9xfQfjbdMIJ6RP1sxQCMacuLpf6wiJcZc4Grqkudu183Apj9ogWCOyVPpE/04cm6 pODkyszj22+hHJK6C7/ippWBY9SVgzes+B/k8PcsVkK++7y5o4wUGbunicTXhwxn0F8D BryNeyHsIaFGUmdhh756O/TdxzeWCqvJ2SBc9zfWNQ7siTXMEHbQG9tE7zp3bFHUr6/A BiWg== X-Gm-Message-State: AC+VfDyADGwltOaM5f+QO/x9l1PjyY4K6HEuS704LckvtghhEwzCMASy 67qk4AFj765rayZsUQMuD4loaBQlZbcTj5zPZR2UAAYaY8Jh/uK20BEwUfg4wvyFQMmyS6qsoYs wfPLjB5Cc8RHBl0OFMXU= X-Received: by 2002:a05:6e02:5c5:b0:33d:59d9:7de7 with SMTP id l5-20020a056e0205c500b0033d59d97de7mr1752420ils.12.1686321418339; Fri, 09 Jun 2023 07:36:58 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ59dBmuIL+KjfI8ZwB6Cg+lBIkvvjaWbeA6yfWwEYnSEe+BQ/udm1FFT60KY1vYFb8Y6e9Ge5VBdkGZEHZjTnI= X-Received: by 2002:a05:6e02:5c5:b0:33d:59d9:7de7 with SMTP id l5-20020a056e0205c500b0033d59d97de7mr1752409ils.12.1686321418149; Fri, 09 Jun 2023 07:36:58 -0700 (PDT) MIME-Version: 1.0 References: <20230608095759.1800617-1-zhirun.yan@intel.com> <20230608151844.1823783-1-zhirun.yan@intel.com> In-Reply-To: From: David Marchand Date: Fri, 9 Jun 2023 16:36:45 +0200 Message-ID: Subject: Re: [PATCH v11 00/16] graph enhancement for multi-core dispatch To: Jerin Jacob Cc: Zhirun Yan , Thomas Monjalon , dev@dpdk.org, jerinj@marvell.com, kirankumark@marvell.com, ndabilpuram@marvell.com, stephen@networkplumber.org, pbhagavatula@marvell.com, cunming.liang@intel.com, haiyue.wang@intel.com, mattias.ronnblom@ericsson.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jun 9, 2023 at 3:39=E2=80=AFPM David Marchand wrote: > > On Thu, Jun 8, 2023 at 5:31=E2=80=AFPM Jerin Jacob wrote: > > On Thu, Jun 8, 2023 at 8:55=E2=80=AFPM Zhirun Yan wrote: > > > > > > V11: > > > Update comments and fix to add experimental flags for rte_graph_model= _is_valid() in patch 04. > > > Update added symbols in alphabetical order in version.map with patch = 04,05,06,08,10. > > > Update commit message in patch 16. > > > > + @Thomas Monjalon This patch series looks good from my PoV to merge > > this in rc1. If you don't find any issue, please consider merging in > > this rc1. > > Compilation is broken at patch 1 because of the file rename... > I hope I won't find anything else broken. Afaics, header exports are incorrect. I did not look further. About headers exports: if a public header (declared in headers meson var) includes sub_headerA,B,C, those sub headers must be listed either in headers or indirect_headers meson variables. Otherwise those sub headers won't be distributed for external applications consumption. For checking, I recommend running: git rebase -i origin/main -x 'DPDK_ABI_REF_VERSION=3Dv23.03 DPDK_BUILD_TEST_EXAMPLES=3Dall DPDK_BUILD_TEST_DIR=3D$HOME/builds/main ./devtools/test-meson-builds.sh' If we don't get fixes soon, this series will have to wait rc2 (or next rele= ase). --=20 David Marchand