[dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

[dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

[Xiaoyun Li]

Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API
that was introduced in 18.11 and have been around for 11 releases.

Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
 lib/ethdev/rte_ethdev.h | 4 ----
 lib/ethdev/version.map  | 2 +-
 2 files changed, 1 insertion(+), 5 deletions(-)

diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index d2b27c351f..2ccd651490 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -3647,9 +3647,6 @@ int rte_eth_dev_rx_intr_ctl_q(uint16_t port_id, uint16_t queue_id,
 			      int epfd, int op, void *data);
 
 /**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
  * Get interrupt fd per Rx queue.
  *
  * @param port_id
@@ -3663,7 +3660,6 @@ int rte_eth_dev_rx_intr_ctl_q(uint16_t port_id, uint16_t queue_id,
  *           successful.
  *   - (-1) on error.
  */
-__rte_experimental
 int
 rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, uint16_t queue_id);
 
diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
index 3eece75b72..a0fc4826a1 100644
--- a/lib/ethdev/version.map
+++ b/lib/ethdev/version.map
@@ -42,6 +42,7 @@ DPDK_22 {
 	rte_eth_dev_rss_reta_update;
 	rte_eth_dev_rx_intr_ctl;
 	rte_eth_dev_rx_intr_ctl_q;
+	rte_eth_dev_rx_intr_ctl_q_get_fd;
 	rte_eth_dev_rx_intr_disable;
 	rte_eth_dev_rx_intr_enable;
 	rte_eth_dev_rx_offload_name;
@@ -154,7 +155,6 @@ EXPERIMENTAL {
 	rte_eth_dev_get_module_info;
 
 	# added in 18.11
-	rte_eth_dev_rx_intr_ctl_q_get_fd;
 	rte_flow_conv;
 
 	# added in 19.05
-- 
2.25.1

Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

[Andrew Rybchenko]

On 9/1/21 4:50 AM, Xiaoyun Li wrote:
> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API
> that was introduced in 18.11 and have been around for 11 releases.
> 
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>

Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>

Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

[Ferruh Yigit]

On 9/1/2021 8:08 AM, Andrew Rybchenko wrote:
> On 9/1/21 4:50 AM, Xiaoyun Li wrote:
>> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API
>> that was introduced in 18.11 and have been around for 11 releases.
>>
>> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> 
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
> 

Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>

Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

[Kinsella, Ray]

On 01/09/2021 09:53, Ferruh Yigit wrote:
> On 9/1/2021 8:08 AM, Andrew Rybchenko wrote:
>> On 9/1/21 4:50 AM, Xiaoyun Li wrote:
>>> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API
>>> that was introduced in 18.11 and have been around for 11 releases.
>>>
>>> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
>>
>> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
> 
Acked-by: Ray Kinsella <mdr@ashroe.eu>

Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

[David Marchand]

On Wed, Sep 1, 2021 at 4:03 AM Xiaoyun Li <xiaoyun.li@intel.com> wrote:
>
> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API
> that was introduced in 18.11 and have been around for 11 releases.
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>

Odd that this API is used nowhere in-tree but it provides a simple
alternative to the DPDK interrupt builtin framework.
I had a go with this in OVS, and it seems to work as described (once
fixed virtio-user).

Acked-by: David Marchand <david.marchand@redhat.com>


-- 
David Marchand

Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

[Kinsella, Ray]

On 03/09/2021 13:17, David Marchand wrote:
> On Wed, Sep 1, 2021 at 4:03 AM Xiaoyun Li <xiaoyun.li@intel.com> wrote:
>>
>> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API
>> that was introduced in 18.11 and have been around for 11 releases.
>>
>> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
> 
> Odd that this API is used nowhere in-tree but it provides a simple
> alternative to the DPDK interrupt builtin framework.
> I had a go with this in OVS, and it seems to work as described (once
> fixed virtio-user).
> 
> Acked-by: David Marchand <david.marchand@redhat.com>
> 

FD.io VPP uses it, in its interrupt mgmt framework.

Acked-by: Ray Kinsella <mdr@ashroe.eu>

Ray K
 

Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API

[Ferruh Yigit]

On 9/1/2021 12:17 PM, Kinsella, Ray wrote:
> 
> 
> On 01/09/2021 09:53, Ferruh Yigit wrote:
>> On 9/1/2021 8:08 AM, Andrew Rybchenko wrote:
>>> On 9/1/21 4:50 AM, Xiaoyun Li wrote:
>>>> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API
>>>> that was introduced in 18.11 and have been around for 11 releases.
>>>>
>>>> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
>>>
>>> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>>
>>
>> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>
> 

Applied to dpdk-next-net/main, thanks.