* [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API
@ 2021-09-01 1:50 Xiaoyun Li
2021-09-01 7:08 ` Andrew Rybchenko
2021-09-03 12:17 ` David Marchand
0 siblings, 2 replies; 7+ messages in thread
From: Xiaoyun Li @ 2021-09-01 1:50 UTC (permalink / raw)
To: Thomas Monjalon, Ferruh Yigit, Andrew Rybchenko, Ray Kinsella
Cc: dev, Xiaoyun Li
Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API
that was introduced in 18.11 and have been around for 11 releases.
Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
---
lib/ethdev/rte_ethdev.h | 4 ----
lib/ethdev/version.map | 2 +-
2 files changed, 1 insertion(+), 5 deletions(-)
diff --git a/lib/ethdev/rte_ethdev.h b/lib/ethdev/rte_ethdev.h
index d2b27c351f..2ccd651490 100644
--- a/lib/ethdev/rte_ethdev.h
+++ b/lib/ethdev/rte_ethdev.h
@@ -3647,9 +3647,6 @@ int rte_eth_dev_rx_intr_ctl_q(uint16_t port_id, uint16_t queue_id,
int epfd, int op, void *data);
/**
- * @warning
- * @b EXPERIMENTAL: this API may change without prior notice.
- *
* Get interrupt fd per Rx queue.
*
* @param port_id
@@ -3663,7 +3660,6 @@ int rte_eth_dev_rx_intr_ctl_q(uint16_t port_id, uint16_t queue_id,
* successful.
* - (-1) on error.
*/
-__rte_experimental
int
rte_eth_dev_rx_intr_ctl_q_get_fd(uint16_t port_id, uint16_t queue_id);
diff --git a/lib/ethdev/version.map b/lib/ethdev/version.map
index 3eece75b72..a0fc4826a1 100644
--- a/lib/ethdev/version.map
+++ b/lib/ethdev/version.map
@@ -42,6 +42,7 @@ DPDK_22 {
rte_eth_dev_rss_reta_update;
rte_eth_dev_rx_intr_ctl;
rte_eth_dev_rx_intr_ctl_q;
+ rte_eth_dev_rx_intr_ctl_q_get_fd;
rte_eth_dev_rx_intr_disable;
rte_eth_dev_rx_intr_enable;
rte_eth_dev_rx_offload_name;
@@ -154,7 +155,6 @@ EXPERIMENTAL {
rte_eth_dev_get_module_info;
# added in 18.11
- rte_eth_dev_rx_intr_ctl_q_get_fd;
rte_flow_conv;
# added in 19.05
--
2.25.1
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API
2021-09-01 1:50 [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API Xiaoyun Li
@ 2021-09-01 7:08 ` Andrew Rybchenko
2021-09-01 8:53 ` Ferruh Yigit
2021-09-03 12:17 ` David Marchand
1 sibling, 1 reply; 7+ messages in thread
From: Andrew Rybchenko @ 2021-09-01 7:08 UTC (permalink / raw)
To: Xiaoyun Li, Thomas Monjalon, Ferruh Yigit, Ray Kinsella; +Cc: dev
On 9/1/21 4:50 AM, Xiaoyun Li wrote:
> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API
> that was introduced in 18.11 and have been around for 11 releases.
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API
2021-09-01 7:08 ` Andrew Rybchenko
@ 2021-09-01 8:53 ` Ferruh Yigit
2021-09-01 11:17 ` Kinsella, Ray
0 siblings, 1 reply; 7+ messages in thread
From: Ferruh Yigit @ 2021-09-01 8:53 UTC (permalink / raw)
To: Andrew Rybchenko, Xiaoyun Li, Thomas Monjalon, Ray Kinsella; +Cc: dev
On 9/1/2021 8:08 AM, Andrew Rybchenko wrote:
> On 9/1/21 4:50 AM, Xiaoyun Li wrote:
>> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API
>> that was introduced in 18.11 and have been around for 11 releases.
>>
>> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
>
> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>
Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API
2021-09-01 8:53 ` Ferruh Yigit
@ 2021-09-01 11:17 ` Kinsella, Ray
2021-09-14 16:13 ` Ferruh Yigit
0 siblings, 1 reply; 7+ messages in thread
From: Kinsella, Ray @ 2021-09-01 11:17 UTC (permalink / raw)
To: Ferruh Yigit, Andrew Rybchenko, Xiaoyun Li, Thomas Monjalon; +Cc: dev
On 01/09/2021 09:53, Ferruh Yigit wrote:
> On 9/1/2021 8:08 AM, Andrew Rybchenko wrote:
>> On 9/1/21 4:50 AM, Xiaoyun Li wrote:
>>> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API
>>> that was introduced in 18.11 and have been around for 11 releases.
>>>
>>> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
>>
>> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>
>
> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>
Acked-by: Ray Kinsella <mdr@ashroe.eu>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API
2021-09-01 11:17 ` Kinsella, Ray
@ 2021-09-14 16:13 ` Ferruh Yigit
0 siblings, 0 replies; 7+ messages in thread
From: Ferruh Yigit @ 2021-09-14 16:13 UTC (permalink / raw)
To: Kinsella, Ray, Andrew Rybchenko, Xiaoyun Li, Thomas Monjalon; +Cc: dev
On 9/1/2021 12:17 PM, Kinsella, Ray wrote:
>
>
> On 01/09/2021 09:53, Ferruh Yigit wrote:
>> On 9/1/2021 8:08 AM, Andrew Rybchenko wrote:
>>> On 9/1/21 4:50 AM, Xiaoyun Li wrote:
>>>> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API
>>>> that was introduced in 18.11 and have been around for 11 releases.
>>>>
>>>> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
>>>
>>> Acked-by: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
>>>
>>
>> Acked-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
> Acked-by: Ray Kinsella <mdr@ashroe.eu>
>
Applied to dpdk-next-net/main, thanks.
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API
2021-09-01 1:50 [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API Xiaoyun Li
2021-09-01 7:08 ` Andrew Rybchenko
@ 2021-09-03 12:17 ` David Marchand
2021-09-03 12:19 ` Kinsella, Ray
1 sibling, 1 reply; 7+ messages in thread
From: David Marchand @ 2021-09-03 12:17 UTC (permalink / raw)
To: Xiaoyun Li
Cc: Thomas Monjalon, Ferruh Yigit, Andrew Rybchenko, Ray Kinsella, dev
On Wed, Sep 1, 2021 at 4:03 AM Xiaoyun Li <xiaoyun.li@intel.com> wrote:
>
> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API
> that was introduced in 18.11 and have been around for 11 releases.
>
> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
Odd that this API is used nowhere in-tree but it provides a simple
alternative to the DPDK interrupt builtin framework.
I had a go with this in OVS, and it seems to work as described (once
fixed virtio-user).
Acked-by: David Marchand <david.marchand@redhat.com>
--
David Marchand
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API
2021-09-03 12:17 ` David Marchand
@ 2021-09-03 12:19 ` Kinsella, Ray
0 siblings, 0 replies; 7+ messages in thread
From: Kinsella, Ray @ 2021-09-03 12:19 UTC (permalink / raw)
To: David Marchand, Xiaoyun Li
Cc: Thomas Monjalon, Ferruh Yigit, Andrew Rybchenko, dev
On 03/09/2021 13:17, David Marchand wrote:
> On Wed, Sep 1, 2021 at 4:03 AM Xiaoyun Li <xiaoyun.li@intel.com> wrote:
>>
>> Remove the experimental tag for rte_eth_dev_rx_intr_ctl_q_get_fd API
>> that was introduced in 18.11 and have been around for 11 releases.
>>
>> Signed-off-by: Xiaoyun Li <xiaoyun.li@intel.com>
>
> Odd that this API is used nowhere in-tree but it provides a simple
> alternative to the DPDK interrupt builtin framework.
> I had a go with this in OVS, and it seems to work as described (once
> fixed virtio-user).
>
> Acked-by: David Marchand <david.marchand@redhat.com>
>
FD.io VPP uses it, in its interrupt mgmt framework.
Acked-by: Ray Kinsella <mdr@ashroe.eu>
Ray K
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-09-14 16:13 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-01 1:50 [dpdk-dev] [PATCH] ethdev: remove experimental flag from getting intr fd API Xiaoyun Li
2021-09-01 7:08 ` Andrew Rybchenko
2021-09-01 8:53 ` Ferruh Yigit
2021-09-01 11:17 ` Kinsella, Ray
2021-09-14 16:13 ` Ferruh Yigit
2021-09-03 12:17 ` David Marchand
2021-09-03 12:19 ` Kinsella, Ray
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).