From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44BC5A00C2; Sat, 25 Apr 2020 16:22:03 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DB9671C1B3; Sat, 25 Apr 2020 16:22:01 +0200 (CEST) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [207.211.31.81]) by dpdk.org (Postfix) with ESMTP id 0494E1C190 for ; Sat, 25 Apr 2020 16:21:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587824518; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=axBN4qKiGfW4CiHrarp0H3JNWyB0ZN4r3W4HBp05uK4=; b=CPHqDoaH5GbhtE/ePsOIZQsHKUwTLyZqXb5NEVgA39p8o8ErZZJzGCKSFRowLTNBIPa27S Mqt9izcjKrK9dOMwtQj95nF7qPwD99FZ+niAYcl7E9EUeSRiY162Yud4vWgkafWSk89LYF KsuA3ZM8VF5sc2VosrQrXBf4U8RZf3c= Received: from mail-ua1-f72.google.com (mail-ua1-f72.google.com [209.85.222.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-511-w49KXdHXMAGOuRXFsKUuEA-1; Sat, 25 Apr 2020 10:21:47 -0400 X-MC-Unique: w49KXdHXMAGOuRXFsKUuEA-1 Received: by mail-ua1-f72.google.com with SMTP id m26so6860909uao.2 for ; Sat, 25 Apr 2020 07:21:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VzHStFHsz+zjOfCwi/AyQpmkFCScXfIoSbJfwaWxto8=; b=GipsWJH5N2h5IcBOgAoWeU7DZ2wchfPVV0VVEFrPDWFrStdRotVToJgBDA4Jj6LtRP LXAfx8OTg3EroI39ki7T9tcPeEFqpRMXq3WP0FjxfKDRs3FdlQ/HgRqv+oQ80M/us/TJ qhpLyU1TBzRzuRozURcPolReTFyUPkJ6PhWwttR+Pzao1c5Z0vhurS26xWN8n1b7PRAs AqhlKIB2nIxOhO4tWRQ0rhRAYnS/p3uGuXX1jqTHLTOhPRGIXxmtuUB3Mi2m7/ylMfuX bD4Svj4JO67cIU4jwmHkxFhq9Y6HFJxCZhuZf0nWhWbZXOnJaXiNrzfAXlyOYO4pQ6Hm 0bEA== X-Gm-Message-State: AGi0PuYtpaFsQhUXiPltZSw9Cb5t3lB+ctqn7kwoVy4qshg6QDpNa1BN mI/Dlh5FlmFK0DOS2QWK+DCH6nubfBrzXmrRKuLhrYdxI0zA5YyOtpaJmBJoOXsidNbQEHUFzd3 qGdQtLZ56ZV/or2pl6bY= X-Received: by 2002:a67:487:: with SMTP id 129mr11835949vse.105.1587824505959; Sat, 25 Apr 2020 07:21:45 -0700 (PDT) X-Google-Smtp-Source: APiQypLr2r+SXBCfpbrYZibYNnFk+McCRAp+fIaBhDe7iguthi6D3QaigSblN6wsjVKCAAvLjXitBxA92AZDdJQfZAo= X-Received: by 2002:a67:487:: with SMTP id 129mr11835924vse.105.1587824505547; Sat, 25 Apr 2020 07:21:45 -0700 (PDT) MIME-Version: 1.0 References: <20190613142344.9188-1-nhorman@tuxdriver.com> <20200423031947.4477-1-haiyue.wang@intel.com> <20200423031947.4477-2-haiyue.wang@intel.com> <65d5f3da24f14e0c96695158d40032b1@intel.com> In-Reply-To: <65d5f3da24f14e0c96695158d40032b1@intel.com> From: David Marchand Date: Sat, 25 Apr 2020 16:21:34 +0200 Message-ID: To: "Wang, Haiyue" Cc: dev , Thomas Monjalon , "Richardson, Bruce" , "Yigit, Ferruh" , Neil Horman , Ray Kinsella X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v5 1/1] eal: add internal ABI marking support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sat, Apr 25, 2020 at 8:10 AM Wang, Haiyue wrote: > > Hi David, > > Try to fix the issues you mentioned, except below, plan to > another patch set, I need more time to test these adding. Thanks for working on this topic. > > =3D=3D=3D=3D > > We are missing updates on devtools/check-abi-version.sh and > devtools/update_version_map_abi.py. Those two scripts can be updated later: - I suspect the first one to be broken already, - the 2nd one is for 20.11 when we will update all map files. > > More importantly on this file: > > - drivers/meson.build is not updated to check for internal symbols, see: > https://git.dpdk.org/dpdk/tree/drivers/meson.build#n166 On this point, your series is almost good to go, I would just get rid of the "experimental" mentions. I will reply on the patch. > - For fully experimental libraries, we have a special so version: > https://git.dpdk.org/dpdk/tree/drivers/meson.build#n131 > > This will apply to common drivers that will be 100% internal. > Not sure if this is an issue. This part should be fine, I want others to be aware of this. --=20 David Marchand