From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 849A1A0579; Thu, 8 Apr 2021 16:05:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 63AF414101B; Thu, 8 Apr 2021 16:05:11 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mails.dpdk.org (Postfix) with ESMTP id 3E6B74068B for ; Thu, 8 Apr 2021 16:05:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1617890709; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=WShkWwVNmKN6WtnGZ3jr3EQA7MOt3ojQv5NNlh24yTc=; b=gF9BZBlT/2jxg17Q4lFsG9QoNwoWo7FuN9X7947JDcTOh68Ja4G0rMGTnKi2NKzwWBkMYu zkzBblUJcgoDK42Pc55UwZnzAHbWhGyM/vYKQ1c0x2hiv6gOzQYIJGRKE7QLXZKz0jqmti FQmUuRIA66mzxzHe3uFij1PIAGfbLNs= Received: from mail-lf1-f69.google.com (mail-lf1-f69.google.com [209.85.167.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-535-eyIkRr8aOGCtRBmrTItYEg-1; Thu, 08 Apr 2021 10:05:07 -0400 X-MC-Unique: eyIkRr8aOGCtRBmrTItYEg-1 Received: by mail-lf1-f69.google.com with SMTP id t4so913168lft.7 for ; Thu, 08 Apr 2021 07:05:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WShkWwVNmKN6WtnGZ3jr3EQA7MOt3ojQv5NNlh24yTc=; b=S5955AeT2vu54L9+bFkHQahnJXS0+6mewzLqdlNeH3oePPlmpdY2tErxJZflLFcHKG ldgJrChqTfKwxLMoY7Tljx3WKW9zZafiV2FWv1QY4ryNdAYc3x0ZWzPM6hP+3VgyK8YY VXy3Y5uC2E2JjUKoU84a5euDsTI7JW4Kap3DGS+eIVafYPiUifmFkeYA1VOezfIee+0q w2PntZrzickdKRvn69iYg+pDhDd28zt91o2NfTzfwbLo31+MuyjEUZtIByZd2bOSXK3p cAvP5OFPg1Kzhioho8iAXjNyWVBGQzYuSKMRSvGrjzfJSPTph5YWMdmwX2wkDnFgQhg/ p/QQ== X-Gm-Message-State: AOAM530vw/yXogPS2qtONlIfQ8QDtj15gwf2cXBlk+JdZWXolKAyhZXF aFibNY4YBOUyGYB7IkQMpE1LBmtpkLMEHWTNfgm5VsZPKBqDA14gm8nfN0toXjyG2Q+ZgKAygaN rewVfvS3kmd/VvSwuSnc= X-Received: by 2002:a2e:a589:: with SMTP id m9mr6104831ljp.134.1617890706098; Thu, 08 Apr 2021 07:05:06 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyCiWV3mgSG51wftSAiCW3gD26oGC/DkZGKfVFoK1qpUUc8vgBrksOUFnhus5BxDoWUAEN0cXoMLcOCplK4/mI= X-Received: by 2002:a2e:a589:: with SMTP id m9mr6104813ljp.134.1617890705896; Thu, 08 Apr 2021 07:05:05 -0700 (PDT) MIME-Version: 1.0 References: <20210407090656.29176-1-david.marchand@redhat.com> In-Reply-To: From: David Marchand Date: Thu, 8 Apr 2021 16:04:54 +0200 Message-ID: To: "Van Haaren, Harry" Cc: "dev@dpdk.org" , "stable@dpdk.org" , Ray Kinsella , Neil Horman , Dodji Seketeli Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] service: clean references to removed symbol X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 8, 2021 at 3:08 PM Van Haaren, Harry wrote: > > > For rte_service.h doc changes I'm all fine. > > > > > > For ABI consistency, this removes a function from the DPDK_21 version map that > > didn't exist in > > > the shared object itself. I'm not sure if that's an ABI break or not... I see ABI > > experts on CC, > > > and will let them comment on that topic. > > > > The symbol is not in the API anymore. > > Applications can't have a reference to this symbol without a definition. > > Agreed, however I'm not familiar enough with linking/ABI stability to > know if removing a symbol (even when not available in the API) could > affect the resulting shared object's ABI. After a discussion with Dodji and looking at binutils, I understand that the versioning is applied for each symbol found in an elf object. So at least with binutils, non-existent nodes in a version script are harmless and have no impact on the generated elf. -- David Marchand