From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A12F6A00E6 for ; Thu, 8 Aug 2019 09:33:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 46F6C231E; Thu, 8 Aug 2019 09:33:28 +0200 (CEST) Received: from mail-vs1-f67.google.com (mail-vs1-f67.google.com [209.85.217.67]) by dpdk.org (Postfix) with ESMTP id B06213DC for ; Thu, 8 Aug 2019 09:33:27 +0200 (CEST) Received: by mail-vs1-f67.google.com with SMTP id v6so62473479vsq.4 for ; Thu, 08 Aug 2019 00:33:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7WCh7/a5v9iorGiVf6SwGOeR1mpZ1O2hWyIwX9twHNY=; b=ARq0dl49cvmnZsyy1P9JWGqZYRpLi4Gin8bU2mlHO3DyQohpJpdAcKvdfSdDPXAvx7 LsQLkLXar+9NwJ2cf7BI6zeM0rzViTi6ovPAXVPT1L2RH1N5uMz5A2GRmXJl1jzL0UR7 ytMBMGU7Ag6U0Q8ypKdE7RcpUUE0m3HJ5gLRv5N9tNlYbFNnl7PTNEPjuRyoEYqaW4R3 /oAIOuwjhYSm1BHTTYsvfv4kKZtwEF26Mkb43hixZLg2qDSNa7jE/DJL+5IkbE+Kzx3Y FoZ27oxU/jMh1IgIpbMMej/5nDjq/wSlbN4wx5e2pg6XJ7KCTB3crnFVmhxW516ngK1O AXPA== X-Gm-Message-State: APjAAAXw6oslfoYwF22aepuMDqZbNmZgUCUecntIEbZ+5DRGkhzW0mcB Cha7/2i0lHwQg22o0shmYuZ66VsbmlIn0CXxvHTwVw== X-Google-Smtp-Source: APXvYqz20NYD3FuuNHnl8hOrGJPYbK2Sn+mFYKCmIfh0VPeHxjT3C1Ssoxq5ba4HrErTTaRC87GALe2xt8QYGcDfhmc= X-Received: by 2002:a67:f998:: with SMTP id b24mr8888270vsq.180.1565249607022; Thu, 08 Aug 2019 00:33:27 -0700 (PDT) MIME-Version: 1.0 References: <20190807101204.21614-1-g.singh@nxp.com> <52183700.OczlixnxyG@xps> In-Reply-To: From: David Marchand Date: Thu, 8 Aug 2019 09:33:15 +0200 Message-ID: To: Hemant Agrawal Cc: Thomas Monjalon , Gagandeep Singh , dev , "Burakov, Anatoly" , Olivier Matz , Andrew Rybchenko , Nipun Gupta , Jerin Jacob Kollanukkaran , Gavin Hu , Bruce Richardson Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: change max hugepage sizes to 4 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Aug 7, 2019 at 3:28 PM Hemant Agrawal wrote: > > HI Thomas, > > > > > DPDK currently is supporting maximum 3 hugepage, sizes whereas > > > > system can support more than this e.g. > > > > 64K, 2M, 32M and 1G. > > > > > > You can mention ARM platform here, and that this issue starts with > > > kernel 5.2 (and I would try to mention this in the title as well). > > > This is better than an annotation that will be lost. > > > > > > > > > > Having these four hugepage sizes available to use by DPDK, which is > > > > valid in case of '--in-memory' EAL option or using 4 separate mount > > > > points for each hugepage size; > > > > hugepage_info_init() API reports an error. > > > > > > Can you describe what is the impact from a user point of view rather > > > than mentioning this internal function? > > > > Yes please, we need to understand how much it is critical. > > Should we Cc stable@dpdk.org for backport? > > Should it be merged at the last minute in 19.08? > > > > VPP usages in-memory option. So, VPP on ARM with kernel 5.2 wont' work without this patch. > I have been looking at the changes in the linux kernel. Can you pinpoint at the commit that changed this in 5.2? I can see a change in the code, but in 5.0, or maybe something changed in the configuration. The patch you propose is not that risky (x86 supports two pagesizes, and max hugepage is already at 3, so we know the code works fine with less than the max). Yet, I want to understand why this is urgent now. CCing other architecture maintainers. -- David Marchand