DPDK patches and discussions
 help / color / Atom feed
* [dpdk-dev] [PATCH] examples/ethtool: fix unchecked return value
@ 2019-12-09  6:37 Gargi Sau
  2019-12-09 12:07 ` Bruce Richardson
  0 siblings, 1 reply; 3+ messages in thread
From: Gargi Sau @ 2019-12-09  6:37 UTC (permalink / raw)
  To: dev; +Cc: stable

This checks the return value from the function
rte_eth_dev_set_vlan_offload.

Coverity issue: 350358
Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
Cc: stable@dpdk.org

Signed-off-by: Gargi Sau <gargi.sau@intel.com>
---
 examples/ethtool/lib/rte_ethtool.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c
index 667d7eaf2..db8150efd 100644
--- a/examples/ethtool/lib/rte_ethtool.c
+++ b/examples/ethtool/lib/rte_ethtool.c
@@ -402,7 +402,9 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id)
 	}
 
 	/* Enable Rx vlan filter, VF unspport status is discard */
-	rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
+	ret = rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
+	if (ret != 0)
+		return ret;
 
 	return 0;
 }
-- 
2.17.1


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ethtool: fix unchecked return value
  2019-12-09  6:37 [dpdk-dev] [PATCH] examples/ethtool: fix unchecked return value Gargi Sau
@ 2019-12-09 12:07 ` Bruce Richardson
  2020-02-13 13:59   ` David Marchand
  0 siblings, 1 reply; 3+ messages in thread
From: Bruce Richardson @ 2019-12-09 12:07 UTC (permalink / raw)
  To: Gargi Sau; +Cc: dev, stable

On Mon, Dec 09, 2019 at 06:37:56AM +0000, Gargi Sau wrote:
> This checks the return value from the function
> rte_eth_dev_set_vlan_offload.
> 
> Coverity issue: 350358
> Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Gargi Sau <gargi.sau@intel.com>
> ---
>  examples/ethtool/lib/rte_ethtool.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c
> index 667d7eaf2..db8150efd 100644
> --- a/examples/ethtool/lib/rte_ethtool.c
> +++ b/examples/ethtool/lib/rte_ethtool.c
> @@ -402,7 +402,9 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id)
>  	}
>  
>  	/* Enable Rx vlan filter, VF unspport status is discard */
> -	rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
> +	ret = rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
> +	if (ret != 0)
> +		return ret;
>  
Looks ok to me.

Acked-by: Bruce Richardson <bruce.richardson@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] examples/ethtool: fix unchecked return value
  2019-12-09 12:07 ` Bruce Richardson
@ 2020-02-13 13:59   ` David Marchand
  0 siblings, 0 replies; 3+ messages in thread
From: David Marchand @ 2020-02-13 13:59 UTC (permalink / raw)
  To: Gargi Sau; +Cc: dev, dpdk stable, Bruce Richardson

On Mon, Dec 9, 2019 at 1:07 PM Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Mon, Dec 09, 2019 at 06:37:56AM +0000, Gargi Sau wrote:
> > This checks the return value from the function
> > rte_eth_dev_set_vlan_offload.
> >
> > Coverity issue: 350358
> > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample application")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Gargi Sau <gargi.sau@intel.com>
> > ---
> >  examples/ethtool/lib/rte_ethtool.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> >
> > diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/rte_ethtool.c
> > index 667d7eaf2..db8150efd 100644
> > --- a/examples/ethtool/lib/rte_ethtool.c
> > +++ b/examples/ethtool/lib/rte_ethtool.c
> > @@ -402,7 +402,9 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id)
> >       }
> >
> >       /* Enable Rx vlan filter, VF unspport status is discard */
> > -     rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
> > +     ret = rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK);
> > +     if (ret != 0)
> > +             return ret;
> >
> Looks ok to me.
>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, back to index

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-09  6:37 [dpdk-dev] [PATCH] examples/ethtool: fix unchecked return value Gargi Sau
2019-12-09 12:07 ` Bruce Richardson
2020-02-13 13:59   ` David Marchand

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox