From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2784FA0542; Thu, 13 Feb 2020 14:59:29 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 05E8E1BFE5; Thu, 13 Feb 2020 14:59:29 +0100 (CET) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-2.mimecast.com [205.139.110.61]) by dpdk.org (Postfix) with ESMTP id 7C71E1BFD1 for ; Thu, 13 Feb 2020 14:59:27 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1581602367; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HOAMNJEimhsdXB8LVjQtzS4UmqkaZSEmMV1cVK/zBzM=; b=SfiyKRG/AD+A7rCDAhF/OohIXoKHvF1WhqJmo3WHckHKkTaWiwIIRBGqIeit/9fQzjADnI z6vQ2uXXTacp1IcpYqVRJQUl3aZX1Hy0pWavv3Xsyroh5wTPxIUo0HJ/QonnCVxuW7vvfT clSNHmnV3Ufr32ZcId5tV6POqP/gnys= Received: from mail-vk1-f197.google.com (mail-vk1-f197.google.com [209.85.221.197]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-212-HOF7R-alMZC3NEW_LIrxzg-1; Thu, 13 Feb 2020 08:59:24 -0500 Received: by mail-vk1-f197.google.com with SMTP id n9so1983119vkc.14 for ; Thu, 13 Feb 2020 05:59:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G7eLUArMG1dQssBzLKuEDW3fk9OdhWolBXYNHTeICGQ=; b=O9X8SnajufVCRCRRxNbPS9Bl9BU5nQNuxgQrHnKUXRjn7kchvuuDJip5AxFrlZRfZ3 Zvjkgg27pED28RmmJa+UrgJrXDm2nIX7hLa2TxX5gNcGFboNv2xC9DE8adlM9I/EJK7b Sq4EoZ/3OZygrFErnZrGRIsfFYQZ96O94D7taPmxwP3bpu3GDjNYTP2WdNM6FbMf9v0Q IL2gqDxtMz9EGWFRKF39xEkma0CS2U5wJ5bg+NMbaJPJ7SwTDq7dSxY6Wgs5P48D3Z9y gyK+MPOSfm79Tk0MoQRQ6dNrUzWQGUImEIBomk9JrRKQQS/zrsNbRrlODUnRXhu+7e4E fCfw== X-Gm-Message-State: APjAAAVqHlBu8OQZQJD8XBHgo3IL4xSZuFie4PakFTA9xGWbKwSXcjxA YhrzTSRMzkfiBUnR/Chg7sw8tO/7kvLBUK9DuhznnNJ1pPNxBw8jbrZ53zfx2JcVXhv5+9TaCVe oXXBo5jWhv9SH1oPiIgc= X-Received: by 2002:a67:f1ca:: with SMTP id v10mr2151681vsm.180.1581602364489; Thu, 13 Feb 2020 05:59:24 -0800 (PST) X-Google-Smtp-Source: APXvYqzcwtjDEfIP5cz9P8b7O+cjdBV/+Vop20ovIEkueI6/pBz3t530hGE95vj1vkDl33GPwIZGKlzxg/5U3hSYzB4= X-Received: by 2002:a67:f1ca:: with SMTP id v10mr2151670vsm.180.1581602364220; Thu, 13 Feb 2020 05:59:24 -0800 (PST) MIME-Version: 1.0 References: <20191209063756.26790-1-gargi.sau@intel.com> <20191209120712.GA98@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20191209120712.GA98@bricha3-MOBL.ger.corp.intel.com> From: David Marchand Date: Thu, 13 Feb 2020 14:59:13 +0100 Message-ID: To: Gargi Sau Cc: dev , dpdk stable , Bruce Richardson X-MC-Unique: HOF7R-alMZC3NEW_LIrxzg-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH] examples/ethtool: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Dec 9, 2019 at 1:07 PM Bruce Richardson wrote: > > On Mon, Dec 09, 2019 at 06:37:56AM +0000, Gargi Sau wrote: > > This checks the return value from the function > > rte_eth_dev_set_vlan_offload. > > > > Coverity issue: 350358 > > Fixes: bda68ab9d1e7 ("examples/ethtool: add user-space ethtool sample a= pplication") > > Cc: stable@dpdk.org > > > > Signed-off-by: Gargi Sau > > --- > > examples/ethtool/lib/rte_ethtool.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/examples/ethtool/lib/rte_ethtool.c b/examples/ethtool/lib/= rte_ethtool.c > > index 667d7eaf2..db8150efd 100644 > > --- a/examples/ethtool/lib/rte_ethtool.c > > +++ b/examples/ethtool/lib/rte_ethtool.c > > @@ -402,7 +402,9 @@ rte_ethtool_net_set_rx_mode(uint16_t port_id) > > } > > > > /* Enable Rx vlan filter, VF unspport status is discard */ > > - rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MASK); > > + ret =3D rte_eth_dev_set_vlan_offload(port_id, ETH_VLAN_FILTER_MAS= K); > > + if (ret !=3D 0) > > + return ret; > > > Looks ok to me. > > Acked-by: Bruce Richardson Applied, thanks. --=20 David Marchand