From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A711FA04BC; Fri, 9 Oct 2020 09:24:53 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 833601C127; Fri, 9 Oct 2020 09:24:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by dpdk.org (Postfix) with ESMTP id 534B51C115 for ; Fri, 9 Oct 2020 09:24:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1602228288; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=apytDgEonomuVg9ueukNrcKdaaqyqyLnadKGcJyy0ss=; b=ev2Tkzn+Od5KU3bmowTayCcCsh5+pdeRNAFAKMIVyXJZKj1KE+mS5u/lgdaHXD35ujp/Jk XM7ytEhcPaWzWm269SmgOlMGF+js1EpMNMmWk3ovh/VlovZmAR3L43fsVFu2LXNm6BrHNq gmlRg8jD4uwaLD/4iuMhAJepehgtxCE= Received: from mail-vk1-f198.google.com (mail-vk1-f198.google.com [209.85.221.198]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-278-fznk6yuWMBm7ip7gVI-WWQ-1; Fri, 09 Oct 2020 03:24:47 -0400 X-MC-Unique: fznk6yuWMBm7ip7gVI-WWQ-1 Received: by mail-vk1-f198.google.com with SMTP id h196so1463660vke.8 for ; Fri, 09 Oct 2020 00:24:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=apytDgEonomuVg9ueukNrcKdaaqyqyLnadKGcJyy0ss=; b=n0qJ/LA1KvEv4HD2HVq8eJ/6x5HztASD9HiJ8Sv7e6MmMC4FzKgE7nbhsV4YtiZ2Wn OZtFFugCLuQTIVuVZ7NvsXpDATWNjhcGiTSdvnsxc+/g6It1qWvNITac+DBq6tOmJMC9 1d5DjIEw7hbsdG+c38JwPvz18LhCU7PwMTt0YfGBVwQj9rB06C0lZKjjcbONOCVn1RA1 xtpurlSK/AEaUxd7n8uYcLY+Ri00bjokyysqx5MsyTqB115IrsbEbmvgoZtSDFceqQl/ F42cz/7+tDyRBrAJR6H7X4zJWxTMZVx1wmhmOB6VvVDUF5+P0oFW/oFftFzBOr+2QcYU KmUw== X-Gm-Message-State: AOAM533dP59j568shzBfApGYF7s/20yIJTzkNNlONBbrxiR4Mgxefx4d LALUPJzIRfqKA1+qagccGvUq1tPColHdg2cs7o0dSStaiVdBByPVV7T42rKI2Umj+TfB9Zj368r DjkAY+gqxehHBFkJobww= X-Received: by 2002:a1f:e905:: with SMTP id g5mr6828139vkh.17.1602228286897; Fri, 09 Oct 2020 00:24:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxfwa6QL9A37ujyzC0r2dSFhCi0hMXA+KiKZzrIzSrufGDBjlhdTwRZRKnaZwPacITEPdpaGdLfZ/Ia4pXE8Bg= X-Received: by 2002:a1f:e905:: with SMTP id g5mr6828132vkh.17.1602228286642; Fri, 09 Oct 2020 00:24:46 -0700 (PDT) MIME-Version: 1.0 References: <20201009071554.30510-1-david.marchand@redhat.com> In-Reply-To: <20201009071554.30510-1-david.marchand@redhat.com> From: David Marchand Date: Fri, 9 Oct 2020 09:24:35 +0200 Message-ID: To: Harry van Haaren Cc: dpdk stable , dev , Vipin Varghese Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: fix doxygen for EAL cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 9, 2020 at 9:16 AM David Marchand wrote: > > Align rte_eal_cleanup return codes description to the rest of dpdk. > > Fixes: aec9c13c5257 ("eal: add function to release internal resources") > Cc: stable@dpdk.org > > Signed-off-by: David Marchand > --- > lib/librte_eal/include/rte_eal.h | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_eal/include/rte_eal.h b/lib/librte_eal/include/rte_eal.h > index ddcf6a2e7a..e3c2ef185e 100644 > --- a/lib/librte_eal/include/rte_eal.h > +++ b/lib/librte_eal/include/rte_eal.h > @@ -130,8 +130,9 @@ int rte_eal_init(int argc, char **argv); > * be made. It is expected that common usage of this function is to call it > * just before terminating the process. > * > - * @return 0 Successfully released all internal EAL resources > - * @return -EFAULT There was an error in releasing all resources. > + * @return > + * - 0 Successfully released all internal EAL resources. > + * - -EFAULT There was an error in releasing all resources. > */ > int rte_eal_cleanup(void); > Side note, this function has never returned anything but 0. Is this some stale doxygen comment from the introduction of this function? I wonder what an application could do if the cleanup failed, anyway. EAL will probably have error logs in such a situation? -- David Marchand