From: David Marchand <david.marchand@redhat.com>
To: Anatoly Burakov <anatoly.burakov@intel.com>,
bruce.richardson@intel.com, jaroslaw.ilgiewicz@intel.com
Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net>,
Luca Boccassi <bluca@debian.org>
Subject: Re: [PATCH v1 27/30] net/i40e/base: change time variables from 64 bit to 32 bit
Date: Fri, 25 Oct 2024 13:45:37 +0200 [thread overview]
Message-ID: <CAJFAV8zRk5f_Ag7sEe_xOh8cOefSf=152zWTp7fEYzndzwAswg@mail.gmail.com> (raw)
In-Reply-To: <CAJFAV8zBndjGjrjsc-pyBvc-xv4JRN-aUydDfG2tyypqAjVKJA@mail.gmail.com>
On Thu, Oct 17, 2024 at 1:43 PM David Marchand
<david.marchand@redhat.com> wrote:
>
> On Mon, Sep 2, 2024 at 11:58 AM Anatoly Burakov
> <anatoly.burakov@intel.com> wrote:
> >
> > From: Jaroslaw Ilgiewicz <jaroslaw.ilgiewicz@intel.com>
> >
> > Time variables were designed for 32 bit and 64 bit variables are not
> > necessary. Changed all to 32 bit.
> >
> > Signed-off-by: Jaroslaw Ilgiewicz <jaroslaw.ilgiewicz@intel.com>
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> > drivers/net/i40e/base/i40e_common.c | 2 +-
> > drivers/net/i40e/base/i40e_nvm.c | 6 +++---
> > drivers/net/i40e/base/i40e_prototype.h | 2 +-
> > 3 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/base/i40e_common.c
> > index 07e18deaea..a2cfafeda9 100644
> > --- a/drivers/net/i40e/base/i40e_common.c
> > +++ b/drivers/net/i40e/base/i40e_common.c
> > @@ -3596,7 +3596,7 @@ enum i40e_status_code i40e_aq_debug_write_register(struct i40e_hw *hw,
> > enum i40e_status_code i40e_aq_request_resource(struct i40e_hw *hw,
> > enum i40e_aq_resources_ids resource,
> > enum i40e_aq_resource_access_type access,
> > - u8 sdp_number, u64 *timeout,
> > + u8 sdp_number, u32 *timeout,
> > struct i40e_asq_cmd_details *cmd_details)
> > {
> > struct i40e_aq_desc desc;
> > diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i40e_nvm.c
> > index 2f6cd9eda5..185af67817 100644
> > --- a/drivers/net/i40e/base/i40e_nvm.c
> > +++ b/drivers/net/i40e/base/i40e_nvm.c
> > @@ -62,7 +62,7 @@ enum i40e_status_code i40e_acquire_nvm(struct i40e_hw *hw,
> > {
> > enum i40e_status_code ret_code = I40E_SUCCESS;
> > u32 gtime, timeout;
> > - u64 time_left = 0;
> > + u32 time_left = 0;
>
> Some logs (a few lines below) needs updating:
>
> i40e_debug(hw, I40E_DEBUG_NVM,
> "NVM acquire type %d failed time_left=%"
> PRIu64 " ret=%d aq_err=%d\n",
> access, time_left, ret_code,
> hw->aq.asq_last_status);
>
> And
> i40e_debug(hw, I40E_DEBUG_NVM,
> "NVM acquire timed out, wait %"
> PRIu64 " ms before trying again. status=%d aq_err=%d\n",
> time_left, ret_code,
> hw->aq.asq_last_status);
>
> Afaiu, it should be PRIu32.
>
> This was raised by OBS CI:
> https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/Debian_12/x86_64
Reminder, this was mentionned during the maintainers call yesterday.
Please send a fix.
Thanks.
--
David Marchand
next prev parent reply other threads:[~2024-10-25 11:45 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-02 9:54 [PATCH v1 00/30] Update net/i40e base driver Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 01/30] net/i40e/base: adjust whitespace Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 02/30] net/i40e/base: strip all tags from code Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 03/30] net/i40e/base: remove non-inclusive language Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 04/30] net/i40e/base: remove unused variables Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 05/30] net/i40e/base: don't set flags in i40e_init_shared_code Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 06/30] net/i40e/base: fix misleading debug logs and comments Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 07/30] net/i40e/base: add missing define to X710TL device check Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 08/30] net/i40e/base: add new device ID to 25G device list Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 09/30] net/i40e/base: fix setting MAC type for X722 Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 10/30] net/i40e/base: add definitions for rx_err1 Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 11/30] net/i40e/base: fix not blinking X722 with x557 PHY Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 12/30] net/i40e/base: add VLAN field for input set Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 13/30] net/i40e/base: allow reading LED blink setting Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 14/30] net/i40e/base: do not load DDP packages with reserved track ID Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 15/30] net/i40e/base: add DDP package type defines Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 16/30] net/i40e/base: add X722 defines for input set mask Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 17/30] net/i40e/base: improve typecasting Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 18/30] net/i40e/base: add named and raw structs to rx desc Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 19/30] net/i40e/base: align registers to the specification Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 20/30] net/i40e/base: add PHY debug register dump Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 21/30] net/i40e/base: make register dump read-only Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 22/30] net/i40e/base: fix unchecked return value Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 23/30] net/i40e/base: check loop bounds Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 24/30] net/i40e/base: make semaphore timeout 32-bit Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 25/30] net/i40e/base: add register definitions for FLU Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 26/30] net/i40e/base: add NVM acquire with custom timeout Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 27/30] net/i40e/base: change time variables from 64 bit to 32 bit Anatoly Burakov
2024-10-17 11:43 ` David Marchand
2024-10-25 11:45 ` David Marchand [this message]
2024-09-02 9:54 ` [PATCH v1 28/30] net/i40e/base: add trace buffer reading dependencies Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 29/30] net/i40e/base: add Shadow RAM pointer definition Anatoly Burakov
2024-09-02 9:54 ` [PATCH v1 30/30] net/i40e: update base driver README Anatoly Burakov
2024-09-12 15:52 ` [PATCH v1 00/30] Update net/i40e base driver Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8zRk5f_Ag7sEe_xOh8cOefSf=152zWTp7fEYzndzwAswg@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=anatoly.burakov@intel.com \
--cc=bluca@debian.org \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jaroslaw.ilgiewicz@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).