From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5170645BD5; Fri, 25 Oct 2024 13:45:53 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E5D7840156; Fri, 25 Oct 2024 13:45:52 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 08751400D5 for ; Fri, 25 Oct 2024 13:45:51 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729856751; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Tafiw2cW2A+Ng/rPos7yJvYJGY2b/WS4967h3LY1j6M=; b=bAwE1P40smz6axnyaZPW+naW8kUfaUXoinDfLp4uPlSW3Y7BJlRRxgM/WcEbmv+sqLPtfP all6Po3218MHuPqkGHknWqlAL7zBTfCgQdSiiP33Pupw+84mQCJiedoLknQ3rBdkmeWTg4 Vh5+27wP/iojDFUWnzQrCQjzKEL23hI= Received: from mail-lj1-f197.google.com (mail-lj1-f197.google.com [209.85.208.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-663-X5gyNrEFPtuN4_vrdfxCrw-1; Fri, 25 Oct 2024 07:45:50 -0400 X-MC-Unique: X5gyNrEFPtuN4_vrdfxCrw-1 Received: by mail-lj1-f197.google.com with SMTP id 38308e7fff4ca-2fc95daca75so13079161fa.2 for ; Fri, 25 Oct 2024 04:45:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729856749; x=1730461549; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tafiw2cW2A+Ng/rPos7yJvYJGY2b/WS4967h3LY1j6M=; b=kWxVNXMKyF4cwpMjE7uO5AXin35mNBLomYROS3KWFUavPtchBnh5JdchVloV27Qrjm hasbZF7ySWXPadH3KdeWYt44o6OUUcE/r8XAy91nkBagJv/Xgu8uFL2RDMk3dH0YAPUw 39xotNmkoGdM803v0RHO7eV9i+w3H09Ey2SC/s9+iNljL0G1kmTv8dhQ3m0x69n4tWMT GsmP0Sa+a05tB5QRSm1gfVxiM9xrP4D1lYLTlo8pQbMmWVN8PN8WvuumFdEdE1bLF2RX KgZwO+TBX/MI3LAYg9zzl0GXL1pg2nzMzj4CTaH9IjeRPGlx5M9Idj04OwE7m2xyJr9j xrog== X-Gm-Message-State: AOJu0YxLt9tWDj3z4RQTGJSvDVD4S0Nm/fFHqesgxc0/XyVaEb3Y4q4p ej+vSw/9zeBzfHAN+pfu4niQRbNZsIgntEWz+1aOCH7z35JusPq1vSulQ0IqzCaz9aldxyjimcH h1J37WSdgtaJrLDaXhiyr6pP1afZh1fKtj1fK9g5xfN+V1/BGwFwB6strkOJ+GbwDD3X3ikYBHj WeJLI3x1pzPXqp/Uc= X-Received: by 2002:a2e:a989:0:b0:2fb:5a19:5b92 with SMTP id 38308e7fff4ca-2fca827fb8amr32730091fa.40.1729856748737; Fri, 25 Oct 2024 04:45:48 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFoNp2s5aQzVKSKFx6qk7lk3zGXEZJ8/7jDiSVv0Zx5eP1DVb8xLbezY2uN19SgHRVRrpK0niHqKcmkOSjxxw8= X-Received: by 2002:a2e:a989:0:b0:2fb:5a19:5b92 with SMTP id 38308e7fff4ca-2fca827fb8amr32729941fa.40.1729856748268; Fri, 25 Oct 2024 04:45:48 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: David Marchand Date: Fri, 25 Oct 2024 13:45:37 +0200 Message-ID: Subject: Re: [PATCH v1 27/30] net/i40e/base: change time variables from 64 bit to 32 bit To: Anatoly Burakov , bruce.richardson@intel.com, jaroslaw.ilgiewicz@intel.com Cc: dev@dpdk.org, Thomas Monjalon , Luca Boccassi X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Oct 17, 2024 at 1:43=E2=80=AFPM David Marchand wrote: > > On Mon, Sep 2, 2024 at 11:58=E2=80=AFAM Anatoly Burakov > wrote: > > > > From: Jaroslaw Ilgiewicz > > > > Time variables were designed for 32 bit and 64 bit variables are not > > necessary. Changed all to 32 bit. > > > > Signed-off-by: Jaroslaw Ilgiewicz > > Signed-off-by: Anatoly Burakov > > --- > > drivers/net/i40e/base/i40e_common.c | 2 +- > > drivers/net/i40e/base/i40e_nvm.c | 6 +++--- > > drivers/net/i40e/base/i40e_prototype.h | 2 +- > > 3 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/drivers/net/i40e/base/i40e_common.c b/drivers/net/i40e/bas= e/i40e_common.c > > index 07e18deaea..a2cfafeda9 100644 > > --- a/drivers/net/i40e/base/i40e_common.c > > +++ b/drivers/net/i40e/base/i40e_common.c > > @@ -3596,7 +3596,7 @@ enum i40e_status_code i40e_aq_debug_write_registe= r(struct i40e_hw *hw, > > enum i40e_status_code i40e_aq_request_resource(struct i40e_hw *hw, > > enum i40e_aq_resources_ids resource, > > enum i40e_aq_resource_access_type acces= s, > > - u8 sdp_number, u64 *timeout, > > + u8 sdp_number, u32 *timeout, > > struct i40e_asq_cmd_details *cmd_detail= s) > > { > > struct i40e_aq_desc desc; > > diff --git a/drivers/net/i40e/base/i40e_nvm.c b/drivers/net/i40e/base/i= 40e_nvm.c > > index 2f6cd9eda5..185af67817 100644 > > --- a/drivers/net/i40e/base/i40e_nvm.c > > +++ b/drivers/net/i40e/base/i40e_nvm.c > > @@ -62,7 +62,7 @@ enum i40e_status_code i40e_acquire_nvm(struct i40e_hw= *hw, > > { > > enum i40e_status_code ret_code =3D I40E_SUCCESS; > > u32 gtime, timeout; > > - u64 time_left =3D 0; > > + u32 time_left =3D 0; > > Some logs (a few lines below) needs updating: > > i40e_debug(hw, I40E_DEBUG_NVM, > "NVM acquire type %d failed time_left=3D%" > PRIu64 " ret=3D%d aq_err=3D%d\n", > access, time_left, ret_code, > hw->aq.asq_last_status); > > And > i40e_debug(hw, I40E_DEBUG_NVM, > "NVM acquire timed out, wait %" > PRIu64 " ms before trying again. status=3D%d aq_err=3D%d\n", > time_left, ret_code, > hw->aq.asq_last_status); > > Afaiu, it should be PRIu32. > > This was raised by OBS CI: > https://build.opensuse.org/package/live_build_log/home:bluca:dpdk/dpdk/De= bian_12/x86_64 Reminder, this was mentionned during the maintainers call yesterday. Please send a fix. Thanks. --=20 David Marchand