From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CE943A0C47; Thu, 16 Sep 2021 22:22:22 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9322E407FF; Thu, 16 Sep 2021 22:22:22 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 245D54069E for ; Thu, 16 Sep 2021 22:22:21 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1631823740; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Kwq/SXX684GvKJuiTNLwgYHLj/Y2kJxBQexLL51DWt4=; b=CnyyFti3Att/Y6TZyXlCNpKViZfwBYTHdQwMaVnwDgTJfIImv9DAztGbqbl1vaOH5dL8Et Miywe6LvARxu0ACYtu4K/ydAzLLNrrrkcPPEEdzmqlyLp5YU0CUCKfa8oUtuK7IAvsFbHd Oi8z0hbQmfAA8w3nkt2sowyvOzfwNiQ= Received: from mail-lf1-f70.google.com (mail-lf1-f70.google.com [209.85.167.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-392-Oe3ZFlFiOTqvBO94eudjFA-1; Thu, 16 Sep 2021 16:22:19 -0400 X-MC-Unique: Oe3ZFlFiOTqvBO94eudjFA-1 Received: by mail-lf1-f70.google.com with SMTP id h3-20020ac25d63000000b003f11192275eso4870076lft.19 for ; Thu, 16 Sep 2021 13:22:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Kwq/SXX684GvKJuiTNLwgYHLj/Y2kJxBQexLL51DWt4=; b=P7VlcrT0I4MEpHslJrhk45Nq8A2x6Gh7djoZTDv6K+Ltq+eiN4kBZDXiUrYBl+7jfk gQRHYTvLObax+DMRhJUwRGSkWQfbjE1D5fYIzQs+tt6qo0GKXG2dcWInQ4ci3HcXRVOO 1NyWLMF9xsHxF3A80b/cLNxV9FTRSRiWbslPGVTcXh2AEkMedLcZP+tTmxbQ3/WHJvfc veU6mZf/kN3BFaPSYiYV+IwuWu0IGzk9wefl64tFz1F/HsZKCCupHydqmq+0In6qJ/La Bc8i+44WTVQdAvPKJtkxkYueo/7duBBq56iJhAjaAd7V4+dJ95QYOdAC8uWr6orvLHLy 2Qdw== X-Gm-Message-State: AOAM530Lc9fDLdhCK9TwiKC5w9Iy/Igfd7dAArhqB+li5lraKf7XLqTs ssX3nOuu9o8f65or01HJD8e0BewfiaJZxFMFF0rmwSzLW0tsVEQCfxrcJwoFkxM6qilkiJ4SP4H iNzi291Xrl1eNOTs/TqQ= X-Received: by 2002:a05:6512:10d6:: with SMTP id k22mr5345686lfg.575.1631823737993; Thu, 16 Sep 2021 13:22:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz2r9dkgqrDl0HFCgNVE5i1uI+0HDZI15JUehiEdX7/H7asTi9QCQigq5zkhZ6W2Tn2ZhCRGPRp+pPvYYuHRHE= X-Received: by 2002:a05:6512:10d6:: with SMTP id k22mr5345676lfg.575.1631823737812; Thu, 16 Sep 2021 13:22:17 -0700 (PDT) MIME-Version: 1.0 References: <20210901093847.2269921-1-conor.walsh@intel.com> In-Reply-To: From: David Marchand Date: Thu, 16 Sep 2021 22:22:06 +0200 Message-ID: To: Conor Walsh Cc: Bruce Richardson , Ciara Power , "Wiles, Keith" , dev , Zhihong Peng , Conor Fogarty Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dmarchan@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] eal: fix memory leak when saving arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Sep 1, 2021 at 11:59 AM Bruce Richardson wrote: > > On Wed, Sep 01, 2021 at 09:38:47AM +0000, Conor Walsh wrote: > > This patch fixes a memleak which was reported in Bugzilla within the > > eal_save_args function. This was caused by the function mistakenly > > adding -- to the eal args instead of breaking beforehand. > > > > Bugzilla ID: 722 > > Fixes: 293c53d8b23c ("eal: add telemetry callbacks") > > > > Reported-by: Zhihong Peng > > Signed-off-by: Conor Walsh > > Signed-off-by: Conor Fogarty > > --- > Acked-by: Bruce Richardson Applied, thanks. -- David Marchand